petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> > Yes, I confirm that. Many thanks @zdila to push this PR.
> > We may take over it.
>
> Are you planning on taking over this PR? I have some work that will build on
> it, but I want to figure out what order to do the work in.
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Are the maintainers planning to make the final changes here, or should
> someone from the community do it?
I am planning to it in the next 2 weeks
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
@petr-hajek pushed 1 commit.
4a0fbba2fd57623718f90c56ba8d82c662368a7f Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/8fc98e107970781caffed51aa5adaee913315363..4a0fbba2fd57623718f90c56ba8d82c662368a7f
You are receiving thi
@petr-hajek commented on this pull request.
> @@ -79,3 +79,18 @@
osm_france_link:
id: "osm_france"
href: "https://openstreetmap.fr/";
+
+- leafletOsmId: "OpenMapTiles"
+ code: "V"
+ layerId: "openmaptiles_osm"
+ nameId: "openmaptiles_osm"
+ apiKeyId: "maptiler_key"
@petr-hajek pushed 1 commit.
cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a0fbba2fd57623718f90c56ba8d82c662368a7f..cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b
You are receiving thi
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
In the end I keep maplibre v4 with maplibre-gl-leaflet 0.0.22 since for some
reason the custom attribution got broken after updating. Someone else can
update this in some followup PR.
--
Reply to this email directly or view i
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Is there an api key I can use for testing? You can let me have it privately
> if you prefer...
I believe it should work with the Free account so just by signing up here you
can get one: https://cloud.maptiler.com/account/key
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Whether or not the style.json path definition changes, this now looks good to
> me. That could also be worth revisiting when there's more than one vector
> style. Tests pass in my fork
> [hlfan#18](https://github.com/hlfan/o
@petr-hajek pushed 1 commit.
bd723208a345d1bcef325fdd233d777d0e2bca41 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/76ea626c96119c7fa401818efd264d58f0d2cb51..bd723208a345d1bcef325fdd233d777d0e2bca41
You are receiving thi
@petr-hajek pushed 1 commit.
f8bd0b0153138be2f8c498370a3cc6665436b787 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/bd723208a345d1bcef325fdd233d777d0e2bca41..f8bd0b0153138be2f8c498370a3cc6665436b787
You are receiving thi
@petr-hajek pushed 1 commit.
8fc98e107970781caffed51aa5adaee913315363 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/fdc3e9da260c603bad306be6d28d58fc8018d109..8fc98e107970781caffed51aa5adaee913315363
You are receiving thi
@petr-hajek pushed 1 commit.
fdc3e9da260c603bad306be6d28d58fc8018d109 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f8bd0b0153138be2f8c498370a3cc6665436b787..fdc3e9da260c603bad306be6d28d58fc8018d109
You are receiving thi
@petr-hajek commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(OSM
@petr-hajek pushed 1 commit.
f08892f2cc41deec0a88a60aefb1e184754b22b4 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/e0a533374d2127a2c3467bd6b090582f345bcaa7..f08892f2cc41deec0a88a60aefb1e184754b22b4
You are receiving thi
@petr-hajek pushed 1 commit.
7565be18217452402e4a51c331cdc2f84af26328 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/0881ffa40e2b07036e2d81b452704c8c0b2a4c50..7565be18217452402e4a51c331cdc2f84af26328
You are receiving thi
@petr-hajek pushed 1 commit.
76ea626c96119c7fa401818efd264d58f0d2cb51 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/7565be18217452402e4a51c331cdc2f84af26328..76ea626c96119c7fa401818efd264d58f0d2cb51
You are receiving thi
@petr-hajek pushed 1 commit.
0881ffa40e2b07036e2d81b452704c8c0b2a4c50 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f08892f2cc41deec0a88a60aefb1e184754b22b4..0881ffa40e2b07036e2d81b452704c8c0b2a4c50
You are receiving thi
@petr-hajek pushed 1 commit.
a28f6dbbe4f4e12489c4ad91d38118de56958ff0 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86..a28f6dbbe4f4e12489c4ad91d38118de56958ff0
You are receiving thi
@petr-hajek pushed 1 commit.
4a7b1374945d8577ea7ec5408b05aeca02e5c497 revert vsc settings change
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/a28f6dbbe4f4e12489c4ad91d38118de56958ff0..4a7b1374945d8577ea7ec5408b05aeca02e5c497
You are receiving this
@petr-hajek pushed 1 commit.
e0a533374d2127a2c3467bd6b090582f345bcaa7 fix trailing coma
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a7b1374945d8577ea7ec5408b05aeca02e5c497..e0a533374d2127a2c3467bd6b090582f345bcaa7
You are receiving this because
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
@tomhughes I tried to address all the raised issues. Please bear with me as
this is my first PR to this repo, I'm ready for the feedback. Could you
authorize me to run the workflows to see if all the lints and test will pass?
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
@tomhughes PM sent from https://www.openstreetmap.org/user/bananaboy on OSM -
in case you want to use a different means of communication, please let me know
there
--
Reply to this email directly or view it on GitHub:
https://
petr-hajek left a comment (openstreetmap/openstreetmap-website#6220)
@hlfan I've tried running master locally using Docker and this issue does not
occur to me. Neither do the other issues such as
https://github.com/openstreetmap/openstreetmap-website/issues/6229 and
https://github.com/openstree
petr-hajek left a comment (openstreetmap/openstreetmap-website#6231)
Also there's arabic & hebrew missing for OMT by MapTiler when switched to these
languages. But locally it works for me.
https://github.com/user-attachments/assets/e6b72055-3607-470a-8b18-b95608c3d67a";
/>
--
Reply to this em
petr-hajek left a comment (openstreetmap/openstreetmap-website#6231)
> I suspect this is due to missing `@mapbox/mapbox-gl-rtl-text` dependency.
https://github.com/maptiler/openstreetmap-website/blob/master/package.json#L5
https://github.com/maptiler/openstreetmap-website/blob/master/app/assets
petr-hajek left a comment (openstreetmap/openstreetmap-website#6229)
Possibly related to
https://github.com/openstreetmap/openstreetmap-website/issues/6220
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6229#issuecomment-31067
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Thanks @petr-hajek I had in fact already registered a key there I had just
> forgotten about it ;-)
>
> I think this is good to merge now - what do you want to do about a key for us
> to use in production? Am I OK just to re
@petr-hajek requested changes on this pull request.
I think to avoid code repetition between maptiler and shortbread, best would be
to move the logic to leaflet.maplibre.js
```
L.OSM.MaplibreMap = L.MaplibreGL.extend({
_getAttribution: function () {
return this.options.attribution;
},
petr-hajek left a comment (openstreetmap/openstreetmap-website#6220)
> Still occurs for me running
> [af93c83](https://github.com/openstreetmap/openstreetmap-website/commit/af93c83f7ba717f3d7d42f8d8d8d9156d9665c7e),
> also locally using Docker. I've tweaked the reproduction steps to include
> v
petr-hajek created an issue (openstreetmap/openstreetmap-website#6229)
### URL
_No response_
### How to reproduce the issue?
https://www.openstreetmap.org/#map=6/49.43/9.56&layers=V
There should be the `openmaptiles_credit` displayed as in
https://github.com/openstreetmap/openstreetmap-website
@petr-hajek approved this pull request.
tested and works well, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6236#pullrequestreview-3056668493
You are receiving this because you are subscribed to this thread.
Message
petr-hajek left a comment (openstreetmap/openstreetmap-website#6236)
@tomhughes can we merge this?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6236#issuecomment-3133056356
You are receiving this because you are subscribed to t
petr-hajek left a comment (openstreetmap/openstreetmap-website#6236)
@AntonKhorev maybe you could have a look and merge this? Many thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6236#issuecomment-3135299274
You are receiv
33 matches
Mail list logo
