Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)

2024-11-20 Thread mxdanger via rails-dev
> Maybe for discussion in #5328 to conclude? @matkoniecz The problem is that the map should not have been dimmed to begin with, especially without any proper discussion. This should be merged and the map should remain as default until #5328 is concluded. -- Reply to this email directly or view

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-19 Thread mxdanger via rails-dev
Dimming the map was probably the worst possible thing contributors (cough cough @AntonKhorev) could have done. It's a terrible stop gap solution and it really did fumble the launch of dark mode. What could have been a nice update that just made the UI dark, they _really_ just had to mess with th

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-18 Thread mxdanger via rails-dev
The logical decision would be unaltered map as the default. Until vector maps are implemented, any tampering with the map via CSS filters should be avoided. It’s still ridiculous to me that the dimmed map was implemented in the first place with no discussion in #4712 aside from @tomhughes who do

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-11-14 Thread mxdanger via rails-dev
There should be absolutely no image or map dimming. It just reduces readability. Just leaving this comment here so an option is **NOT** created for it. The dimming shouldn’t be a thing. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/

Re: [openstreetmap/openstreetmap-website] Dark mode menu (PR #5336)

2024-11-16 Thread mxdanger via rails-dev
Again, what will the default be? There is overwhelming feedback against modification of the map. The default should be 100% brightness (no modification) but I’m wondering if your stance on this is the same. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/

Re: [openstreetmap/openstreetmap-website] Dim map tiles in dark mode (PR #4712)

2024-11-14 Thread mxdanger via rails-dev
> There are two options: dim them or invert them You left out the third option of not changing anything! Just leaving my two cents here to say this should be reverted. Thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4712#

Re: [openstreetmap/openstreetmap-website] Dark Mode (#2332)

2024-11-14 Thread mxdanger via rails-dev
I really hope the dim filter over the map is removed. Either have a proper dark tile map or just don’t touch it at all. It just looks terribly washed out. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2477483

Re: [openstreetmap/openstreetmap-website] Use CSS filter instead of dimming tiles (PR #5325)

2024-11-14 Thread mxdanger via rails-dev
For the time being this should be discussed in depth and not treated as a "quick fix". Theres serious implications to changing the color of a map that has been meticulously colored and iterated on for the past decade. Realistically, I don't expect a "default" dark map theme until the vector map

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)

2024-11-15 Thread mxdanger via rails-dev
Glad to see this change! It's a shame that @AntonKhorev saw all the feedback about the dimmed map and completely ignored it with fast tracking this change #5330 instead of removing the filter all together until #5336 is completed. -- Reply to this email directly or view it on GitHub: https://gi

Re: [openstreetmap/openstreetmap-website] Dark mode menu (PR #5336)

2024-11-15 Thread mxdanger via rails-dev
Will 100% brightness be the default? From what I understand to be the sole criticism (mine included) of the initial introduction dark mode was the dimmed map. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5336#issuecomment-2480

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread mxdanger via rails-dev
This whole dimmed tiles situation really goes to show how much of a mess this project management is at the moment. How can something as important as the MAP ITSELF be treated as an afterthought? It is quite literally the most important part of the website yet no community discussion took place

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-12 Thread mxdanger via rails-dev
I saw the website got an update but it unfortunately still uses the dimmed tiles as default with OS dark mode despite all of this discussion. Is @AntonKhorev still pushing for the dimmed tiles alone? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstre

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-16 Thread mxdanger via rails-dev
mxdanger left a comment (openstreetmap/openstreetmap-website#5924) This should be reverted. It's really trying to solve a problem but going about it in the wrong way. This PR just visualizes the annoyance of not being able to see that the changeset you're hovering over is. Here's my proposal:

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-18 Thread mxdanger via rails-dev
mxdanger left a comment (openstreetmap/openstreetmap-website#5924) > > selected list-group-item > > > > Selected how? There's no selection mechanism as of right now. You might be confused. When you hover over a changeset bbox on the map it marks the respective changeset in the side bar as sel

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-18 Thread mxdanger via rails-dev
mxdanger left a comment (openstreetmap/openstreetmap-website#5924) > If what you propose is sidebar scrolling frantically as you move your mouse > over the map (and not scrolling anywhere when you're using a device without a > mouse), I expect about 10x more posts starting with "This should be r