Some more cleanups for `bundle exec i18n-tasks health`.
* ChangesetHelper: we have multiple definitions and translations of the same
"anonymous" string. Key "changesets.*" is more in line with
the other translation keys used in the changeset helper file.
Further details in respective commit me
@mmd-osm pushed 2 commits.
efb3e0c81be04b2c40f131fefabd3d8bd768cb61 Ignore users.auth_failure.* as unused
translation
57b402f8fe9667c44093eea16ecb5592617f Remove unused translation key
users.new.external auth
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pu
@mmd-osm pushed 1 commit.
5aa63c60ec7ab98eeb6f595a527f7a525e807a47 Remove unused .greeting translation
in changeset_comment_notification
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5217/files/57b402f8fe9667c44093eea16ecb5592617f..5aa63c60ec7ab98eeb6f59
@mmd-osm pushed 1 commit.
bcc07e87bf29997fb5935918f923c8f2551d Remove unused Namefinder translation
strings
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5217/files/5aa63c60ec7ab98eeb6f595a527f7a525e807a47..bcc07e87bf29997fb5935918f923c8f2551d
You ar
Moderators can hide changeset comments, sysadmin/operations can completely
remove the data, if needed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomment-2352284851
You are receiving this because you are subscribe
Best is to send an email to operations with all relevant details.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomment-2352714939
You are receiving this because you are subscribed to this thread.
Message ID:
__
Timestamp + version is not stable. cgimap does mass inserts/updates, where
elements have the exact same timestamp down to the µs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5209#issuecomment-2353545924
You are receiving this
You can pretty much ignore this hint, there’s no need for further action here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5217#issuecomment-2356743397
You are receiving this because you are subscribed to this thread.
Message
Right, I had another issue in mind where you would see error messages in
whatever language that happens to be set previously. I can't find it at the
moment...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5251#issuecomment-23
By the way, most third party login providers should support 2FA. This might be
a good alternative for the time being.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3476#issuecomment-2408929916
You are receiving this because yo
New entry for highway=busway to be added here:
https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L920
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2408916808
You are
New entry for highway=busway to be added here:
https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L920
--
Reply to this email directly or view it on GitHub:
https://g
Looking through existing translations, it might be even better to have three
separate strings for each of the three relevant layers. Instead of "Image will
show the %{layer} layer at %{width} x %{height} ", that would be:
* Image will show the Standard layer at %{width} x %{height}
* Image will
According to
https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#nominatim-prefixes,
"I18n keys under the geocoder.search_osm_nominatim" are managed by Nominatim
maintainers.
I'm not exactly clear how this was done in the past. Maybe @lonvia can help
here.
--
R
See
https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2410282588
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5260
-- Commit Summary --
* Remove Nomatim prefixes mention in contribut
@mmd-osm approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3715#pullrequestreview-2370327606
You are receiving this because you are subscribed to this thread.
Message ID:
@mmd-osm commented on this pull request.
> @@ -1603,12 +1603,12 @@ en:
footer_html: "You can also read the message at %{readurl} and you can
send a message to the author at %{replyurl}"
friendship_notification:
hi: "Hi %{to_user},"
- subject: "[OpenStreetMap] %{user} add
Fixes #5253. As requested by LWG.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5254
-- Commit Summary --
* Update link for Austria data sources
-- File Changes --
M config/locales/en.yml (2)
-- Patch Links
@kathleenlu09 is LWG member, that's why I created the PR right away.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5253#issuecomment-2402862923
You are receiving this because you are subscribed to this thread.
Message ID:
___
As per
https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#i18n,
I'm closing this PR:
_If you make a change that involve the locale files (in config/locales) then
please **only submit changes to the en.yml file**. The other files are updated
via [Translatewiki](h
Closed #5257.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5257#event-14604609966
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
> > Assuming we need to convert SVGs to PNGs
>
> I'm not suggesting that.
Ok, I think you would need to further elaborate on your proposal, because it’s
still not clear to me how this looks in detail. Please provide some working
code snippets which addresses both position and coloring of svg. A
Related issue for API error messages: #2227
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5251#issuecomment-2396664674
You are receiving this because you are subscribed to this thread.
Message ID:
@mmd-osm pushed 1 commit.
6a22d04098506f62609998599256b423bea0f9e9 Trace import: remove
activerecord-import gem
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/d41d61856f499de9a40969bd676cd34d99bbc529..6a22d04098506f62609998599256b423bea0f9e9
You ar
I suppose the issues listed below are a side effect of #5084. I would just fix
the respective unit tests to re-align them with the current implementation.
```
1) OSM .formatHash formats lat/lon/zoom params
Failure/Error: expected '#map=9/57.625/-3.685' to equal
'#map=9/57.6247/-3.6845'
@mmd-osm pushed 1 commit.
77dabb6abfd1eef8241d79fe648a01ad16e13fda Danger test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..77dabb6abfd1eef8241d79fe648a01ad16e13fda
You are receiving this because you are s
Closed #5252 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5252#event-14723546783
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@mmd-osm pushed 1 commit.
9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929 Danger test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/77dabb6abfd1eef8241d79fe648a01ad16e13fda..9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929
You are receiving this because you are s
@mmd-osm pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving this because you are subscribed to this thread.
Message ID:
@mmd-osm pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving this because you are subscribed to this thread.
Message ID:
@mmd-osm pushed 1 commit.
23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd Danger test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd
You are receiving this because you are s
@mmd-osm pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving this because you are subscribed to this thread.
Message ID:
https://github.com/openstreetmap/openstreetmap-website/actions/runs/11407724340/job/31744367292
seems to be doing a bit better. I have replaced `pull_request_target:
types: [opened, synchronize]` by `on: [pull_request]`.
The token doesn't have access to remove or add labels:
```
Error me
@mmd-osm pushed 1 commit.
c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff Danger test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff
You are receiving this because you are s
I don't think share links with node/way/relations are a good fit for sharing
and publishing elsewhere. Remember, element ids are not stable and could change
at any time, even by your "criminals".
I vote for closing this issue, since it's fairly off topic for the site.
--
Reply to this email di
@mmd-osm pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/915cb20421c0304804efe0c7ed6eb17e397ed79d..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving this because you are subscribed to this thread.
Message ID:
@mmd-osm pushed 1 commit.
915cb20421c0304804efe0c7ed6eb17e397ed79d Danger test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..915cb20421c0304804efe0c7ed6eb17e397ed79d
You are receiving this because you are s
Closed #5252 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5252#event-14723554282
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
> I messed up https://github.com/openstreetmap/openstreetmap-website/pull/5257
> so I'll just open an issue instead.
You’ve only changed the wrong file, just do your changes in en.yml instead…
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-w
Thanks, this looks like a great suggestion. I gave it a try, created a new
clone of the repo, then added a new devcontainer using `bundle exec rails
container.`
Initially I was a bit struggling with (Debian, Rails, npm) packages on
generated devcontainer. I believe we can probably reuse a lot o
FYI: Since it doesn't really make sense to replicate each and every routing UI
feature on the osm.org repo, we're looking to add a direct link to various
routing engines in #5224
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/
@mmd-osm pushed 1 commit.
4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7 Another danger test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7
You are receiving this because y
@mmd-osm pushed 1 commit.
f99d63bafd5f956773f740cb549d019179cbbf20 danger testing
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7..f99d63bafd5f956773f740cb549d019179cbbf20
You are receiving this because you ar
I found another alternative in https://github.com/chef/chef/pull/14134, which
is danger-js. It seems to work on a forked repo pull request:
The output is a bit buried in gh action logs. Fancy things like se
@mmd-osm pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/f99d63bafd5f956773f740cb549d019179cbbf20..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving this because you are subscribed to this thread.
Message ID:
I think that's fine. Log files from 3 weeks ago show that danger was running
back then:
https://github.com/danger/danger/actions/runs/11090746237/job/30813474684
--
Reply to this email directly or view i
Here's another comparison at 250% zoom. The old rendering looked a bit off, in
particular for the _(part of ways...)_ section.
Old | New
-- | --
|
![new1](https://github.com/user-attachments/assets/df24bae
> There's no single API call to get geometry [of] old versions of elements
> other than nodes.
This doesn’t mean we couldn’t introduce such an API endpoint. Ways should be
ok, relations could be a bit expensive.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
As noted elsewhere, we probably don't need to store the original gpx files in
the first place. All relevant details should be in the gps_points table
already. Or am I missing something here?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-web
It seems this Danger issue might be related:
https://github.com/danger/danger/issues/1103
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2417742102
You are receiving this because you are subscribed to this thr
@mmd-osm pushed 1 commit.
9608220336e83cafc6774e1f5637b61d4f678357 Unauthenticated session expiry
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/f99b2ad1b82554dbd3a799a7c53fab4f53f7146b..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving thi
What about RUNNING_IN_ACTIONS=true ? This seems to be still missing.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2421500814
You are receiving this because you are subscribed to this thread.
Message ID:
___
I haven’t checked the code before. They’re using it in their own Dangerfile to
control junit reporting. So it’s really irrelevant for us:
https://github.com/danger/danger/blob/cd913ea817a2fb9536172597303d78492a727668/Dangerfile#L56
--
Reply to this email directly or view it on GitHub:
https://g
> I'm explicitly passing it's hash as the head. [...] PR branch should still be
> present and accessible.
I suspect that there must be more to pull_request_target to prevent untrusted
code from accidentally being executed with elevated privileges...
--
Reply to this email directly or view it
Fails
:no_entry_sign:
`bla.sh` failed.
### Log
```
```
Generated by :no_entry_sign: https://danger.systems/js";>dangerJS
against 7aeafbd890108734b866df1eaac8ef9b595d5cab
--
Reply to this email directly or view it on
I've taken my question over to
https://github.com/danger/danger/issues/1103#issuecomment-2430080724
Maybe you can keep an eye the discussion over there a bit. We probably need to
move to danger-js.
https://danger.systems/js/usage/danger-process as proposed in one answer seems
to fit nicely to
Fails
:no_entry_sign:
`bla.rb` failed.
### Log
```
Hello from ruby!
{
"fails": [
{
"message": "Gem/Bundle changes were not documented in the Description. If
this is a major update, add #gemlock_major_upgrade to the
Fails
:no_entry_sign:
bla
Generated by :no_entry_sign: https://danger.systems/js";>dangerJS
against 7aeafbd890108734b866df1eaac8ef9b595d5cab
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/op
@mmd-osm pushed 1 commit.
429cb593fccb03360b4c140be0782621708a14bf Unauthenticated session expiry
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..429cb593fccb03360b4c140be0782621708a14bf
You are receiving thi
It seems it's still failing:
https://github.com/openstreetmap/openstreetmap-website/actions/runs/11466048440/job/31905883310?pr=5270
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2429943268
You are receiving
Yes, it's a security feature:
https://github.blog/news-insights/product-news/github-actions-improvements-for-fork-and-pull-request-workflows/
_-> new pull_request_target event [...] runs against the workflow and code
from the base of the pull request. This means the workflow is running from a
https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
might be interesting. It describes a set up, where untrusted code is processed
by an `on: pull_request` step (which has access to the pull request). In this
step we could run danger, similar to what chef/chef is doi
I can't validate the assumption in production and don't know what test cases to
add. Or in other words, I was stuck with the current state and decided to close
it, as there's no way to make any progress on it.
Assuming a slab is full and new entries need to be added. There are two
possible opti
Gemfile.lock update seems to be missing in the PR...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5295#issuecomment-2447300140
You are receiving this because you are subscribed to this thread.
Message ID:
_
@nenad-vujicic : this might be a good topic for another rule in Dangerfile.
Something like:
```
gemfile_modified = git.modified_files.include?("Gemfile")
gemfile_lock_modified = git.modified_files.include?("Gemfile.lock")
if gemfile_modified && !gemfile_lock_modified
warn("Gemfile was updated,
Fails
:no_entry_sign:
Gem/Bundle changes were not documented in the Description. If this is a major
update, add #gemlock_major_upgrade to the PR Description.
Generated by :no_entry_sign: https://danger.systems/js";>dangerJS
ag
Closed #5038.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038#event-14965898966
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #4694.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4694#event-14965892280
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #5071.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5071#event-14965975015
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #5270.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270#event-14965984261
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@mmd-osm pushed 1 commit.
0d4d86e0820910d527f1be0364f62e3a767bc3e7 Unauthenticated session expiry
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/429cb593fccb03360b4c140be0782621708a14bf..0d4d86e0820910d527f1be0364f62e3a767bc3e7
You are receiving thi
I tried another pull request #5270, and here it seems to be working fine. The
only obvious difference I can spot is that #5080 has a lot more commits.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2440106153
Yo
@mmd-osm pushed 1 commit.
7f643077ca62fc39714967d9315be8e83f905c94 Trace import: remove
activerecord-import gem
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/6a22d04098506f62609998599256b423bea0f9e9..7f643077ca62fc39714967d9315be8e83f905c94
You ar
@mmd-osm pushed 1 commit.
961a16749ab89769c97d167396dcaa077e530f25 Using osm.org as identity provider
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5071/files/5b61d54da9b213474b301b18653b007429e9cbdc..961a16749ab89769c97d167396dcaa077e530f25
You are receiving
I think there's still an issue... I did a rebase on master + force push. Danger
is still failing:
https://github.com/openstreetmap/openstreetmap-website/pull/5080
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-
Closing because #3715 supersedes this PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1189#issuecomment-2440125883
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #1189.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1189#event-14929561553
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Could it be that danger is checking a certain number of commits by default
only? I tried adding one commit at a time in
https://github.com/openstreetmap/danger-test/pull/6, and it worked at least up
to 15 commits. The failing PR had 20 commits.
--
Reply to this email directly or view it on Git
@mmd-osm pushed 20 commits.
88255573de25e59f6ae4d95544478dbdbcce02a7 Browse icons as svg
f484f93b8a82c931e1f4b971f2faa848f239e67b Visibility improvements for dark mode
c2e6dc276384c311fd89c17401560997c443ae99 Fine tune position of 9 svg symbols
81f6f5eeeb1c1283165535d5310bab693be5b335 Replaced
Danger starts failing once the PR has >= 20 commits:
https://github.com/openstreetmap/danger-test/pull/6
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2440147247
You are receiving this because you are subscri
_I'm moving the discussion from #5290 over to this issue..._
I had some issues with danger not being able to correctly process #5080. I can
also reproduce the issue in the danger test repo:
https://github.com/openstreetmap/danger-test/pull/5
--
Reply to this email directly or view it on Gi
I'm trying the complex scenario with 2 CI steps. I've started with the second
half that's updating the pull request:
https://github.com/test-9bf40560-ba4d/dangertest/pull/7
Have you tried to post some comments and fail the build in case of issues?
--
Reply to this email directly or view it on
https://discuss.graphhopper.com/t/how-to-handle-when-street-name-changes-on-a-route/5528
mentions some url parameter to get all street names. I haven’t checked what
options other routing engines are offering.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
It seems you need to update the commit hash in Gemfile.lock. This works for me:
```
diff --git a/Gemfile.lock b/Gemfile.lock
index 346af2baa..d1bf08281 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -8,7 +8,7 @@ GIT
GIT
remote: https://github.com/tomhughes/danger.git
- revision: 5794971ade
Quick comment: you would also need to change a few unit tests with the same
issue:
- test/controllers/user_roles_controller_test.rb:74
- test/controllers/user_roles_controller_test.rb:134
- test/controllers/messages_controller_test.rb:248
- test/controllers/messages_controller_test.rb:305
Can yo
Looks good now. The danger failure is expected, you can't test any changes to
Danger with a cross repo PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2439551743
You are receiving this because you are subscri
Closed #4994 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4994#event-15046953456
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
This seems a bit odd. The POST request already returns an HTTP return code 303
along with a `location: https://www.openstreetmap.org/messages/inbox` header
for the redirect.
According to https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/303 the
browser is supposed to ignore the payload
@mmd-osm pushed 3 commits.
a8037a2329d761901eb303657b533ae24535697a Browse icons as svg
872eb6f885c55a7dcb0d882dd259e45694ffa16d Visibility improvements for dark mode
783a05b16398ba8626f8fd3b6be2430e5a336ccc Fine tune position of 9 svg symbols
--
View it on GitHub:
https://github.com/openstre
I have updated the example URLs from above to only require start lat/lon and
end lat/lon values as well as a profile.
* Valhalla:
`https://valhalla.openstreetmap.de/directions?profile=pedestrian&wps=120.8635823%2C24.1893169%2C120.8648163%2C24.1825192`
* OSRM:
`https://routing.openstreetmap.de/
Thank you for reviewing this PR another time.
> some icons are too dark, I inverted and hue-rotated them; here it's not done
> I suppose; see place_of_worship icon for an extreme example
Agree, that's also something I've noticed. I'm pushing another commit now which
should improve the situation
@mmd-osm pushed 1 commit.
ea30534be46a5150295a53c2c67b45332fd91c52 Visibility improvements for dark mode
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/40c07ec9b7b87923f3236ea09b9e30c35f973bb4..ea30534be46a5150295a53c2c67b45332fd91c52
You are receiv
In #5210, updating the OSM community index failed due to invalid replacement
tokens. This issue needs to be resolved upstream. However, we can add a bit of
error handling and still apply the update. EN is used for erroneous
translations.
You can view, comment on, or merge this pull request onli
I've added dedicated css formatting for 9 SVG symbols now, to improve
positioning and/or size of the respective symbols. Maybe you could take another
look now. If necessary, please suggest exactly which symbol should be changed
and how.
The approach should be flexible enough to allow for furthe
@mmd-osm pushed 1 commit.
d41d61856f499de9a40969bd676cd34d99bbc529 Trace import: remove
activerecord-import gem
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/8367e6d6d86ae7849fd3238546e55a52baec1c78..d41d61856f499de9a40969bd676cd34d99bbc529
You ar
@mmd-osm commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ transfo
While the discussion in #5038 is still ongoing, I have moved the unit test to a
new PR.
Validating the results of trace import background job is useful for both
scenarios
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pul
@mmd-osm commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ transfo
@mmd-osm pushed 1 commit.
2ff0b3617bde2fe206875ef8bc004fdf41aec894 Replaced two png by svg symbols
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/783a05b16398ba8626f8fd3b6be2430e5a336ccc..2ff0b3617bde2fe206875ef8bc004fdf41aec894
You are receiving th
My goal was to remove the activerecord-import gem by a built in equivalent
method. Since the validations are not automatically executed anymore, I added
the call to the validate method. Rubocop is not clever enough to figure out
that we're validating the model contents earlier on, so we need an
1 - 100 of 192 matches
Mail list logo
