Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of .js.erb files (PR #5559)

2025-02-05 Thread Splines via rails-dev
Nice, flattered that you use my plugin now at openstreetmap ;) If anything is not working, just [open an issue](https://github.com/Splines/eslint-plugin-erb). And feel free to leave a GitHub star should you like it 😊 -- Reply to this email directly or view it on GitHub: https://github.com/open

Re: [openstreetmap/openstreetmap-website] Repo: editor help to find eslint config file (Issue #5572)

2025-01-29 Thread Splines via rails-dev
Just to add my two cents: it's very common to have a `.vscode` in your repo if many devs use VSCode. If you don't want to see the folder locally, you can even add this to the `.vscode/settings.json`: ```ts "files.exclude": { ".vscode": true, } ``` There are so many great settings you can spec

Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)

2025-01-24 Thread Splines via rails-dev
If you introduce linting here you might also be interested in: - How we use ESLint on GitHub Actions via [this file](https://github.com/MaMpf-HD/mampf/blob/23aae01471c4361b85e86df06e349cd8acfb735c/.github/workflows/linter.yml#L39-L75) to lint only the changes inside changed `.js` and `.js.erb` f

Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)

2025-01-28 Thread Splines via rails-dev
> Up until now, whenever I was writing JavaScript, I struggled to get ESLint to > work as seamlessly as Prettier @kcne Feel free to use a configuration like the one [I use here](https://github.com/Manim-Notebook/manim-notebook/blob/68874a7e30489d8774ffc53ddfd96cbc7d885ba6/.vscode/settings.json#L

Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)

2025-01-25 Thread Splines via rails-dev
> Most stylistic rules are now removed from eslint because most use a formatter > like prettier.io @HolgerJeromin Formatting rules have indeed been [deprecated](https://github.com/eslint/eslint/issues/17522) in the _core_ of ESLint. But mainly because of ongoing maintenance cost. Luckily, antfu