Re: [openstreetmap/openstreetmap-website] Move History and Export buttons to secondary nav (PR #5151)

> we get feedback on this Yes, get it :) I won't ask you to return everything back, because the Edit button is now more visible for beginners. But the current implementation has a problem: when you narrow the screen width, there is too much empty space that the History and Export buttons used t

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

https://www.openstreetmap.org/traces You might want to change the text color on a bright green background. For the example I changed the color to black and it seems to read better https://github.com/user-attachments/assets/6ae37ad7-5c54-451a-849d-e88be9f3d871";> -- Reply to this email direct

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

Map previews don't have a dark background in the layers menu. https://github.com/user-attachments/assets/983c8e81-fede-4821-98a4-37995d8852b2 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2478786176 You are

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

Although iD doesn't have a dark theme, it seems that you can reduce the annoyance of blinding when loading it by setting at least some dark or transparent background for the iframe. https://github.com/user-attachments/assets/8132c4d3-b55a-435f-8b7c-47042b43828f -- Reply to this email direct

[openstreetmap/openstreetmap-website] Replace the text with the icon in the parent relation list (Issue #5368)

### Problem After #5353 this already works for the ways: https://github.com/user-attachments/assets/6f4548f9-92e3-496e-8179-97e1988258e8";> https://www.openstreetmap.org/node/7925741250 But not for relations: https://github.com/user-attachments/assets/5ee293cd-0eaf-456e-a44a-c67d01a52851";> h

Re: [openstreetmap/openstreetmap-website] Suspend the layer event handlers when rendering Map Data (PR #5474)

@deevroman pushed 1 commit. f2b2baf26b0569de3a0e3814f09e8cdaed3d7b13 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/49834e5c1de3b70978ff836b2

Re: [openstreetmap/openstreetmap-website] Suspend the layer event handlers when rendering Map Data (PR #5474)

@deevroman pushed 1 commit. 920b7afc54401d4ba0b26e7ecddefb3a8dc0eade Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/f2b2baf26b0569de3a0e3814f

Re: [openstreetmap/openstreetmap-website] Suspend the layer event handlers when rendering Map Data (PR #5474)

@deevroman pushed 1 commit. a9579cec394e621082e2a813f07dc93897b62fe9 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/920b7afc54401d4ba0b26e7ec

Re: [openstreetmap/openstreetmap-website] Suspend the layer event handlers when rendering Map Data (PR #5474)

I also saw a problem in PR: when you click the Map Data checkbox, the cookie with the current location is no longer updated -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-2573244494 You are receiving this becaus

[openstreetmap/openstreetmap-website] Suspend the layer event handlers when rendering Map Data (PR #5474)

### Description This is fix #5466 After merging https://github.com/openstreetmap/leaflet-osm/pull/43 flame graph looks like this: https://share.firefox.dev/4a2Wc9Z Most of the time is

Re: [openstreetmap/openstreetmap-website] Don't remove-readd standard layer with visible overlays (PR #5573)

Yes, it also corrects blinking and works expected: https://github.com/user-attachments/assets/7f394758-06a4-4f6c-b782-68f31d069e9e The change in the layer through the URL also works. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/p

Re: [openstreetmap/openstreetmap-website] Fix map blink when active Mapnik + some overlay (PR #5570)

Closed #5570. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5570#event-16107086855 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Fix map blink when active Mapnik + some overlay (PR #5570)

@deevroman commented on this pull request. > +if (this.getMapBaseLayer() && this.getMapBaseLayer().options.code === > "M" && !layers.includes("M")) { + layers += "M"; +} No problems. If PR is no longer relevant, you can close it. -- Reply to this email directly or view it on Git

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. 5b37b549391bc12ca25019960c726aa306417ec3 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/a32249ec8ba1ebf437028bf15

Re: [openstreetmap/openstreetmap-website] Suspend the layer event handlers when rendering Map Data (PR #5474)

@deevroman pushed 1 commit. a359de90c209df00b40ba5520291b7e295b0b2c8 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/a9579cec394e621082e2a813f

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

Okay, firing events from `addObject` / `removeObject` turned out to be the best idea. And I changed this PR to use `baselayerchange`/`overlaylayerchange` I also replaced layeradd for `map.on("layeradd",...)`, which tracks the layer's on/off state with `dataLayer.on("add", ...)`. Using `overlayla

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman commented on this pull request. > @@ -124,7 +124,7 @@ L.OSM.layers = function (options) { map.fire("overlaylayerchange", { layer: layer }); }); -map.on("layeradd layerremove", function () { +map.on("baselayerchange overlaylayerchange", function ()

Re: [openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

@deevroman pushed 1 commit. a0d853d418e424481a9b6120ad86b1f650ece769 Fix left/right sidebar resizing on mobile devices -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/e75db2ceae901b24385a676054b8510280200e2a..a0d853d418e424481a9b6120ad86b1f650ece769

Re: [openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

@deevroman pushed 1 commit. 898ea3d1bc17468e3cfef0e36b6127e9208e70c0 Fix left/right sidebar resizing on mobile devices -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/6e64adb8c0d02008abcb8351169ed043464cc864..898ea3d1bc17468e3cfef0e36b6127e9208e70c0

Re: [openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

@deevroman pushed 1 commit. 6e64adb8c0d02008abcb8351169ed043464cc864 Fix left/right sidebar resizing on mobile devices -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/a0d853d418e424481a9b6120ad86b1f650ece769..6e64adb8c0d02008abcb8351169ed043464cc864

[openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

This PR fixes multiple issues about the map resetting its position when opening various menus on mobile devices. https://github.com/openstreetmap/openstreetmap-website/issues/4755 https://github.com/openstreetmap/openstreetmap-website/issues/991 ... 1. Get rid of the hardcoded left sidebar width

Re: [openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

I didn't take into account that sometimes centering is useful and necessary: https://github.com/user-attachments/assets/2c222546-6754-4605-9591-d42df41e9ffb -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5521#issuecomment-26008

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)

I remade PR. I abandoned `overlaylayerchange` because this event is not in Leaflet and it is not suitable in our situation. In the case of `baselyerchange`, we can expect that our last base layer is always removed and a new base layer is added. Therefore, the removal event is not necessary to t

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. 0707400118d51cf3a4160a4010eec7a89c90db79 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/57bff79cd6ac07a1cff816841

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. e3b440dc1059b9ba330335f6491d0ec95713b494 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/0707400118d51cf3a4160a401

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. 9a43e994a2402156641da95fafe63a0c975c059b Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/e3b440dc1059b9ba330335f64

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. dae7a003fee3c9a413c959381a558e4d5636f3bd Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/9a43e994a2402156641da95fa

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. 57bff79cd6ac07a1cff816841c8c2d2dd31778da Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/12fee32c04e44aebca2ea778c

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@mmd-osm > Besides, there may be some timing issue in the current code, as the behavior > is not 100% reproducible for me, even today. Sometimes the map layer changes > along with the share link, in other cases, the old layer is still shown. I think I found a way to reproduce this (If you meant

[openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)

#5551 added a window with an error if the user is trying to download too much data. But this window cannot be closed, only turn off the Map Data layer. But what if you have already turned it off? https://github.com/user-attachments/assets/0b40a9ed-c3b7-47ee-90fb-67b264880ff9 Now it looks like t

[openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)

After #5474, data rendering is no longer a bottle of performance. Modern browsers do a great job with moving the map, which displays many objects (moreover, it can also be accelerated) The only exception is mobile browsers. Therefore, I stopped at 4000 objects. You can view, comment on, or merge

Re: [openstreetmap/openstreetmap-website] Map Data overlay should not zoom by itself (Issue #3360)

It seems that Issue, as well as https://github.com/openstreetmap/openstreetmap-website/issues/2800 https://github.com/openstreetmap/openstreetmap-website/issues/3243, become outdated after https://github.com/openstreetmap/leaflet-osm/pull/43 (freezing before a warning) https://github.com/openst

[openstreetmap/openstreetmap-website] Fix map blink when active Mapnik + some overlay (PR #5570)

#5474 added an unpleasant blink when an overlay is enabled, and you try to close the sidebar: https://github.com/user-attachments/assets/4d3063b9-dd39-4553-844b-e2bd99c11241 This is because `var layers = layerParam || "M";` does not add `M` when overlay is enabled (`layerParam` is not empty).

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. 30403cb9307262871e7fa304430ca4d691e3bfb2 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/5b37b549391bc12ca25019960

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

> Otherwise if you edit &layers=X in the location bar, share urls are updated > to its previous value. Do I understand correctly that you are talking about the current behavior of the website, and not after PR? At least in Firefox, changing `&layers=X` does not change the layers on the map, onl

[openstreetmap/openstreetmap-website] "layeradd layerremove" event handlers dramatically slow down Map data layer rendering (Issue #5466)

### URL _No response_ ### How to reproduce the issue? I was trying to figure out why the Map Data layer is slow when displaying a lot of elements. In Firefox Profiler, I saw that a lot of time was spent on handlers for adding new objects to the map. https://github.com/user-attachments/assets/

Re: [openstreetmap/openstreetmap-website] "layeradd layerremove" event handlers dramatically slow down Map data layer rendering (Issue #5466)

> parse the response as json() This is not necessary yet. I have increased the limit of the maximum number of nodes for the local openstreetmap-cpimap, and I can say that parsing XML, which is 50 MB in decompressed form, only took 2 seconds. However, it took 10 seconds to download. -- Reply

Re: [openstreetmap/openstreetmap-website] "layeradd layerremove" event handlers dramatically slow down Map data layer rendering (Issue #5466)

What if we add a layer type check to the handler for which the handler was triggered? Something like: ```js map.on("moveend layeradd layerremove", function (e) { if (!L.TileLayer.prototype.isPrototypeOf(e?.layer)){ return } updateLinks( map.getCenter().wrap(), map.

Re: [openstreetmap/openstreetmap-website] "layeradd layerremove" event handlers dramatically slow down Map data layer rendering (Issue #5466)

This looks better, but will need to be fixed too. https://github.com/openstreetmap/openstreetmap-website/blob/95b919c5d1e33688b0841c7d38602372c2e4c4a3/app/assets/javascripts/leaflet.share.js#L272 And also understand how to track changes in the active object, which should be updated in the link o

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. ad9dcfe1f5fa59b88aaf2af1ce93a4d156ee4d9f Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/30403cb9307262871e7fa3044

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

Ah, I understand. I only tested changing the letters that represent the overlay (D/N/G). Changing the letters that respond to tile layers works now. PR broke it. I'll try to fix it -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. 12fee32c04e44aebca2ea778c48b6bf6270f9816 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/f10083a9c6263ff5b475e212b

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman pushed 1 commit. f10083a9c6263ff5b475e212ba4746e192e7b844 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/ad9dcfe1f5fa59b88aaf2af1c

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman commented on this pull request. > @@ -116,6 +116,7 @@ L.OSM.Map = L.Map.extend({ } else { this.removeLayer(this.baseLayers[i]); } + this.fire("baselayerchange", { layer: this.baseLayers[i] }); Implemented a check that there is already a layer on the map. B

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman commented on this pull request. > this.addLayer(this.baseLayers[i]); } else { +baselayerChanged = this.hasLayer(this.baseLayers[i]); So the next handler also violates this expectation? https://github.com/openstreetmap/openstreetmap-website/blob/b45eb03a6c026e

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

@deevroman commented on this pull request. > this.addLayer(this.baseLayers[i]); } else { +baselayerChanged = this.hasLayer(this.baseLayers[i]); It seems that `"baselayerchange overlaylayerchange"` will work in this place -- Reply to this email directly or view it on Gi

Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)

Okay, I added the `baselayerchange` firing. So, when changing D/N/G, the update does not work now, so firing `overlaylayerchange` is better done in a separate PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-

Re: [openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

@deevroman pushed 1 commit. b6cc806f76c46e5a416fd4de7314b531a60c7f16 Fix left/right sidebar resizing on mobile devices -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/898ea3d1bc17468e3cfef0e36b6127e9208e70c0..b6cc806f76c46e5a416fd4de7314b531a60c7f16

Re: [openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

deevroman left a comment (openstreetmap/openstreetmap-website#5521) Okay, it seems that this PR at least does not make it worse. The only regression I noticed was a noticeable shift of the map with the note marker when opening the left and right sidebars at the same time. But I think this is a

Re: [openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)

@deevroman pushed 1 commit. 8e1e1e47134b652bd1a5facba44280f05cc802fa Fix left/right sidebar resizing on mobile devices -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/b6cc806f76c46e5a416fd4de7314b531a60c7f16..8e1e1e47134b652bd1a5facba44280f05cc802fa

Re: [openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)

Added the URL. But I think I missed an important step in the text (there is one in the video). 1. Open https://openstreetmap.org/history 2. Select any changeset and then also close the tab, wait and restore the tab. If you open the changeset by URL, the tab is restored correctly. Probably the p

[openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)

### URL _No response_ ### How to reproduce the issue? https://github.com/user-attachments/assets/64f5513a-64e2-4658-aba0-0683c924a091"; /> 1. Open the changeset page for the view openstreetmap.org/changeset/X 2. Close the tab 3. Wait a few seconds 4. Restore the tab 5. Styles are not loade

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

deevroman left a comment (openstreetmap/openstreetmap-website#5009) This PR brought two problems: 1. When moving the map, a white flash occurs and all objects on the map are redrawn: https://github.com/user-attachments/assets/3c87c769-174c-4513-a5be-115eb9517bb8 2. Rendering slowed down. What

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

deevroman left a comment (openstreetmap/openstreetmap-website#5804) How about hiding pages `osm.org/user/username` from not registered users by default? And after that, you can add a setting of the visibility of the profile data. Yes there is more `osm.org/user/username/*`, but at least it will

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

deevroman left a comment (openstreetmap/openstreetmap-website#5009) > For CPU slowdown I use browser built-in functionality. Ah, chromium, got it. 20x slowdown is unrealistic. With this value, I can't move the map normally, even without the data layer. But even with 20x slowdown, the layer with

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

deevroman left a comment (openstreetmap/openstreetmap-website#5757) Previously, to separate changesets without comments, you used to change the brightness of the icon, not fill it. And before, it was the only icon with a fill that you could get used to. > just to you for some reason For what r

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

deevroman left a comment (openstreetmap/openstreetmap-website#5009) What do you use to test CPU slowdowns? Test rendering >4k features. Can you give us an example of when the user has time to notice the browser hanging, while making the user guess that they are waiting for rendering, and not do

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

deevroman left a comment (openstreetmap/openstreetmap-website#5009) @nertc no, https://github.com/openstreetmap/openstreetmap-website/pull/5799 disabled asynchrony not for the Map Data layer, but for the layer that shows the active object. -- Reply to this email directly or view it on GitHub:

Re: [openstreetmap/openstreetmap-website] Shorten matching wiki urls in linkify (PR #5855)

deevroman left a comment (openstreetmap/openstreetmap-website#5855) Do need to save /wiki? Wiki understands paths without /wiki and makes a redirect. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5855#issuecomment-2758382889 Yo