updates the editor layer index again, this time addressing
https://github.com/openstreetmap/iD/issues/10486
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5250
-- Commit Summary --
* Update to iD v2.30.4
-- File C
updates the editor layer index, adressing
https://github.com/openstreetmap/iD/issues/10483
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5248
-- Commit Summary --
* Update to iD v2.30.3
-- File Changes --
M
Small bugfix release, fixing flickering when switching background layers or
zooming (https://github.com/openstreetmap/iD/issues/10738).
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5623
-- Commit Summary --
* Upd
> after clicking "edit", iD editor opens without notes visible
FYI: With v2.31 (#5610), iD will load the notes layer if it was previously
enabled on the osm.org map (also when no individual note is selected).
Disabling the notes layer in the editor will however not disable it for the osm
map.
## changes to the osm-website code:
This version of iD introduces a new hash parameter to enable to _notes_ layer
on startup. For a seamless integration into the website, I have added a check
if the notes layer is currently active, and pass it forward to the iD iframe.
The implementation is cur
@tyrasd pushed 1 commit.
0b5fa06a39e1cd793e2c77116201c521aa02ec38 lint
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/051ae5953f18e2bcc4a4612e9851c95c0f86842e..0b5fa06a39e1cd793e2c77116201c521aa02ec38
You are receiving this because you are subscribe
The current version of iD (v2.31, before the fix for
https://github.com/openstreetmap/iD/issue/10761 :
https://github.com/openstreetmap/iD/pull/10766), does not fully support
`x-www-form-urlencoded` "query-style" strings in the hash:
Specifically, spaces encoded as `+` will not be decoded back
@tyrasd pushed 1 commit.
c025613ff6038439d3b5591aebee915f75999575 replace all occurrences of `+`
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/0b5fa06a39e1cd793e2c77116201c521aa02ec38..c025613ff6038439d3b5591aebee915f75999575
You are receiving this
> Also, wouldn't it be better to create an iD 2.31.2 patch for this
It would be possible to create a patch release for this but I would prefer to
only include this change in the next minor release version, as strictly
speaking this does change the
[API](https://github.com/openstreetmap/iD/blob/
@tyrasd commented on this pull request.
> @@ -33,5 +33,5 @@ $(document).ready(function () {
if (id.data("gpx")) params.set("gpx", id.data("gpx"));
- id.attr("src", id.data("url") + "#" + params);
+ id.attr("src", id.data("url") + "#" + params.toString().replace("+", "%20"));
I've fixed
When the `map` hash parameter is changed (and was not not triggered by map
interaction from inside iD itself): pan to the new location.
This mirrors the behaviour when manually editing the `map` hash parameter on
osm.org outside of iD.
This also fixes https://github.com/openstreetmap/iD/issues/
> using openstreetmap.org/id directly is not really supported
:+1: agree
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5394#issuecomment-2539710967
You are receiving this because you are subscribed to this thread.
Message ID:
Fix for #865. Unfortunately, the code is slightly different between OSM objects
(nodes/ways/relations), notes and changesets. I tried to make it somewhat more
coherent by always using the `map.addObject({}, callback)` approach to zoom to
the location if the `hash` parameters had no location info
Fixes #5683 (a regression in #5679): the problem was that when clicking on a
new note on the map, the URL hash with the `map` parameter is cleared somewhere
before `pushstate` gets called, resulting in the map to be panned in
`map.addObject` during the `initialize` step. It's now solved by pass
@tyrasd pushed 1 commit.
793757a6ff4a6ca3cb7ad5454fec1c51fe63804f don't pan map wen
closing/reopening/commenting a note, fixes #648
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5686/files/3a016a5f164ea40ebdc29cc6d3fdf799700172c2..793757a6ff4a6ca3cb7ad5454fe
tyrasd left a comment (openstreetmap/openstreetmap-website#5683)
sorry, this was an unintended side effect of #5679. working on a fix now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5683#issuecomment-2661343897
You are rece
@tyrasd commented on this pull request.
> @@ -36,4 +36,10 @@ $(function () {
if (idData.gpx) params.set("gpx", idData.gpx);
id.attr("src", idData.url + "#" + params);
+
+ id.ready(function () {
+if (!this.contentWindow.location.href.startsWith(idData.url)) {
I get a `Uncaught TypeE
release notes are available at
https://github.com/openstreetmap/iD/releases/tag/v2.33.0
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5912
-- Commit Summary --
* Update to iD v2.33.0
-- File Changes --
A .Ve
@tyrasd pushed 1 commit.
c48123ba70167817fd755622fd996ae7843ce5f5 Update to iD v2.33.0
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/7a9d2af0e09ea4eb2ac9a26b72ba7c6557b3a657..c48123ba70167817fd755622fd996ae7843ce5f5
You are receiving this because y
@tyrasd pushed 1 commit.
d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1 Update to iD v2.33.0
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/c48123ba70167817fd755622fd996ae7843ce5f5..d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1
You are receiving this because y
I get a `Uncaught TypeError: this.contentWindow is undefined` error every time
I regularly start an iD editing session. Is that expected? Would it not be
better to skip the check if everything is loaded correctly, maybe like this:
```js
if (this.contentWindow &&
!this.contentWindow.location.hre
tyrasd left a comment (openstreetmap/openstreetmap-website#5700)
Yeah, this seems good to me. Thanks @hlfan
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5700#issuecomment-2665645883
You are receiving this because you are subsc
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
closing in favour of #5700
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2665640851
You are receiving this because you are subscribed to this thr
Closed #5698.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5698#event-16347893361
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
tyrasd left a comment (openstreetmap/openstreetmap-website#5632)
> fix to uninitialized variables
yeah, but the previous version of the code used the _uninitialized_ state
explicitly to encode the case for when the `#map` parameter should explicitly
be absent in the url of the iD iframe. :wink:
@tyrasd pushed 1 commit.
e56340b3ea6024738d03af3c1647019584a09bc3 drop superfluous semicolon
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5698/files/1599c360b0517ac0f6d15d514e0afc7509983c66..e56340b3ea6024738d03af3c1647019584a09bc3
You are receiving this bec
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
ehrm…
Given that:
* `mapParams.center/.zoom` get the location via different means (either via the
URL's hash, `mlat/mlon` query parameters or the previously last visited
location that's stored in a cookie)
* iD will not auto-cent
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
> idData already has the coordinates
This one is also a bit confusing. Normally, `idData.lat/.lon` are not present.
If I see this correctly, `idData.lat/.lon` are only set when the editor is
loaded using a `…?note=xxx` link, see 6
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
> The map parameter would always be set.
not in the iframe's `src` parameter before 5310c5b :shrug:
> Why would you not want to use the coor
Release notes: https://github.com/openstreetmap/iD/releases/tag/v2.32.0
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5750
-- Commit Summary --
* Update to iD v2.32.0
-- File Changes --
M vendor/assets/iD/iD.
fixes https://github.com/openstreetmap/iD/issues/10779 (a regression introduced
in #5632)
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5698
-- Commit Summary --
* don't set map coords if mapParams contains object
tyrasd left a comment (openstreetmap/openstreetmap-website#5632)
FYI, this added a small bug, see
https://github.com/openstreetmap/iD/issues/10779 / #5698
I really appreciate the cleanup efforts of the iD integration code. :+1:
Nevertheless, it would have been nice to tag me in this (and the o
@tyrasd pushed 1 commit.
82c33d461469fd1fe129edba135414b9e11edffc Update to iD v2.34.0
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6008/files/5e3d6ef224c76e17b736555903ec23c906da6c24..82c33d461469fd1fe129edba135414b9e11edffc
You are receiving this because y
Upstream changelog: https://github.com/openstreetmap/iD/releases/tag/v2.34.0
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6008
-- Commit Summary --
* Update to iD v2.34.0
-- File Changes --
A package-lock.js
34 matches
Mail list logo
