[openstreetmap/openstreetmap-website] Gateway time-out when opening a long relation history (Issue #5282)

2024-10-23 Thread Máté Gyöngyösi via rails-dev
### URL https://www.openstreetmap.org/relation/7795942/history ### How to reproduce the issue? 1. Open the URL 2. See the following error: https://github.com/user-attachments/assets/2f5c66a8-8966-4b5c-b214-37daa0a2ccc1";> ### Screenshot(s) or anything else? This relation is enormous: it ha

Re: [openstreetmap/openstreetmap-website] Edit with Remote Control blocked in Safari (#2445)

2025-01-12 Thread Máté Gyöngyösi via rails-dev
> Safari still has a bug, but it will be fixed soon hopefully: > > https://bugs.webkit.org/show_bug.cgi?id=171934 IIUC Apple [doesn't want to remove this block](https://bugs.webkit.org/show_bug.cgi?id=171934#c96) due to security reasons until the [Private Network Access specification](https://

Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)

2025-05-02 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#2799) _Relevant Apple guideline: https://developer.apple.com/app-store/review/guidelines/#login-services_ _Related GitHub issue comment: https://github.com/openstreetmap/openstreetmap-website/issues/3476#issuecomment-2668670924_ -- R

Re: [openstreetmap/openstreetmap-website] Add optional two-factor authentication for user accounts (Issue #3476)

2025-02-19 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#3476) I'd recommend using passkeys instead of TOTP: https://www.w3.org/TR/webauthn-3/ They are much easier to use and are already supported by Chrome and Safari. -- Reply to this email directly or view it on GitHub: https://github.com/o

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. 976f0616d699fcd8632723a751aa26cca51d2f17 Correct link_to() destination parameter -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/f892c072040601ee3b0d38b65fd2f68378fa997a..976f0616d699fcd8632723a751aa26cca51d2f17 You are rec

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) I'm sorry for the merge commits—I'll pay attention to this next time! 🤞 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2693018101 You are receivi

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) > There was a previous attempt #4134. It had the advantage of NOT adding link > to the time, in case clicking the time is supposed to do something else like > #4361. @AntonKhorev You're right—I've tried to go this way. Does it se

[openstreetmap/openstreetmap-website] Remove obsolete element from docker-compose.yml (PR #5743)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
### Description The 'version' top-level Docker Compose element is deprecated since April 2024: https://github.com/docker/docs/commit/007ac90154c05f34045f607631b93a95c81d4807#diff-948ba582fe1c0dd6e8a5446ed8d8831e8ff65d0df7552f0eaa22b9ff7945b3e3R7 ### How has this been tested? On my Mac using th

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. 56c38f7466728951ca021e83c90340fe29e9e997 Add button instead of hyperlinking time_ago -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/976f0616d699fcd8632723a751aa26cca51d2f17..56c38f7466728951ca021e83c90340fe29e9e997 You are

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-03 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. 2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab Add button instead of hyperlinking time_ago -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/56c38f7466728951ca021e83c90340fe29e9e997..2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab You are

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-03 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) @tomhughes This seemed too complicated for me but I've cut the Gordian knot by basically squashing all commits into one and rebasing it on top of the master. Is it okay this way? -- Reply to this email directly or view it on Git

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
@gy-mate commented on this pull request. > @@ -53,6 +53,9 @@ :url => api_changeset_comment_visibility_path(comment) } %> <% end %> + + I've moved the `rotate()` function inside the `` tag in `sprite.svg`.

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. c952d6c872e88f91b13f85437589f08cdaece396 Rotate comment link icon by –45 degrees -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/4d8d61a095e936fce4195359466f1cc842af76c0..c952d6c872e88f91b13f85437589f08cdaece396 You are rec

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) > But if the link icon isn't used from the sprite (when directly used) then it > should be removed from there. I think it's better for performance if we keep it in the sprite. -- Reply to this email directly or view it on GitHub

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) > A lot of sites (eg github markdown rendering) also only show it when your > mouse is over the item in question. If someone can do this, sure! But until then, I think that the addition of a link icon in this form (if I've done i

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) > That certainly looks better I think. @tomhughes Done! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2698968963 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) > Maybe on a 45 degree angle as well? @tomhughes Also done! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2698973382 You are receiving this bec

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) @tomhughes Sure, done! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2699153237 You are receiving this because you are subscribed to this thread

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) > Do we actually use that icon anywhere else at the moment? The regex search `\Wicon link` on the whole codebase yields only this result. So I don't think so. > It seems very bold to me @tomhughes Shall I change https://github.

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-05 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. b53211946408198f54fa40d8fa059a9627159666 Add permalink button to changeset comments -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/09b801f9820f4f46c758b2743944701bc1696cab..b53211946408198f54fa40d8fa059a9627159666 You are

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-05 Thread Máté Gyöngyösi via rails-dev
@gy-mate commented on this pull request. > + + + Done! @AntonKhorev Thanks a lot for the suggestion! :) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#discussion_r1981141623 Yo

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-05 Thread Máté Gyöngyösi via rails-dev
@gy-mate commented on this pull request. > @@ -26,8 +26,9 @@ - - + > actually I wouldn't put it in sprite.svg. Then the whole sprite would need a restructuring, I think. If you'd like to do so, I'll accept your code suggestion right away! -- Reply to this email directl

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-05 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. a9752be6b39c3228f55ef0cb085e50224675aa0e Add permalink button to changeset comments -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/b53211946408198f54fa40d8fa059a9627159666..a9752be6b39c3228f55ef0cb085e50224675aa0e You are

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-05 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) Great, thanks! :) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2701276879 You are receiving this because you are subscribed to this thread. Me

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-05 Thread Máté Gyöngyösi via rails-dev
@gy-mate commented on this pull request. > + + + Thanks! :) @tomhughes Would this be okay for you? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#discussion_r1981026831 You are

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. 756ebcf071c411a50dc0156e0082779d8f639e71 Replace link icon with a better version -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab..756ebcf071c411a50dc0156e0082779d8f639e71 You are rec

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-04 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. 4d8d61a095e936fce4195359466f1cc842af76c0 Rotate comment link icon by –45 degrees -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/756ebcf071c411a50dc0156e0082779d8f639e71..4d8d61a095e936fce4195359466f1cc842af76c0 You are rec

Re: [openstreetmap/openstreetmap-website] Map doesn't zoom to Note if URL contains comment ID (Issue #5596)

2025-06-14 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#5596) I couldn't reproduce the issue anymore. @BathoryPeter, can you also confirm that this is fixed? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5596#issuecomment

Re: [openstreetmap/openstreetmap-website] Including the smooth-zoom of the Qwant-map (#2283)

2025-07-22 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#2283) > is not in any way relevant or useful to us right now. > > As and when we are ready and able to move to vector tiles it might be We now have not one but two kinds of vector tiles, hooray!! 🎉 It looks like this issue became relev

Re: [openstreetmap/openstreetmap-website] Including the smooth-zoom of the Qwant-map (#2283)

2025-07-22 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#2283) _Related: #5481_ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2283#issuecomment-3104884135 You are receiving this because you are subscribed to this thread. M

Re: [openstreetmap/openstreetmap-website] Including the smooth-zoom of the Qwant-map (#2283)

2025-07-22 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#2283) My bad—thanks for the info! :) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2283#issuecomment-3104903749 You are receiving this because you are subscribed to t