andrewharvey left a comment (openstreetmap/openstreetmap-website#5780)
> There is a difference with changing how things that are already detected as
> links look and the rest. You don't expect "I added a note 5 years ago" to
> link to note https://github.com/openstreetmap/openstreetmap-website/p
@hlfan pushed 1 commit.
7419d9ff134c2ce4487b4fac70f1346cb825c3f2 Consolidate leaflet marker creation
in OSM.getMarker
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5860/files/59a6502072760d26b850303e983a4ad61f3c904b..7419d9ff134c2ce4487b4fac70f1346cb825c3f2
@hlfan pushed 1 commit.
59a6502072760d26b850303e983a4ad61f3c904b Make marker height a parameter
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5860/files/3f5fb9a200ff0e5e87b4fd38c800bf3a78bc62c7..59a6502072760d26b850303e983a4ad61f3c904b
You are receiving this
@hlfan pushed 1 commit.
0314155471019d6c16a4ad0e3043d41e7ee58e39 Keep rich text copyable
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861/files/e833913b09a53cd55c16eb8cf55d3f269e5b7b8a..0314155471019d6c16a4ad0e3043d41e7ee58e39
You are receiving this because
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5780)
> Should probably included n
> https://github.com/openstreetmap/openstreetmap-website/pull/5858
https://github.com/openstreetmap/openstreetmap-website/pull/5858 has nothing to
do with picking up links without https://
--
Re
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
> > are not working anymore?
>
> Do you want to say they used to work? That text like `osm.org/node/1/history`
> used to be linkified?
When the plain text is copied from shortened links, the protocol is missing, so
it doesn't get
hlfan left a comment (openstreetmap/openstreetmap-website#5861)
Copying and pasting shortened osm.org links makes the pasted links not getting
linkified, as the current regex requires a protocol that is missing in the
copied shortened links.
--
Reply to this email directly or view it on GitHu
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
Also previously when the whole url was displayed it could be copied and pasted
and it would be linkified again.
Now linkify strips the protocol, which makes it ignore the links on the "second
pass" after copying and pasting the text
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5780)
> are not working anymore?
Do you want to say they used to work? That text like `osm.org/node/1/history`
used to be linkified?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5861)
> breaking links
Which links are being broken?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861#issuecomment-2761638364
You are receiving this because you
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5861)
> fails
Fails at what?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861#issuecomment-2761633241
You are receiving this because you are subscribed to this t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5861)
Can you write a test case that fails without your fix and passes with it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861#issuecomment-2761744783
You are r
matkoniecz left a comment (openstreetmap/openstreetmap-website#5780)
> Do you want to say they used to work? That text like osm.org/node/1/history
> used to be linkified?
no, but when I put link to node/changeset/wiki and copy-pasted it - then it was
still working
now link is shortened and sho
@hlfan commented on this pull request.
> -iconAnchor: [12, 41],
-popupAnchor: [1, -34],
-shadowUrl: OSM.MARKER_SHADOW,
-shadowSize: [41, 41]
- });
+OSM.getMarker = function ({ icon = "MARKER_RED", shadow = true }) {
+ const height = icon.includes("NOTE") ? 40 : 41;
+ const opt
@hlfan commented on this pull request.
> @@ -391,13 +391,17 @@ OSM.isDarkMap = function () {
return window.matchMedia("(prefers-color-scheme: dark)").matches;
};
-OSM.getUserIcon = function (url) {
- return L.icon({
-iconUrl: url || OSM.MARKER_RED,
-iconSize: [25, 41],
-iconAn
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861#pullrequestreview-2724721311
You are receiving this because you are subscribed to this thread.
Message ID:
__
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5852)
> Looks food to me, thanks.
you can use "saved replies" here at github...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5852#issuecomment-2760410126
You ar
matkoniecz left a comment (openstreetmap/openstreetmap-website#5780)
https://wiki.openstreetmap.org/wiki/Tag:shop%3Dappliance and
https://www.openstreetmap.org/node/1/history now get shortened to
[osm.wiki/wiki/Tag:shop%3Dappliance](https://wiki.openstreetmap.org/wiki/Tag:shop%3Dappliance)
and
matkoniecz left a comment (openstreetmap/openstreetmap-website#5780)
> Edit: Or do you mean that the same string will be not linkified when
> "cloning" the text?
yes, exactly
it is quite confusing when copy pasting breaks links
--
Reply to this email directly or view it on GitHub:
https://git
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5780)
> Also Github has a _quote reply_ feature where I can just unquote the text to
> get the original. OSM doesn't.
We don't have blockquotes (or any other markdown/html syntax) in changeset
comments. That's why I'm not sure if a
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5780)
I see @matkoniecz tried to copy his own comment:
https://www.openstreetmap.org/changeset/18433183
https://www.openstreetmap.org/changeset/105914132 Yes, that's currently going
to fail. But there's another possible solution fo
Removes the check for removed protocol that fails when copy-pasting links. See
https://github.com/openstreetmap/openstreetmap-website/issues/5780#issuecomment-2760445765
for details.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-
OSM.getUserIcon() was used for much more than just the icons on the user page.
I've made it work with the icon paths already stored in the OSM object and
made it compatible with the note icons to eliminate the `noteIcons` objects.
I previously included this in #5854, but I think it makes more sen
Closed #5832.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#event-17027531790
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5780)
both are working here
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5780#issuecomment-2760421869
You are receiving this because you are subscribed to
@hlfan pushed 1 commit.
e833913b09a53cd55c16eb8cf55d3f269e5b7b8a Fix copy-pasting breaking links in
shorten_host
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861/files/8bea492e2358929180e7808e9cd916a5a9625533..e833913b09a53cd55c16eb8cf55d3f269e5b7b8a
You a
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5829)
- [ ] hide activity and *make my edits more difficult to review*, edits that
are not in some private repository and weren't reviewed before being merged
with the rest of the data
--
Reply to this email directly or view it o
1ec5 left a comment (openstreetmap/openstreetmap-website#5780)
Longer comments are more likely to prompt respondents to quote individual
passages. In changeset and note discussions, this is usually a sign that the
discussion should move outside the confines of the sidebar, to either direct
mess
matkoniecz left a comment (openstreetmap/openstreetmap-website#5780)
> The easy fix is to not strip the http/https, but that makes link texts longer.
I think it would be worth it (at least for me)
> There's also a possible fix purely for copypasting.
So https:// would be added on copying?
> Th
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5780)
Might have to do this sooner than I expected:
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
hlfan left a comment (openstreetmap/openstreetmap-website#5861)
Sure, I'll see what I can do
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861#issuecomment-2761908459
You are receiving this because you are subscribed to this th
@tomhughes requested changes on this pull request.
Other than the one minor suggestion I made this looks great to me.
> @@ -578,7 +578,7 @@ en:
use_map_link: Use Map
index:
title: "Users' Diaries"
- title_followed: "Followings' Diaries"
+ title_followed: "Your Followe
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
Also Github has a _quote reply_ feature where I can just unquote the text to
get the original.
OSM doesn't.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5780#i
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5862)
I tried to do a similar thing back in #4189 and it wasn't merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5862#issuecomment-2762081953
You are receiving
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5780)
@matkoniecz how often do you copy comments into other comments and how
important is it for the links to still be present in the copied comments?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstr
tomhughes left a comment (openstreetmap/openstreetmap-website#5858)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5858#issuecomment-2761930585
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
> @@ -391,13 +391,17 @@ OSM.isDarkMap = function () {
return window.matchMedia("(prefers-color-scheme: dark)").matches;
};
-OSM.getUserIcon = function (url) {
- return L.icon({
-iconUrl: url || OSM.MARKER_RED,
-iconSize: [25, 41],
-ic
Merged #5858 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5858#event-17035955378
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Rather than adding an ever larger list of configuration options for link
normalisation this uses a single option that provides an array of rules to
apply.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5862
-- Commit
matkoniecz left a comment (openstreetmap/openstreetmap-website#5780)
> @matkoniecz how often do you copy comments into other comments and how
> important is it for the links to still be present in the copied comments?
very often, but I know that I am a clear outlier in how often I make changeset
1ec5 left a comment (openstreetmap/openstreetmap-website#5780)
That reminds me of another detail about GitHub’s pretty-printing: if you copy
the pretty-printed text, some rich text formatting get paired with it, so that
pasting the text will result in a working link in any rich text editor or
M
41 matches
Mail list logo
