@hlfan pushed 3 commits.
cd1a05af94e88053c24f56404bd03418d2568bc0 Set fixthemap note link in template
0fca1716574a7a5044709527a43d9a5addd8b914 Click links instead of icons in tests
d043a08822d57501e959c8fabae6fcdcd90d1b34 Remove controls sprite
--
View it on GitHub:
https://github.com/openstr
@kcne pushed 2 commits.
363e18165322b926ab5979ebdb0a1f6f8318b980 Add index on gpx_files.user_id and
timestamp
e57e5fc0cd34dfa318028b16cfe86726fba3385a Add index on notes.user_id and
created_at
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5747/files/1f91bd
@hlfan commented on this pull request.
> @@ -80,6 +80,11 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replace(":", "=")
> Are you going to look at anything past the firs
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4789)
What should happen when the link icon is clicked?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2700314674
You are receiving this because yo
@AntonKhorev pushed 3 commits.
f648099c9f0110ebcfc78739185839d44dbc7f69 Update comments icon
c5d653271072183869c173a821fa95e5df26c971 Add comments icon
7268f92654678510a46bec4c1d00ed062da2ff1e Add title texts to changeset list
comments/changes
--
View it on GitHub:
https://github.com/openstr
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4789)
> A lot of sites (eg github markdown rendering) also only show it when your
> mouse is over the item in question.
Bootstrap has this effect in their [docs](https://getbootstrap.com/docs/5.3/),
but not in the library itself. I
dark:
rtl:
You can view, c
@gy-mate pushed 1 commit.
b53211946408198f54fa40d8fa059a9627159666 Add permalink button to changeset
comments
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/09b801f9820f4f46c758b2743944701bc1696cab..b53211946408198f54fa40d8fa059a9627159666
You are
@gy-mate commented on this pull request.
>
+
+
+
Done!
@AntonKhorev Thanks a lot for the suggestion! :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#discussion_r1981141623
Yo
@tomhughes commented on this pull request.
>
+
+
+
Sure
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#discussion_r1981125861
You are receiving this because you are subscribed t
nertc left a comment (openstreetmap/openstreetmap-website#5302)
@tomhughes Thanks for the review. PR was updated accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2700150865
You are receiving this beca
@gy-mate commented on this pull request.
> @@ -26,8 +26,9 @@
-
-
+
> actually I wouldn't put it in sprite.svg.
Then the whole sprite would need a restructuring, I think. If you'd like to do
so, I'll accept your code suggestion right away!
--
Reply to this email directl
Release notes: https://github.com/openstreetmap/iD/releases/tag/v2.32.0
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5750
-- Commit Summary --
* Update to iD v2.32.0
-- File Changes --
M vendor/assets/iD/iD.
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5750)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
tomhughes left a comment (openstreetmap/openstreetmap-website#5744)
I've made one more small change to the note model `test_author` method to
actually the author method on notes and I think this is good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
@tomhughes pushed 1 commit.
cc6bfb2c7c4ee671e96f92a17b34583ee904afbd Removes first comment body from notes
tests
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5744/files/7a9b7524d2196ff63543729e9c75ad1a5f737ecb..cc6bfb2c7c4ee671e96f92a17b34583ee904afbd
You a
tomhughes left a comment (openstreetmap/openstreetmap-website#5744)
Found another problem in `test/models/issue_test.rb` that needed tweaking so I
added that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2701
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5309)
Changed to a singular resource in order to have `destroy` action, was using
nonstandard `delete` action on a collection before.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
Closed #2796 as completed via #4789.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2796#event-16604613971
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5749 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5749#event-16604613716
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5750 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5750#event-16604613698
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #4789 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#event-16604613696
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
7a9b7524d2196ff63543729e9c75ad1a5f737ecb Removes first comment body from notes
tests
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5744/files/4139ad1f5e87c2c9ec4d79237486d6a2c4a17c15..7a9b7524d2196ff63543729e9c75ad1a5f737ecb
You a
@AntonKhorev commented on this pull request.
>
+
+
+
Here's what I'd do:
```suggestion
```
This is [the rotated icon](https://icons.getbootstrap.com
A simpler version of #4616 and #5024 where I don't try to combine feature
queries with map key.
I just rename the former browse controller to `FeatureQueries` as suggested in
https://github.com/openstreetmap/openstreetmap-website/pull/5024#issuecomment-2253146205.
You can view, comment on, or me
@tomhughes approved this pull request.
This looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2662015139
You are receiving this because you are subscribed to this thread.
Messa
tomhughes left a comment (openstreetmap/openstreetmap-website#5749)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5749#issuecomment-2701736351
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5751)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5751#issuecomment-2701835189
You are receiving this because you are subscribed to this t
Merged #5744 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5744#event-16605065771
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5751 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5751#event-16605065795
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@gy-mate pushed 1 commit.
a9752be6b39c3228f55ef0cb085e50224675aa0e Add permalink button to changeset
comments
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/b53211946408198f54fa40d8fa059a9627159666..a9752be6b39c3228f55ef0cb085e50224675aa0e
You are
@AntonKhorev pushed 1 commit.
cf80eb50f3aa0f20052aa35768ef411907950533 Prevent changeset comment links from
reloading the page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/a9752be6b39c3228f55ef0cb085e50224675aa0e..cf80eb50f3aa0f20052aa35768ef4119
@AntonKhorev approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2661468548
You are receiving this because you are subscribed to this thread.
Message ID:
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4789)
I pushed here a change to our link click listener that stops comment links from
reloading the page.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuec
gy-mate left a comment (openstreetmap/openstreetmap-website#4789)
Great, thanks! :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2701276879
You are receiving this because you are subscribed to this thread.
Me
@AntonKhorev pushed 1 commit.
930a8d7ac3ba8f9a5d29921f220b87e533c50252 Support unwrapped bbox values in
changeset history queries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473/files/5374ebd497ce7d26e79c44f44cb90a8d2b066992..930a8d7ac3ba8f9a5d29921f220b8
@AntonKhorev pushed 12 commits.
e184bdf70c581462e9f06f85b2fc6a933b782aea Add blank page for managing changeset
tags
52e11c0c151f2d2502d94a671cf55604249a8f27 Add 'not found' page for managing
changeset tags
0a927c498d2d8ab707a9322a406aca08c09cc2ae Add changeset link to changeset tags
page
d87
@nertc commented on this pull request.
> @@ -148,7 +148,11 @@ def search_osm_nominatim_reverse
:type => object_type, :id => object_id)
end
-render :action => "results"
+if params[:format] == "json"
+ render :json => @results
+else
+ render :actio
@AntonKhorev commented on this pull request.
> @@ -26,8 +26,9 @@
-
-
+
You don't need to rotate it manually because Bootstrap Icons already has the
rotated version
https://icons.getbootstrap.com/icons/link-45deg/
--
Reply to this email directly or view it on GitHub:
htt
@gy-mate commented on this pull request.
>
+
+
+
Thanks! :)
@tomhughes Would this be okay for you?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#discussion_r1981026831
You are
@nertc commented on this pull request.
> + return;
+}
+
+const geocodeUrl = "/geocoder/search_osm_nominatim_reverse";
+const params = {
+ format: "json",
+ lat,
+ lon,
+ zoom: 3
+};
+
+if (locationInput.request) {
+ locationInput.request.abort();
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2661720002
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2661727159
You are receiving this because you are subscribed to this thread.
Message ID:
__
@AntonKhorev pushed 12 commits.
8cce21cfd7a363c31c351e78e6ffc931784d9c96 Add blank page for managing changeset
tags
3d52fa21e207129519ca6dc2660f0be32cdd4d1c Add 'not found' page for managing
changeset tags
74b1560099d9ccd428d3e0c9d62e63c806ff39fd Add changeset link to changeset tags
page
6bd
@tomhughes requested changes on this pull request.
> @@ -22,7 +22,15 @@
<%= t "site.welcome.add_a_note.title" %>
<%= t "site.welcome.add_a_note.para_1" %>
-<%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon =>
tag.a(:class => "icon note bg-dark rounded-1") %>
+
Put the sprite icons into HTML with JS or Ruby.
Due to the nature of the leaflet locate plugin, that icon is done with a clip
path.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5752
-- Commit Summary --
* Unify a
hlfan left a comment (openstreetmap/openstreetmap-website#5752)
Coveralls is 504-ing again... #5670
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#issuecomment-2701984967
You are receiving this because you are subscribed to
47 matches
Mail list logo
