When you select *My Preferences* from the user dropdown, you get to
`/preferences`, which is a page that shows you your preferences but doesn't
let you edit them. If you want to edit, you'll have to make one extra click
on the *Edit Preferences* button. See
https://github.com/openstreetmap/open
This depends on #5446 being merged first.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5447#issuecomment-2564811318
You are receiving this because you are subscribed to this thread.
Message ID:
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5447#issuecomment-2564813578
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5447 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5447#event-15780514529
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5442 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5442#event-15780514527
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5431 as completed via #5447.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5431#event-15780514566
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5446 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5446#event-15780514534
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #1191 as completed via #5442.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1191#event-15780514565
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5435 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5435#event-15780514536
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5448#issuecomment-2564816357
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5448 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5448#event-15780527522
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
> You can remove `%{doesnt}` form `off_the_map_html`
It's impossible not to use it, becasue Translatewiki software requires its use.
> or replace it with empty string
If the string is empty, the full English translation will show up.
--
Reply to this email directly or view it on GitHub:
https:
The page you changed the translations of has been redesigned in #5447, which
has already been merged. What would you like a review for?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5445#issuecomment-2565078388
You are receiving
> I've updated the code to account for the "Preferred Website Color Scheme."
> Theme settings should now be working correctly.
It's not going to work correctly because our *Auto* option follows
`prefers-color-scheme` which can change any time. If it does, you'll get for
example this:
 The page’s settings would block
> an inline style (style-src-attr) from being applied
--
Rep
> Separate JS Files: There's already a heatmap.js file containing
> heatmap-related functionality, included in application.js for precompilation.
How is it included in `application.js` if you're including `heatmap.js`
[here](https://github.com/openstreetmap/openstreetmap-website/pull/5402/files#
I mean it's not really clear why `save_new_user` exists when it's only called
once but I guess this fine.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5446#issuecomment-2564812572
You are receiving this because you are subscrib
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5442#issuecomment-2564810049
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes commented on this pull request.
The idea is fine but I think we should probably keep the `edit` action and get
rid of the `show` action instead of moving edit to show? That's how the
settings page works...
--
Reply to this email directly or view it on GitHub:
https://github.com/op
> When you select *My Preferences* from the user dropdown, you get to
> `/preferences`, which is a page that shows you your preferences but doesn't
> let you edit them. If you want to edit, you'll have to make one extra click
> on the *Edit Preferences* button. See
> https://github.com/openstre
> You'd have to then setup a listener like
> [this](https://github.com/openstreetmap/openstreetmap-website/pull/4777/commits/e35141b2d1c1733d9a15a01c08b796e4edda6b4e#diff-4fe14e869cf17b068e1bea009a55b094fed13f0cad85337cf4769f32b40a01b5R11-R13)
> but without using Leaflet of course and redraw the
21 matches
Mail list logo
