Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-23 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 46f7da62f4bad5b672fb9193644a64c1c8c72083 Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/471cbf6462bf835a1a3e35dbd72862d4a6e75b3c..46f7da62f4bad5b672fb9193644a64c1c8c72083 You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] Resourceful routes for received/issued blocks (PR #5440)

2024-12-23 Thread github-actions[bot] via rails-dev
1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Generated by :no_entry_sign: https://danger.systems/";>Danger -- Reply to this e

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-23 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 55c89e6cc0cf41327059dff1ddf1b8116d4580e6 Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/46f7da62f4bad5b672fb9193644a64c1c8c72083..55c89e6cc0cf41327059dff1ddf1b8116d4580e6 You are receiving this becaus

[openstreetmap/openstreetmap-website] Resourceful routes for received/issued blocks (PR #5440)

2024-12-23 Thread Anton Khorev via rails-dev
This creates `:issued_blocks` and `:received_blocks` resources for users. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5440 -- Commit Summary -- * Test active nav tabs on blocks_on/by pages * Declare new block p

Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

2024-12-23 Thread David Tsiklauri via rails-dev
> > It will make Reporter Users cells too high which will cause additional > > whitespaces in other cells. > > Is that additional whitespace going to be a problem? Sorry for the late answer. I think it will be a problem in terms of UI and UX: UI - visually, additional whitespaces in the table ma

Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)

2024-12-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > + if accumulated_length >= max_length +node.remove unless !last_child.nil? && last_child.ancestors.include?(node) +next + end + + next unless node.children.empty? + + accumulated_length += node.text? ? node.text.length

[openstreetmap/openstreetmap-website] Profile Page Redesign (Issue #5438)

2024-12-23 Thread David Tsiklauri via rails-dev
### Problem There are issues and PRs opened about adding new features and designs to the profile page. On the one hand, to maintain easier management over them and, on the other hand, to see and discuss whole picture and long-run results this page should achieve, it will be great if there is an

[openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-23 Thread David Tsiklauri via rails-dev
This PR addresses "Please make contact information fields, how to contact the user, email address, telegrams, various social networks https://www.openstreetmap.org"; issue mentioned in the https://github.com/openstreetmap/openstreetmap-website/issues/2245 ### Description This PR adds: - DB: Soc

Re: [openstreetmap/openstreetmap-website] Remove check_api_readable from api messages controller (PR #5435)

2024-12-23 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5435#issuecomment-2559387263 You are receiving this because you are subscribed to this thread. Message ID: ___