> The only downside of the current solution is that there will be only those
languages shown, which have shared.language_selector.language key.
Those that have translations that are maintained, so not much of a downside.
I also had a more defensive version of that key with `language: THIS LANGU
Merged #5307 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5307#event-15205327927
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
This looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5307#issuecomment-2464005215
You are receiving this because you are subscribed to this thread.
Message ID:
This looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5304#issuecomment-2464005082
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #5304 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5304#event-15205327938
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5305 as completed via #5307.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5305#event-15205328669
You are receiving this because you are subscribed to this thread.
Message ID:
_
Part 3 of #5283. Start using the subscriptions table to send notifications.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5310
-- Commit Summary --
* Send notifications to note subscribers instead of commenters
--
Richtext preview loading animation was added in
https://github.com/openstreetmap/openstreetmap-website/commit/eb789dbf757e760e8348e0aa75343eb53996b7e3
but later probably got broken. Its `loading` css class was removed in
https://github.com/openstreetmap/openstreetmap-website/commit/df1ec6b6809b5
@tomhughes Thank you for the comment. I agree with you about the complexity of
the code, but there are several reasons for both methods.
Changing location name manually solves cases like:
1. Disputed areas - someone living in the area A may not want to show that area
is part of country B and no
@AntonKhorev pushed 4 commits.
23479067254696a9a59f89deeff93e22e0f3e661 Send notifications to note
subscribers instead of commenters
f846217851f753854aa8657dca00c52a24438e78 Add create note subscription api
endpoint
7893326aa7a386f521da40e18ba9dc15b8b1fccc Add destroy note subscription api
e
@AntonKhorev commented on this pull request.
> @@ -6,6 +6,20 @@
:commented => tag.span(t(".subheading_commented"), :class => "px-2
py-1 bg-body") %>
<% end %>
+<%= form_with :url => url_for(:controller => "notes", :action => "index"),
:method => :get, :data => { :turbo => true }
@AntonKhorev commented on this pull request.
> @@ -6,6 +6,20 @@
:commented => tag.span(t(".subheading_commented"), :class => "px-2
py-1 bg-body") %>
<% end %>
+<%= form_with :url => url_for(:controller => "notes", :action => "index"),
:method => :get, :data => { :turbo => true }
12 matches
Mail list logo
