### URL
_No response_
### How to reproduce the issue?
Minor visual bug
1. Use Query features button at any location.
2. Click somewhere, then quickly click somewhere else while loading search
results for the first query.
3. First circular area highlight loads, then fades away. Second circular
@AntonKhorev commented on this pull request.
> @@ -34,6 +34,16 @@ class Note < ApplicationRecord
scope :visible, -> { where.not(:status => "hidden") }
scope :invisible, -> { where(:status => "hidden") }
+ scope :with_status, lambda { |status|
+case status
+when "open"
+ whe
@nenad-vujicic approved this pull request.
This works perfectly on my side. I tested it by applying patches on my personal
fork, forking my personal fork from another account and creating 2 PRs (one
with 20 commits - worked perfectly, one with changed only Gemfile - worked
perfectly again by ge
@nertc approved this pull request.
Tested and works perfectly. Every occurrence of "shared/pagination" has its own
pair on top of the page.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5262#pullrequestreview-2418102474
You a
@AntonKhorev pushed 5 commits.
e1d3074c9a79200123a6247a0f04b0239baf07aa Backfill note subscriptions
199ad4b25c846f13345194927c258cd575be5099 Send notifications to note
subscribers instead of commenters
2306e810f072d20afc5ec05d9ea8ea1c955f2a12 Add create note subscription api
endpoint
d7e67336
@AntonKhorev pushed 1 commit.
b8247478f4f772df8d09a29f3acd383fc6d32cf0 Use resourceful routes for
granting/revoking user roles
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5293/files/b24d52d5ca30e081ec799880bee6bc32616ad8fa..b8247478f4f772df8d09a29f3acd383f
@AntonKhorev commented on this pull request.
> + def update
@user.roles.create(:role => @role, :granter => current_user)
The routing system requires some convincing to achieve that. The less ugly
version I could come up with is singular resources for roles, despite there are
multiple po
@AntonKhorev approved this pull request.
It's fine if we're ok with mastodonshare.com for now, but we can replace it
later.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2418102922
You are receiving thi
Part two of #5283.
Creates a subscription for every note commented by a non-anonymous user. Does
this by:
- iterating through batches of note comments
- getting distinct non-null (user, note) pairs
- inserting these pairs using `upsert_all`, this skips already existing pairs
You can view, commen
@kcne pushed 1 commit.
b56dc10cec6239c067cca43f38176627f51887a5 Add status filter to user's note page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5297/files/337d37e71d1070ffe729ab6b7c6d877dc7cce203..b56dc10cec6239c067cca43f38176627f51887a5
You are receiving
@kcne commented on this pull request.
> @@ -34,6 +34,16 @@ class Note < ApplicationRecord
scope :visible, -> { where.not(:status => "hidden") }
scope :invisible, -> { where(:status => "hidden") }
+ scope :with_status, lambda { |status|
+case status
+when "open"
+ where(:sta
@kcne pushed 1 commit.
5b87c908f21977ec6908858b4f60b9a80d51e14d Add status filter to user's note page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5297/files/0d0045ea6753ca3e830d03ec81a8640f0fa942e6..5b87c908f21977ec6908858b4f60b9a80d51e14d
You are receiving
### Problem
With client side layers proposed as featured layers, we need to figure out how
to serve the styles to the client.
### Description
We have a couple of proposed featured layers that are Maplibre GL styles. These
styles consist of a style json, spritesheet, and fonts. The MapLibre sty
13 matches
Mail list logo
