I can't validate the assumption in production and don't know what test cases to
add. Or in other words, I was stuck with the current state and decided to close
it, as there's no way to make any progress on it.
Assuming a slab is full and new entries need to be added. There are two
possible opti
@kcne pushed 1 commit.
8ba2316df11bc0de908f589c4ff78a0337726531 Add social sharing functionality
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985/files/4efc63d6090eef1bb334fa7b58c123cf4d80577b..8ba2316df11bc0de908f589c4ff78a0337726531
You are receiving this
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line if con
@nertc pushed 1 commit.
25fd157b9ce6e7945bf5d5e9871d04388e9e5f19 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/80708ff796458168ebb1060bcb16e07ecf2e6fb5..25fd157b9ce6e7945bf5d5e9871d04388e9e5f19
You are receiving this because you
This PR was updated according to the suggestion of @AntonKhorev.
As described in the `CONTRIBUTING.md` only updated language config was `en`:
> ## i18n
>
> If you make a change that involve the locale files (in `config/locales`) then
> please only submit changes to the `en.yml` file. The other fi
After a bit of research on some libraries that offer such functionalities and
implementation details that we could potentially use for this:
### 1. [notifications-rails](https://github.com/jonhue/notifications-rails)
`notifications-rails` provides a modular structure for creating, rendering,
push
Not sure why you closed this? I actually spent some time yesterday digging into
it...
I am interested in knowing if you've found any sources backing up the theory
that entries with no expiry can somehow swamp out ones with an expiry as I'm
not really clear on how that would happen?
--
Reply
Did a bit research on some libraries that offer such functionalities and
implementation details that we could potentially use for this:
### 1. [notifications-rails](https://github.com/jonhue/notifications-rails)
`notifications-rails` provides a modular structure for creating, rendering,
pushing,
Closed #5038.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038#event-14965898966
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #4694.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4694#event-14965892280
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #5071.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5071#event-14965975015
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #5270.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270#event-14965984261
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@gravitystorm commented on this pull request.
> + def update
@user.roles.create(:role => @role, :granter => current_user)
I would suggest that `create` is a better method name, because:
* `create` and `destroy` are more natural opposites of each other than `update`
and `destroy`
* Since
13 matches
Mail list logo
