> Besides the [double-join db
> query](https://github.com/openstreetmap/openstreetmap-website/pull/5255#discussion_r1801064970),
> there's couple more issues with the interaction type: ["blue on blue"
> colors](https://github.com/openstreetmap/openstreetmap-website/pull/4700#issuecomment-2221682
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line
My PR hasn't been merged in two months so it must be good is an interesting
take.
That said I'm not totally sure why I didn't merge it - possibly I was concerned
about adding so much custom CSS code which we are generally trying to avoid.
Is there a reason not to use bootstrap here?
--
Reply
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5276#issuecomment-2427800288
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5276 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5276#event-14771781751
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5276
-- Commit Summary --
* Don't show older/newer buttons if all items fit on one page
-- File Changes --
M app/views/shared/_pagination.html.erb (4)
-- Patch
@mmd-osm pushed 1 commit.
4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7 Another danger test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7
You are receiving this because y
Updated pull request description.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5064#issuecomment-2427309130
You are receiving this because you are subscribed to this thread.
Message ID:
@mmd-osm pushed 1 commit.
f99d63bafd5f956773f740cb549d019179cbbf20 danger testing
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7..f99d63bafd5f956773f740cb549d019179cbbf20
You are receiving this because you ar
I found another alternative in https://github.com/chef/chef/pull/14134, which
is danger-js. It seems to work on a forked repo pull request:
The output is a bit buried in gh action logs. Fancy things like se
@mmd-osm pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/f99d63bafd5f956773f740cb549d019179cbbf20..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving this because you are subscribed to this thread.
Message ID:
Incidentally the "example" in the danger repo at
https://github.com/danger/danger/blob/master/.github/workflows/CI.yml is not
what it seems - if you look closely it never actually runs danger, it just
echos the command that would run it!
--
Reply to this email directly or view it on GitHub:
ht
@kcne commented on this pull request.
> @@ -6,41 +7,69 @@
:commented => tag.span(t(".subheading_commented"), :class => "px-2
py-1 bg-body") %>
<% end %>
-<% if @notes.empty? %>
- <%= t ".no_notes" %>
+<%= form_tag(url_for("controller" => "notes", "action" => "index"), "method"
@nenad-vujicic approved this pull request.
Works great! Thank you very much!!!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5276#pullrequestreview-2382493706
You are receiving this because you are subscribed to this thread.
I opened #5131 and put a number of changes to error pages to see which of them
are acceptable. The discussion there however has been about making more
changes. I guess that means nobody objects to the ones I made and we can have
them merged.
This PR changes the font of error pages to a default
I think that's fine. Log files from 3 weeks ago show that danger was running
back then:
https://github.com/danger/danger/actions/runs/11090746237/job/30813474684
--
Reply to this email directly or view i
Here's another comparison at 250% zoom. The old rendering looked a bit off, in
particular for the _(part of ways...)_ section.
Old | New
-- | --
|
You can view, comment on,
Closed #5259 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5259#event-14770454975
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line if con
@kcne approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5277#pullrequestreview-2383177034
You are receiving this because you are subscribed to this thread.
Message ID:
___
> My PR hasn't been merged in two months so it must be good is an interesting
> take.
How else can I get changes from that PR to be discussed instead of being asked
to make more changes like:
> Is there a reason not to use bootstrap here?
Yes
https://github.com/openstreetmap/openstreetmap-web
> There's no single API call to get geometry [of] old versions of elements
> other than nodes.
This doesn’t mean we couldn’t introduce such an API endpoint. Ways should be
ok, relations could be a bit expensive.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
23 matches
Mail list logo
