Re: [openstreetmap/openstreetmap-website] Rename database tables (Issue #5619)

2025-02-16 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5619) > even the question of how much point there is in treating the two > separately but that's another can of worms. The idea to get rid of current tables in one way or another isn't entirely new. Back in 2009, the infamous "Rant

Re: [openstreetmap/openstreetmap-website] Rename database tables (Issue #5619)

2025-02-16 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5619) > I can see that changeset_subscribers is accessed by cgimap, for example. > Would that be a blocker? I don't think so. The code you've found in cgimap is not used in production. Rails is taking care of the changeset create endp

Re: [openstreetmap/openstreetmap-website] Rename database tables (Issue #5619)

2025-02-16 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5619) > Have you also evaluated the other way around, i.e. change the model names to > match the db table names? Yes, I've considered it. But I think that in some cases this would not be wanted - for example, renaming the `Follow

Re: [openstreetmap/openstreetmap-website] Rename database tables (Issue #5619)

2025-02-05 Thread Nenad Vujicic via rails-dev
> > So my proposal is to rename the tables to match the model names. > > Have you also evaluated the other way around, i.e. change the model names to > match the db table names? Assuming that's feasible, that's significantly less > risk and effort for anything non-Rails (planetdump-ng, osmdbt, c

Re: [openstreetmap/openstreetmap-website] Rename database tables (Issue #5619)

2025-02-05 Thread mmd via rails-dev
> So my proposal is to rename the tables to match the model names. Have you also evaluated the other way around, i.e. change the model names to match the db table names? Assuming that's feasible, that's significantly less risk and effort for anything non-Rails. -- Reply to this email directl