Firefishy left a comment (openstreetmap/openstreetmap-website#4042)
Some initial PR: https://en.osm.town/@osm_tech/114902624740876388
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3108041035
You are receiving t
Merged #4042 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#event-18757743981
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Thanks for all the work on this, which I think is good to merge now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3104055385
You are receivin
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
@tomhughes PM sent from https://www.openstreetmap.org/user/bananaboy on OSM -
in case you want to use a different means of communication, please let me know
there
--
Reply to this email directly or view it on GitHub:
https://
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Thanks @petr-hajek I had in fact already registered a key there I had just
> forgotten about it ;-)
>
> I think this is good to merge now - what do you want to do about a key for us
> to use in production? Am I OK just to re
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Yes I deliberately didn't ask for that here as there's no point having two
people do the same work - it's just a conflict I can resolve when merging.
Indeed I've just done a test this afternoon of merging them both and resolving
hlfan left a comment (openstreetmap/openstreetmap-website#4042)
@tomhughes given your comments at #6137, I think it would be better to split up
the `leaflet.osm.vector.js` into a `leaflet.maplibregl.js` and a
`leaflet.openmaptiles.js` file.
--
Reply to this email directly or view it on GitHub:
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Thanks @petr-hajek I had in fact already registered a key there I had just
forgotten about it ;-)
I think this is good to merge now - what do you want to do about a key for us
to use in production? Am I OK just to register a ke
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Is there an api key I can use for testing? You can let me have it privately
> if you prefer...
I believe it should work with the Free account so just by signing up here you
can get one: https://cloud.maptiler.com/account/key
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Is there an api key I can use for testing? You can let me have it privately if
you prefer...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-30
jachym left a comment (openstreetmap/openstreetmap-website#4042)
> I think the only thing is that somebody suggested (and I can't remember where
> I saw it) that the layer included additional buildings that weren't from OSM
> data but I haven't had a chance to investigate that claim yet.
This s
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Whether or not the style.json path definition changes, this now looks good to
> me. That could also be worth revisiting when there's more than one vector
> style. Tests pass in my fork
> [hlfan#18](https://github.com/hlfan/o
@hlfan approved this pull request.
Whether or not the style.json path definition changes, this now looks good to
me. That could also be worth revisiting when there's more than one vector style.
Tests pass in my fork https://github.com/hlfan/openstreetmap-website/pull/18.
If you wanna do other rev
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
In the end I keep maplibre v4 with maplibre-gl-leaflet 0.0.22 since for some
reason the custom attribution got broken after updating. Someone else can
update this in some followup PR.
--
Reply to this email directly or view i
@petr-hajek pushed 1 commit.
cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a0fbba2fd57623718f90c56ba8d82c662368a7f..cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b
You are receiving thi
@petr-hajek commented on this pull request.
> @@ -79,3 +79,18 @@
osm_france_link:
id: "osm_france"
href: "https://openstreetmap.fr/";
+
+- leafletOsmId: "OpenMapTiles"
+ code: "V"
+ layerId: "openmaptiles_osm"
+ nameId: "openmaptiles_osm"
+ apiKeyId: "maptiler_key"
@petr-hajek pushed 1 commit.
4a0fbba2fd57623718f90c56ba8d82c662368a7f Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/8fc98e107970781caffed51aa5adaee913315363..4a0fbba2fd57623718f90c56ba8d82c662368a7f
You are receiving thi
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
I think the only thing is that somebody suggested (and I can't remember where I
saw it) that the layer included additional buildings that weren't from OSM data
but I haven't had a chance to investigate that claim yet.
--
Reply
pnorman left a comment (openstreetmap/openstreetmap-website#4042)
I *think* there was a question that still needed answering from MapTiler about
the featured layer discussions. I'll have to review emails or check notes to be
sure
--
Reply to this email directly or view it on GitHub:
https://gi
@hlfan commented on this pull request.
> @@ -79,3 +79,18 @@
osm_france_link:
id: "osm_france"
href: "https://openstreetmap.fr/";
+
+- leafletOsmId: "OpenMapTiles"
+ code: "V"
+ layerId: "openmaptiles_osm"
+ nameId: "openmaptiles_osm"
+ apiKeyId: "maptiler_key"
If yo
@petr-hajek pushed 1 commit.
fdc3e9da260c603bad306be6d28d58fc8018d109 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f8bd0b0153138be2f8c498370a3cc6665436b787..fdc3e9da260c603bad306be6d28d58fc8018d109
You are receiving thi
@petr-hajek pushed 1 commit.
8fc98e107970781caffed51aa5adaee913315363 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/fdc3e9da260c603bad306be6d28d58fc8018d109..8fc98e107970781caffed51aa5adaee913315363
You are receiving thi
@hlfan commented on this pull request.
On vendor/assets/leaflet/leaflet.osm.vector.js:
This shouldn't be under vendor but next to the leaflet.map.js you pulled it out
of.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#p
@petr-hajek pushed 1 commit.
f8bd0b0153138be2f8c498370a3cc6665436b787 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/bd723208a345d1bcef325fdd233d777d0e2bca41..f8bd0b0153138be2f8c498370a3cc6665436b787
You are receiving thi
@petr-hajek pushed 1 commit.
bd723208a345d1bcef325fdd233d777d0e2bca41 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/76ea626c96119c7fa401818efd264d58f0d2cb51..bd723208a345d1bcef325fdd233d777d0e2bca41
You are receiving thi
@petr-hajek commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(OSM
@hlfan commented on this pull request.
I didn’t see anything particularly noteworthy in your changes compared to
4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86, the few comments I’ve left are about
things you haven't touched yet.
> + for (let i = 0; i < OSM.preferred_languages.length; i++) {
+
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
@tomhughes I tried to address all the raised issues. Please bear with me as
this is my first PR to this repo, I'm ready for the feedback. Could you
authorize me to run the workflows to see if all the lints and test will pass?
@petr-hajek pushed 1 commit.
76ea626c96119c7fa401818efd264d58f0d2cb51 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/7565be18217452402e4a51c331cdc2f84af26328..76ea626c96119c7fa401818efd264d58f0d2cb51
You are receiving thi
@petr-hajek pushed 1 commit.
7565be18217452402e4a51c331cdc2f84af26328 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/0881ffa40e2b07036e2d81b452704c8c0b2a4c50..7565be18217452402e4a51c331cdc2f84af26328
You are receiving thi
@petr-hajek pushed 1 commit.
0881ffa40e2b07036e2d81b452704c8c0b2a4c50 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f08892f2cc41deec0a88a60aefb1e184754b22b4..0881ffa40e2b07036e2d81b452704c8c0b2a4c50
You are receiving thi
@petr-hajek pushed 1 commit.
f08892f2cc41deec0a88a60aefb1e184754b22b4 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/e0a533374d2127a2c3467bd6b090582f345bcaa7..f08892f2cc41deec0a88a60aefb1e184754b22b4
You are receiving thi
@petr-hajek pushed 1 commit.
4a7b1374945d8577ea7ec5408b05aeca02e5c497 revert vsc settings change
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/a28f6dbbe4f4e12489c4ad91d38118de56958ff0..4a7b1374945d8577ea7ec5408b05aeca02e5c497
You are receiving this
@petr-hajek pushed 1 commit.
e0a533374d2127a2c3467bd6b090582f345bcaa7 fix trailing coma
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a7b1374945d8577ea7ec5408b05aeca02e5c497..e0a533374d2127a2c3467bd6b090582f345bcaa7
You are receiving this because
@petr-hajek pushed 1 commit.
a28f6dbbe4f4e12489c4ad91d38118de56958ff0 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86..a28f6dbbe4f4e12489c4ad91d38118de56958ff0
You are receiving thi
pnorman left a comment (openstreetmap/openstreetmap-website#4042)
My PR won't touch OpenMapTiles stuff.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2985592436
You are receiving this because you are subscribed
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
I think @pnorman has also been working on it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2983176180
You are receiving this because you are
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Are the maintainers planning to make the final changes here, or should
> someone from the community do it?
I am planning to it in the next 2 weeks
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
JGreenlee left a comment (openstreetmap/openstreetmap-website#4042)
Are the maintainers planning to make the final changes here, or should someone
from the community do it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#iss
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> > Yes, I confirm that. Many thanks @zdila to push this PR.
> > We may take over it.
>
> Are you planning on taking over this PR? I have some work that will build on
> it, but I want to figure out what order to do the work in.
pnorman left a comment (openstreetmap/openstreetmap-website#4042)
> Yes, I confirm that. Many thanks @zdila to push this PR.
>
> We may take over it.
Are you planning on taking over this PR? I have some work that will build on
it, but I want to figure out what order to do the work in.
--
Repl
zdila left a comment (openstreetmap/openstreetmap-website#4042)
Just FYI I've left MapTiler and so I will no longer update this PR. Feel free
to update it to your needs yourselves. Good luck and best regards.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
@hlfan commented on this pull request.
> +<% if Settings.key?(:maptiler_key) %>
+ MAPTILER_KEY: <%= Settings.maptiler_key.to_json %>,
+<% end %>
This should be with the other keys in the embedded Settings json
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
jachym left a comment (openstreetmap/openstreetmap-website#4042)
> Just FYI I've left MapTiler and so I will no longer update this PR. Feel free
> to update it to your needs yourselves. Good luck and best regards.
Yes, I confirm that. Many thanks @zdila to push this PR.
We may take over it.
-
@1ec5 commented on this pull request.
> +
+ var copyright = I18n.t("javascripts.map.copyright_text", {
copyright_link: copyright_link });
+
+ var openmaptiles_link = I18n.t("javascripts.map.openmaptiles", {
+openmaptiles_url: "https://openmaptiles.org/";,
+maptiler_url
@AntonKhorev commented on this pull request.
> +
+ var copyright = I18n.t("javascripts.map.copyright_text", {
copyright_link: copyright_link });
+
+ var openmaptiles_link = I18n.t("javascripts.map.openmaptiles", {
+openmaptiles_url: "https://openmaptiles.org/";,
+mapti
@tomhughes commented on this pull request.
> +openmaptiles_url: "https://openmaptiles.org/";,
+maptiler_url: "https://www.maptiler.com/";
+ });
+
+ var terms = $("", {
+href: "https://wiki.osmfoundation.org/wiki/Terms_of_Use";,
+text: I18n.t("javascripts
@1ec5 commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
See
https://github.com/opens
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Also, the eslint warnings should be fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2676933485
You are receiving this because you are sub
@tomhughes requested changes on this pull request.
> @@ -107,6 +107,8 @@ attachments_dir: ":rails_root/public/attachments"
#logstash_path: ""
# List of memcache servers to use for caching
#memcache_servers: []
+# URL of Maptiler API for vector maps
+maptiler_url: "https://api.maptiler.com/";
@jachym commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
@1ec5 and @HolgerJeromin an
@zdila commented on this pull request.
> @@ -9,6 +13,35 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+
maplibregl.setRTLTextPlugin("https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
true);
Please see
https://github
@HolgerJeromin commented on this pull request.
> @@ -9,6 +13,35 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+
maplibregl.setRTLTextPlugin("https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
true);
I am pretty sure t
@zdila commented on this pull request.
> +var mainLocale = I18n.locale.slice(0, 2);
+var localeIndex = supportedLanguages.findIndex(function (locale) {
+ return locale === mainLocale;
+});
I have reworked language matching.
--
Reply to this email directly or v
@zdila pushed 1 commit.
4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4931b9c4ea1c5a11a4ac58c11d69ecf7efdc3d1c..4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86
You are receiving this bec
@zdila commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
Which build script do you me
@AntonKhorev commented on this pull request.
> +function update3dMapUrl() {
+ var el = document.getElementById("terrain_3d_url");
+
+ if (el) {
+var c = map.getCenter();
+var zoom = map.getZoom() - 1;
+var precision = Math.ceil(((zoom * Math.LN2) + Math.log(
@1ec5 commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
To avoid this external depend
You can test on https://osm.openmaptiles.org/ with credentials - login:
`martin.zd...@maptiler.com`, password: `osm4ever`
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2643167427
You are receiving this because
@zdila commented on this pull request.
> @@ -11,6 +15,40 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ L.OpenMapTiles = L.MaplibreGL.extend({
+options: {
+ maxZoom: 23,
+ style: "https://api.maptiler.com/maps/openstreetmap/style.json?key="; +
OSM.
@zdila commented on this pull request.
> @@ -11,6 +15,40 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ L.OpenMapTiles = L.MaplibreGL.extend({
+options: {
+ maxZoom: 23,
+ style: "https://api.maptiler.com/maps/openstreetmap/style.json?key="; +
OSM.
@zdila commented on this pull request.
> @@ -11,6 +15,40 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ L.OpenMapTiles = L.MaplibreGL.extend({
Implemented. Thanks for noticing.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreet
@zdila pushed 1 commit.
4931b9c4ea1c5a11a4ac58c11d69ecf7efdc3d1c add support for RTL
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/da7489a136e29a65dc7f47af143da8ee961116e5..4931b9c4ea1c5a11a4ac58c11d69ecf7efdc3d1c
You are receiving this because you
@zdila pushed 1 commit.
da7489a136e29a65dc7f47af143da8ee961116e5 add support for RTL
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/c9241ff862ca2dcf15bd185dd8886d611a44576d..da7489a136e29a65dc7f47af143da8ee961116e5
You are receiving this because you
@zdila pushed 9 commits.
cd4923cd656c3457da10c445e5e8139387ae53fa Add OpenMapTiles OSM vector map
295f0ab88763e0651c80382008a1352a6acf52e1 remove 3D map link from OMT
attribution
9ef470aa32efd83d6937b35eb26e27ae894ae19e add MAPTILER_KEY configuration
21dc45827f2228bf4a7b4fd89bfae306086ec244 O
@zdila pushed 1 commit.
b46499626f268319b942e282aae59d16b42b848a add support for RTL
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/fd2e5620f7fa151baa72d8364ad2df294bdc12e3..b46499626f268319b942e282aae59d16b42b848a
You are receiving this because you
@zdila pushed 1 commit.
fd2e5620f7fa151baa72d8364ad2df294bdc12e3 update language switching
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/79ac1ff323e2122c779486668ac63fdb85247b27..fd2e5620f7fa151baa72d8364ad2df294bdc12e3
You are receiving this becau
Still has "fix lint issues".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2634199830
You are receiving this because you are subscribed to this thread.
Message ID:
_
@zdila pushed 1 commit.
c51167d0cffdb90052cc1022b26aa73431f237a3 rename OpenMapTiles to MapTiler OMT
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/e683509902b76c58766075a95b6011b922a75169..c51167d0cffdb90052cc1022b26aa73431f237a3
You are receiving
@zdila pushed 7 commits.
344957986a01502ef11dc7fbb0221d66ab5f28bb Add OpenMapTiles OSM vector map
878480d1926a01e22932e1ca95d0a6b198235aeb remove 3D map link from OMT
attribution
a56675f51f104d470dd57c490a891145f0c2bc82 add MAPTILER_KEY configuration
1da1c68dbbad7af8665285c3953017e0110c6318 O
This is awaiting a response from MapTiler
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2529095928
You are receiving this because you are subscribed to this thread.
Message ID:
Commits such as "fix lint issues"
https://github.com/openstreetmap/openstreetmap-website/pull/4042/commits/888767144630f56340097450c362edc639a771d8
shouldn't exist, see
[CONTRIBUTING.md#pull-requests](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-request
This PR was discussed at the 10/31 OWG meeting according to the [public
minutes](https://osmfoundation.org/wiki/Operations/Minutes/2024-10-31#Vector_tile_serving).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-
New layers are approved by the Operations Working Group, which has not happened
yet.
It was last discussed at their [May
meeting](https://osmfoundation.org/wiki/Operations/Minutes/2024-05-16#OpenMapTiles_application_to_become_a_featured_layer).
I do not see that it has been on an OWG meeting
[
Any resolution regarding this PR? Can we have this PR merged and closed, I
believed, we addressed the concerns and issues of the community.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2404882461
You are rece
75 matches
Mail list logo
