Closed #5519.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519#event-16088595579
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Reopened #5519.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519#event-16063124204
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
1 Warning
:warning:
Merge commits are found in PR. Please rebase to
get rid of the merge commits in this PR, see CONTRIBUTING.md.
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this em
@hlfan pushed 1 commit.
9ab853e67b7c33e0dd7f434b391b79b6e604ed1b Merge branch 'master' into
embed-dark-mode
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519/files/037279aa9340d3db97fd890df11de38b9056724b..9ab853e67b7c33e0dd7f434b391b79b6e604ed1b
You are re
See also #5523
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519#issuecomment-2602887588
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev m
So, when I tested the changes locally, I edited the evaluated JS to make
iteration faster for me. Then the linter got mad. But eslint alone doesn't
check files that have embedded ruby, which I'll criticise in an issue later on.
As I don't like touching and "un-touching" code, I guess I'll keep ma
Closed #5519.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519#event-15989301711
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Firstly I didn't say it wasn't wanted, I said it is better to keep it in a
separate commit to make reviewing easier.
Secondly what "same linting as usual" is this? As far as I know it was already
passing our eslint rules so is this some additional linting of your own?
--
Reply to this email di
Just doing the same linting as usual, why is this not wanted now @tomhughes?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519#issuecomment-2600902355
You are receiving this because you are subscribed to this thread.
Message I
@tomhughes commented on this pull request.
Please try to avoid including stylistic changes like replacing single quotes
with double quotes in the same commit as functional changes as it makes it very
hard to tell what the actual functional changes are when reviewing...
--
Reply to this email
This PR
- Adds layer type switching based on a **new theme parameter** and
prefers-color-scheme
- Rewrites argument extraction and application of layer and bbox
- Lints this file apparently for the first time
Doesn't touch the CSS though.
You can view, comment on, or merge this pull request onlin
11 matches
Mail list logo
