Merged, thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5484#issuecomment-2580405482
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev m
Merged #5484 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5484#event-15868865539
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@gravitystorm commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
> Maybe if we use `assert_difference "DiaryEntry.count"`, we should also use
> `DiaryEntry.last` (or change `assert_difference`).
I've gone fo
@gravitystorm pushed 1 commit.
55e3f90dd47bd96970cd0d9e55fb56e70dd8cc75 Show diary entry after creation
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5484/files/5abd806909cc9624215a374520d55362886f7a15..55e3f90dd47bd96970cd0d9e55fb56e70dd8cc75
You are receivi
@AntonKhorev commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
> separately
Won't that be a fixup commit which we don't like here?
> do you have any preferences for referring to the entry
Maybe if we use `
@gravitystorm commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
Yes, I thought that too. I could refactor that as part of this PR, or
separately. Which would you prefer? (and do you have any preferences for
@AntonKhorev commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
It's a bit odd that the same diary entry has two different references next to
each other: `user.diary_entries.last` and `DiaryEntry.last`.
--
This allows users to review their post and use the social share buttons more
easily.
Refs #1391
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5484
-- Commit Summary --
* Show diary entry after creation
-- File
