Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-21 Thread Tom Hughes via rails-dev
Merged #5518 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5518#event-16019015784 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-21 Thread Tom Hughes via rails-dev
This all looks great to me, thanks. We probably want to think about indexes because changeset comments don't have an index on author+id (neither do diary comments but some people have 80k changeset comments vs a few hundred diary comments) but I don't think that's a blocker based on some quick

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-18 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. 43d60108daf5f097b81afd2200273713e244b9b7 Add tabbed navigation to user's diary comments page 9fbe52dd219c5f11ebee0243da4d08574cc761c5 Create user comments controller base class 420d9da1f98ee167a351828b2f20d3f1f0e164e7 Create changeset_comments resources for use

[openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-18 Thread Anton Khorev via rails-dev
A new version of #4248. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5518 -- Commit Summary -- * Simplify diary_comments_path calls in tests * Rename diary_comments_path to user_diary_comments_path * Change us