Embed pages have links to the *fixthemap* page that have lat/lon/zoom params:
[Example
link](https://www.openstreetmap.org/fixthemap?lat=53.25688279713156&lon=-1.4329004287719729&zoom=13)
*fixthemap* has an
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5869)
Removed the coordinate precision test in case they are added differently, like
from rails code.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869#issuecomme
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869#pullrequestreview-2733460897
You are receiving this because you are subscribed to this thread.
Message ID:
__
gravitystorm left a comment (openstreetmap/openstreetmap-website#5869)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869#issuecomment-2773223180
You are receiving this because you are subscribed to this thread.
Merged #5869 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869#event-17098072609
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,11 @@
+require "application_system_test_case"
+
+class FixthemapTest < ApplicationSystemTestCase
+ test "should have 'create a note' link with correct map hash" do
+visit fixthemap_path(:lat => 60, :lon => 30, :zoom => 10)
+
+wit
@AntonKhorev pushed 1 commit.
7b2d020d37f0be749890001ee499faaf549f80b7 Convert zoom to number in
OSM.formatHash
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869/files/28a1360ff1a91abb9f945ce06dd90c44e3704282..7b2d020d37f0be749890001ee499faaf549f80b7
You ar
@hlfan commented on this pull request.
> @@ -0,0 +1,11 @@
+require "application_system_test_case"
+
+class FixthemapTest < ApplicationSystemTestCase
+ test "should have 'create a note' link with correct map hash" do
+visit fixthemap_path(:lat => 60, :lon => 30, :zoom => 10)
+
+within_co
@AntonKhorev pushed 1 commit.
995422129edf0e953fc5c8d716424ffd9da9b6b2 Convert zoom to number in
OSM.formatHash
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869/files/12e5841304693ff23b3beb1d8b05d68048758969..995422129edf0e953fc5c8d716424ffd9da9b6b2
You ar
@AntonKhorev pushed 1 commit.
28a1360ff1a91abb9f945ce06dd90c44e3704282 Convert zoom to number in
OSM.formatHash
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869/files/995422129edf0e953fc5c8d716424ffd9da9b6b2..28a1360ff1a91abb9f945ce06dd90c44e3704282
You ar
hlfan left a comment (openstreetmap/openstreetmap-website#5869)
> Actually we don't need javascript to write new note links because
> lat/lon/zoom are available server-side, but I'm not changing that yet.
I added that to the second commit of #5752 because I was altering the link
building anyway
11 matches
Mail list logo
