Merged #5887 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887#event-17560209703
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks for the changes - this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887#pullrequestreview-2822502327
You are receiving this because you are subscribed to th
@tomhughes commented on this pull request.
> +return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom] || 17}/#{params[:lat]}/#{params[:lon]}"
Sorry yes you're right so maybe string interpolation is easier for that...
--
Reply to this email directly or
@hlfan pushed 1 commit.
c9d780e7b061f7dccc4c770eb03fe521c6ca06f4 Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/fb080fbc36fe1993ad39f1de430a43a9997b657c..c9d780e7b061f7dccc4c770eb03fe521c6ca06f4
You are receiving this beca
@hlfan commented on this pull request.
> +return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom] || 17}/#{params[:lat]}/#{params[:lon]}"
It needs the `map=` to work, though?
--
Reply to this email directly or view it on GitHub:
https://github.com/open
@tomhughes commented on this pull request.
> +return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom] || 17}/#{params[:lat]}/#{params[:lon]}"
I suggest just returning the target:
```suggestion
return nil unless params[:lat].present? && params[:lon].p
@hlfan pushed 1 commit.
fb080fbc36fe1993ad39f1de430a43a9997b657c Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/7ebbe63aec4154cd3c30b44ef95472cf6a48699d..fb080fbc36fe1993ad39f1de430a43a9997b657c
You are receiving this beca
@hlfan commented on this pull request.
> @@ -23,6 +23,12 @@ def result_to_html(result)
safe_join(html)
end
+ def map_hash(params)
+return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom].to_i ||
17}/#{params[:lat].to_f}/#{params[:lon].to_f}"
@hlfan pushed 1 commit.
7ebbe63aec4154cd3c30b44ef95472cf6a48699d Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/1e13706e1de0479d48ea8c8c1db4f83a90aeb9f0..7ebbe63aec4154cd3c30b44ef95472cf6a48699d
You are receiving this beca
@tomhughes commented on this pull request.
> @@ -81,7 +81,8 @@
<% if params[:oauth_return_url] %>
<%= t
".continue_authorization" %>
<% else %>
- <%= t
".start_mapping" %>
+ <%= editor_query = "?editor=#{params[:editor].to_s.split(/\W/)[0]}" if
params[:editor].present?
Same here, I co
@tomhughes commented on this pull request.
> @@ -23,6 +23,12 @@ def result_to_html(result)
safe_join(html)
end
+ def map_hash(params)
+return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom].to_i ||
17}/#{params[:lat].to_f}/#{params[:lon].to_f
@hlfan commented on this pull request.
> @@ -81,7 +81,8 @@
<% if params[:oauth_return_url] %>
<%= t
".continue_authorization" %>
<% else %>
- <%= t
".start_mapping" %>
+ <%= editor_query = "?editor=#{params[:editor].to_s.split(/\W/)[0]}" if
params[:editor].present?
Brakeman complained
@hlfan commented on this pull request.
> @@ -23,6 +23,12 @@ def result_to_html(result)
safe_join(html)
end
+ def map_hash(params)
+return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom].to_i ||
17}/#{params[:lat].to_f}/#{params[:lon].to_f}"
@tomhughes commented on this pull request.
> @@ -23,6 +23,12 @@ def result_to_html(result)
safe_join(html)
end
+ def map_hash(params)
+return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom].to_i ||
17}/#{params[:lat].to_f}/#{params[:lon].to_f
@hlfan pushed 1 commit.
1e13706e1de0479d48ea8c8c1db4f83a90aeb9f0 Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/12c9885e63c4d2e8536d10e01c90877be1d526ec..1e13706e1de0479d48ea8c8c1db4f83a90aeb9f0
You are receiving this beca
@hlfan pushed 1 commit.
12c9885e63c4d2e8536d10e01c90877be1d526ec Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/d0fd248d99f300bd575728c4c3ab23a9f3917c5c..12c9885e63c4d2e8536d10e01c90877be1d526ec
You are receiving this beca
@hlfan pushed 1 commit.
d0fd248d99f300bd575728c4c3ab23a9f3917c5c Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/502ea242112a7b81388be8ac3fc2cfc59dedddf3..d0fd248d99f300bd575728c4c3ab23a9f3917c5c
You are receiving this beca
There is not just a `formatHash` call in `fixthemap` but also one in `welcome`
that can be written in the template.
Looked through all `formatHash` calls and cleaned up another call.
Builds on the commit from #5752 that fixes gravitystorm#257.
See also #5869.
You can view, comment on, or merge thi
18 matches
Mail list logo
