mmd-osm left a comment (openstreetmap/openstreetmap-website#5080)
Closing since there were too many breaking upstream changes in the meantime.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2672436660
You are re
Closed #5080.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#event-16387647115
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
> Ok, I think you would need to further elaborate on your proposal
#5385 as a first step in replacing css backgrounds with images. See how I only
use one pixel value of 20px / 1.25rem.
> The old rendering looked a bit off, in particular for the (part of ways...)
> section.
*Part of ways* I'd d
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
@mmd-osm pushed 20 commits.
88255573de25e59f6ae4d95544478dbdbcce02a7 Browse icons as svg
f484f93b8a82c931e1f4b971f2faa848f239e67b Visibility improvements for dark mode
c2e6dc276384c311fd89c17401560997c443ae99 Fine tune position of 9 svg symbols
81f6f5eeeb1c1283165535d5310bab693be5b335 Replaced
Here's another comparison at 250% zoom. The old rendering looked a bit off, in
particular for the _(part of ways...)_ section.
Old | New
-- | --
|
 map*. We need to decide what size the icons
@mmd-osm commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ transfo
@mmd-osm pushed 1 commit.
ea30534be46a5150295a53c2c67b45332fd91c52 Visibility improvements for dark mode
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/40c07ec9b7b87923f3236ea09b9e30c35f973bb4..ea30534be46a5150295a53c2c67b45332fd91c52
You are receiv
Thank you for reviewing this PR another time.
> some icons are too dark, I inverted and hue-rotated them; here it's not done
> I suppose; see place_of_worship icon for an extreme example
Agree, that's also something I've noticed. I'm pushing another commit now which
should improve the situation
I still think it's
[easier](https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2298987792)
to switch to ``s first, then start replacing them with svgs, assuming all
of the images have the same size. Hopefully we can avoid random pixel offsets
in css.
--
Reply to thi
@AntonKhorev commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ tra
Some icons before/after in dark mode:
;
