@nertc commented on this pull request.
> +if (!locationInput.dirty ||
> locationName.includes(locationInput.countryName)) {
+ $("#location_name_warning").addClass("d-none");
+} else {
+ $("#location_name_warning").removeClass("d-none");
+}
As we updated logic, this code b
@nertc commented on this pull request.
> +http://www.w3.org/2000/svg"; width="16"
> height="16" fill="currentColor" class="bi bi-geo-alt-fill" viewBox="0 0 16
> 16">
+
+
`<%= t ".home location" %>` was added to the svg.
--
Reply to this emai
@nertc pushed 1 commit.
777eb643422fcd5267c647b388e14144e8f5fe09 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/aac929d79e91cb554655a60b1a2cc81a364d6d7f..777eb643422fcd5267c647b388e14144e8f5fe09
You are receiving this because yo
@nertc pushed 1 commit.
aac929d79e91cb554655a60b1a2cc81a364d6d7f Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/135ca1badb8f21f0047153547def0a954e6f7037..aac929d79e91cb554655a60b1a2cc81a364d6d7f
You are receiving this because yo
@nertc pushed 1 commit.
defb24f00bf08f00b778c0270b9887502b48a340 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/77e3f39bdf29c9a41475e1ea1347560add9c65d3..defb24f00bf08f00b778c0270b9887502b48a340
You are receiving this because yo
@nertc pushed 1 commit.
77e3f39bdf29c9a41475e1ea1347560add9c65d3 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/ead1ba9ab27dd2ca00c395a36cf99403792e2be2..77e3f39bdf29c9a41475e1ea1347560add9c65d3
You are receiving this because yo
@nertc pushed 1 commit.
ead1ba9ab27dd2ca00c395a36cf99403792e2be2 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/5fd8b6165732618de7d8ef987d170809eacfb59a..ead1ba9ab27dd2ca00c395a36cf99403792e2be2
You are receiving this because yo
@nertc commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
Yes, either on page load, or if we want to avoid an additional call on the page
load, we can call Nominatim twice on the first change of the pin (one for the
previous value and one fo
@AntonKhorev commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
> If `Location Name` field value exactly matches with the country name of the
> pin
That requires fetching the country from Nominatim before the location changes,
possibly on p
@nertc commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
Thanks for suggestions. I agree with you, it seems current solution has some UI
problems, but adding additional disabled input doesn't align with the UI
practices we are currently usi
@AntonKhorev commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
and the button can become too large
--
Reply to this email directly or view it on GitH
@AntonKhorev commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
Maybe we want something like this?
"Autofill %{country}" is probably not going to look g
@AntonKhorev commented on this pull request.
> +http://www.w3.org/2000/svg"; width="16"
> height="16" fill="currentColor" class="bi bi-geo-alt-fill" viewBox="0 0 16
> 16">
+
+
We probably want `` in this svg.
--
Reply to this email directly
@AntonKhorev commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
The language of %{country} is currently based on the browser settings /
Accept-Language header. Is it what we want?
--
Reply to this email directly or view it on GitHub:
https:
@AntonKhorev commented on this pull request.
> +if (!locationInput.dirty ||
> locationName.includes(locationInput.countryName)) {
+ $("#location_name_warning").addClass("d-none");
+} else {
+ $("#location_name_warning").removeClass("d-none");
+}
Wouldn't using jQuery's `s
Thank you for the review. PR was updated according to the comments.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2497515015
You are receiving this because you are subscribed to this thread.
Message ID:
__
@nertc commented on this pull request.
> @@ -178,6 +220,42 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+const g
@nertc commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
Was changed with the button named "Autofill %{country}".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#discuss
@nertc commented on this pull request.
> @@ -178,6 +220,42 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+const g
@nertc commented on this pull request.
> @@ -0,0 +1,22 @@
+require "application_system_test_case"
+
+class UserLocationChangeTest < ApplicationSystemTestCase
+ def setup
+stub_request(:get, /.*gravatar.com.*d=404/).to_return(:status => 404)
+ end
+
+ test "User can change their location"
@nertc pushed 1 commit.
5fd8b6165732618de7d8ef987d170809eacfb59a Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6..5fd8b6165732618de7d8ef987d170809eacfb59a
You are receiving this because yo
@nertc pushed 1 commit.
9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e..9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6
You are receiving this because yo
@nertc pushed 1 commit.
91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda..91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e
You are receiving this because yo
@AntonKhorev commented on this pull request.
> @@ -178,6 +220,42 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+c
@AntonKhorev commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
This looks like a sentence and it's not obvious that it ends with a button I'm
supposed to click to update the value:
.ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+c
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,22 @@
+require "application_system_test_case"
+
+class UserLocationChangeTest < ApplicationSystemTestCase
+ def setup
+stub_request(:get, /.*gravatar.com.*d=404/).to_return(:status => 404)
+ end
+
+ test "User can change their loca
@tomhughes Thank you for the comment. I agree with you about the complexity of
the code, but there are several reasons for both methods.
Changing location name manually solves cases like:
1. Disputed areas - someone living in the area A may not want to show that area
is part of country B and no
This seems like an awful lot of complication...
It seems to me that we have the option of either allowing the user to input
freetext, or of generating something from the location with Nominatim but this
tries to do both at once which just makes things very complicated and probably
quite confus
@nertc pushed 1 commit.
e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/d20e90d5a8e55b94805cbe21c3c0633ddea36cc6..e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda
You are receiving this because yo
PR adds location name info on the user profile page. Location name can be
changed from "Edit Profile" page either by manual typing or
auto-filling according to the home location.
One column was added to the user table to save user's location.
JS logics are responsible for handling:
1) Delete-Und
31 matches
Mail list logo
