> Maybe create a new issue for this topic.
> https://github.com/prettier/plugin-ruby could be starting point.
I am not sure if this only formats ruby code.
I am an JS/TS expert so I focus on (native and embedded) js code.
--
Reply to this email directly or view it on GitHub:
https://github.com
> Most stylistic rules are now removed from eslint because most use a formatter
> like prettier.io
@HolgerJeromin Formatting rules have indeed been
[deprecated](https://github.com/eslint/eslint/issues/17522) in the _core_ of
ESLint. But mainly because of ongoing maintenance cost. Luckily, antfu
Maybe create a new issue for this topic.
https://github.com/prettier/plugin-ruby could be starting point.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2614086393
You are receiving this because you are subscr
That would indeed be an interesting issue to be discussed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2614081848
You are receiving this because you are subscribed to this thread.
Message ID:
We should discuss if we want to keep the current eslint config.
Most stylistic rules are now removed from eslint because most use a formatter
like prettier.io
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-261
> Is this the shortest time the _awaiting upstream_ tag was necessary?
I think so!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2612667455
You are receiving this because you are subscribed to this thread.
M
If you introduce linting here you might also be interested in:
- How we use ESLint on GitHub Actions via [this
file](https://github.com/MaMpf-HD/mampf/blob/23aae01471c4361b85e86df06e349cd8acfb735c/.github/workflows/linter.yml#L39-L75)
to lint only the changes inside changed `.js` and `.js.erb` f
Is this the shortest time the _awaiting upstream_ tag was necessary?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2611228271
You are receiving this because you are subscribed to this thread.
Message ID:
___
Thanks for the suggestion @hlfan. I've looked into this today, but I've run
into a problem with the plugin that you found - we're writing our `.js.erb`
files in a way that it isn't happy with.
I've logged an issue for now upstream
https://github.com/Splines/eslint-plugin-erb/issues/15
You can
### Problem
The JS with embedded Ruby isn't held to the same standards as all the other JS
code.
### Description
Please look into enabling linting files with embedded Ruby in ESLint.
The [eslint-plugin-erb](//github.com/Splines/eslint-plugin-erb) could help here.
### Screenshots
![osm.js.erb]
10 matches
Mail list logo
