> Sure, but I think appearance and language are important enough to be quickly
> accessible at all times, like on Wikipedia.
UI language is not quickly accessible on Wikipedia:
--
Reply to this email dir
> you can't have a button in the header for every possible setting
Sure, but I think appearance and language are important enough to be quickly
accessible at all times, like on Wikipedia.
Another option to consider would be placing them directly in the drop-down
menu, like on YouTube or Reddit:
> It also requires at least 6 clicks to change one value from the home page, 8
> for both, +1 to go back to the home page.
3 clicks on Wikipedia in a similar scenario, without the *Appearance* sidebar
visible.
You can propose:
- one always visible preferences button (takes space of one button,
> [This
> proposal](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480755496)
> is much better
Only if you look at it in isolation, because there's also #5201 and you can't
have a button in the header for every possible setting.
--
Reply to this email directl
Apparently this was decided
[here](https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2504202626)
but I don't understand this choice @gravitystorm.
Even for registered users it's bad because they can't set dark on desktop and
light on mobile for example.
--
Reply to
I have to agree with @Nekzuris - accessibility should be available for all
users, not just registered users. Should the preference be stored as a browser
cookie?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment
No because non-logged in users can't set light map.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2537382117
You are receiving this because you are subscribed to this thread.
Message ID:
Given the merge of #5362, should this issue be closed?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2536887818
You are receiving this because you are subscribed to this thread.
Message ID:
_
Personally, I find the discussion of "colour-modes" for maps misleading. Maps
have colours, selected by the developers of a map style based on their own
criteria and preferences. If you change those colours (you want them darker? a
different background? inverted? etc.) then you are creating a ne
If a hillshaded map is featured in light mode, and the cartographers' decision
for the dark mode variant is to have a light version of the style without
hillshading be inverted by the browser.
This would mean a different URL/style and a filter. Should this be permitted?
--
Reply to this email d
> Should cartographers have the choice to use a specific style _and_ a filter
> or is it an exclusive or? Because this would change how I would implement
> this choice.
I'm sorry, I don't understand your question.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstr
Should cartographers have the choice to use a specific style *and* a filter or
is it an exclusive or? Because this would change how I would implement this
choice.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecommen
> "let's make everyone have no filter until _the cartographers_ let them have
> some filter"?
Technically that depends on the discussion in #5328. It doesn't strictly matter
how dark mode maps are implemented, in order to have this preference available
and useful.
But yes, since my preference
@gravitystorm Is 5 "let's make everyone use this particular filter in dark
mode" (which filter?) or is it "let's make everyone have no filter until *the
cartographers* let them have some filter"?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
Thanks for your comments. Here is my proposal.
(You can think of this as a hierarchy, where each line is an override for the
previous step)
1. We should continue to serve light mode by default.
2. If a browser requests dark mode (through the
[prefers-color-scheme](https://developer.mozilla.org/
It’s unfortunate that a website has to consider implementing this at all.
Ideally it could just respect `prefers-color-scheme` and let the browser handle
asking/remembering your preference.
[![browser UI for dark mode preference
per-site](https://github.com/user-attachments/assets/cda2041d-d8cc
However, for OSM's most prominent raster map, Carto, this isn't planned, as
it's considered out of scope.
https://github.com/gravitystorm/openstreetmap-carto/issues/5044#issue-2660981521
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website
The solution to dark mode for the tiles isn't to dim the light mode tiles.
It's to design and develop a dark version of the standard tile theme. This is
approach taken by Google Maps and Apple Maps.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
> @gravitystorm is incorrect to perceive "dark mode for the maps is off-topic"
I want to clarify here that I didn't say that, I said "The exact implementation
of dark mode for the maps is off-topic for this issue." What I mean is that
it's not the right issue for discussing things like whether `
Here's a simple UI proposal:
Dark theme toggle depends on system settings (just like now), but user can
override it by pressing the toggle button in top left corner. The setting will
be remembe
Adding onto @pkrasicki's proposal:
Modern CSS could even skip the body class:
```css
.leaflet-tile-pane .leaflet-layer:not(.dark), .mapkey-table-entry
td:first-child > * {
body:has(input[type="radio"][name="filter"][value="light"]:checked) & {
filter: none;
}
If that setting is stored in a cookie instead of in `localStorage` the server
can already set the theme to avoid flashbanging users reloading the site (e.g.
to see how their edits show up), as this would probably come rather late in the
packaged js.
--
Reply to this email directly or view it o
As for preferences, I'd like to hear from people what kind of preferences they
would like to see. So far, across multiple different threads, I've seen the
following:
* Automatic / Light (always) / Dark (always)
* Should this be stored per-user or per-browser (e.g. someone wants dark-always
on t
> Because it dims the graphic screen! @gravitystorm is incorrect to perceive
> "dark mode for the maps is off-topic" They are determinately intertwined.
>
Exactly. That user has declared multiple interrelated microissues with strict
"off topic" rules for each which is illogical and impractical
> Having a dark menu bar is nice, but simply dimming the map is just not
> acceptable. Maybe as a first step towards a truly dark mode, but please,
> please, please make it easy for the user to switch back to light mode. The
> toggle is a must!
THIS EXACTLY. The menu dark is fine but the map i
> Some users do not want to use the new dark mode
This would only apply to users who want to use dark mode in general, but not on
OSM. Is this a large body of users? Could it be reduced with improvements to
dark mode?
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
> What I'm interested in is why you want dark mode for everything else, but not
> for OSM.
Because it dims the graphic screen!
@gravitystorm is incorrect to perceive "dark mode for the maps is off-topic"
They are determinately intertwined.
I think the obvious needs pointing out - this is on the
> why you want dark mode for everything else, but not for OSM.
Not only OSM, but maps in general looks bad in dark mode. I have all my apps in
dark mode except maps app.
But a darker UI with normal tiles looks nice.
--
Reply to this email directly or view it on GitHub:
https://github.com/openst
> For myself, I value the ability to turn off dark mode for individual sites
> entirely. When working on maps, I often cross reference images, notes and
> other information, most of which don't have a "dark mode" so the switching
> back and forth is jarring
I would have thought this would resul
> Could it be reduced with improvements to dark mode?
For myself, I value the ability to turn off dark mode for individual sites
entirely. When working on maps, I often cross reference images, notes and other
information, most of which don't have a "dark mode" so the switching back and
forth is
> related to having an option to enable or disable dark mode
Just one option? Why not more?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
Please keep discussions here related to having an option to enable or disable
dark mode. The exact implementation of dark mode for the maps is off-topic for
this issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issue
We need this option, until the dark mode improves, otherwise the visibility of
the map and its use is reduced.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2478391410
You are receiving this because you are
Having a dark menu bar is nice, but simply dimming the map is just not
acceptable. Maybe as a first step towards a truly dark mode, but please,
please, please make it easy for the user to switch back to light mode.
The toggle is a must!
--
Reply to this email directly or view it on GitHub:
htt
It darkens the map background, which also dims the map. and no option to
disable dark mode on the page.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-242931
You are receiving this because you are subscri
There should be absolutely no image or map dimming. It just reduces readability.
Just leaving this comment here so an option is **NOT** created for it. The
dimming shouldn’t be a thing.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
I agree, there needs to be a config option.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2477298494
You are receiving this because you are subscribed to this thread.
Message ID:
___
The tile screen didn't need dimming; it makes it difficult to read.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2477244820
You are receiving this because you are subscribed to this thread.
Message ID:
### Problem
Browsers do not let you set a per-site dark mode preference. Some users do not
want to use the new dark mode.
### Description
A toggle similar to the Wikipedia appearance (see below). It should probably be
accessible for users who are not logged in, as well.
### Screenshots
