Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-12 Thread Oscar McNoe via rails-dev
Why not expand the options in the preferences to: * Auto _(same behaviour as suggested by @gravitystorm )_ * Light * Dark (if available) _(this option would revert back to Light mode tiles if unavailable)_ * Dark (filter) _(this option will enable the current CSS tile filter against Light mode ti

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Oscar McNoe via rails-dev
@hlfan adding an option only for logged in users still doesn't fix the dimmed tiles issue for anyone who's not logged into an account, which I'd guess is a majority of users? The dimmed tiles will still be the **default** option for all visitors to the site. The dimmed tiles are just really ba

Re: [openstreetmap/openstreetmap-website] Map color mode preference (PR #5362)

2024-12-05 Thread Oscar McNoe via rails-dev
This will only be configurable for logged in users, meaning that non-logged in will still be stuck on the dark UI + dimmed tiles. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5362#issuecomment-2522096154 You are receiving this

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Oscar McNoe via rails-dev
There isn't any need to get into the blame game of who did what, but it's ridiculous that the filter still hasn't been rolled back in spite of overwhelming opposition from community members. If @AntonKhorev is committed to solving dark map tiles with filters that's fine, but the filters need to

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)

2024-11-24 Thread Oscar McNoe via rails-dev
> Maybe for discussion in #5328 to conclude? Reacting to comments there or > posting new, if you have something new to say, may be a good idea. @matkoniecz Whatever the outcome of #5328 comes to it seems very unlikely the consensus will be to keep the current dimming filter as is. This dimming f

Re: [openstreetmap/openstreetmap-website] Offer links to competing mapping services' websites (Issue #5343)

2024-11-19 Thread Oscar McNoe via rails-dev
I think this could raise concerns regarding copyright. Looking at Google maps data and then contributing improvements to OSM data based on that is a copyright violation. It's probably best for OSM not to directly link to external services where integrating those services data into OSM is not leg

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-11-18 Thread Oscar McNoe via rails-dev
The solution to dark mode for the tiles isn't to dim the light mode tiles. It's to design and develop a dark version of the standard tile theme. This is approach taken by Google Maps and Apple Maps. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstree

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-18 Thread Oscar McNoe via rails-dev
I think it's worth taking a lesson from other web mapping providers. All of them have taken the 4th approach, of developing complete dark mode tiles for the map. It's the most costly/labour intensive to develop, but it's also likely to have the best overall outcome in the long term. -- Reply t