Re: [openstreetmap/openstreetmap-website] Move Bootstrap modal ok string out of javascripts (PR #6294)

@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6294#pullrequestreview-3089755673 You are receiving this because you are subscribed to this thread. Message ID: __

[openstreetmap/openstreetmap-website] Instantiate controller only once needed (PR #6295)

Second part of #6291. Perhaps the event handler initialization would be better located in something like `OSM.initializeContextMenu`. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6295 -- Commit Summary -- * Move

Re: [openstreetmap/openstreetmap-website] Introduce scoped placeholder `type:` for element routes (PR #6149)

@hlfan pushed 3 commits. 81adcec45188242137c24b553ee10095bacbcf85 Align route regex initialisation e9e7eefc21da72f8054fe9555990969017d2e6c3 Add scoped placeholders for router be5b56aaa60edc58400879e08f8aecea561221b3 Specify element handlers more compactly -- View it on GitHub: https://github

[openstreetmap/openstreetmap-website] Instantiate js controllers only in router (PR #6291)

A step towards lazily instantiating these controllers. A few event handlers (like for query and search) need to be moved to allow the controllers to really be instantiated lazily. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-web

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

@hlfan pushed 2 commits. 48e0c9c6c35d99ce587c2dbf8f8aaf60057750ad Use only differences to OSM logo in internal social link icons 8e288712818182f07d0257ea8f65a2f757b0a6ea Add OSM logo indicator for related social links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-websi

Re: [openstreetmap/openstreetmap-website] Flatten DownloadUtil (PR #6285)

hlfan left a comment (openstreetmap/openstreetmap-website#6285) > The last few commits may be debatable. Modernize away then! There are lots of fetches to take on. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6285#issuecomment

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (2) (PR #6286)

@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6286#pullrequestreview-3082334217 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (PR #6284)

@hlfan commented on this pull request. >} OSM.getTurboBlobHandler = DownloadUtil.getTurboBlobHandler; + OSM.getHtmlResponseHandler = DownloadUtil.getHtmlResponseHandler; I'd mark it as a draft in the meantime, since these PRs are targeting different things. -- Reply to this email d

[openstreetmap/openstreetmap-website] Flatten DownloadUtil (PR #6285)

Cleaning up a relatively unnecessary class. See also https://github.com/openstreetmap/openstreetmap-website/pull/6284#discussion_r224654. The last few commits are debatable. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-websi

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (PR #6284)

@hlfan commented on this pull request. >} OSM.getTurboBlobHandler = DownloadUtil.getTurboBlobHandler; + OSM.getHtmlResponseHandler = DownloadUtil.getHtmlResponseHandler; Does it have to be defined in the class, can't it be just written here? Or even outside the IIFE since it's in the

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (PR #6284)

@hlfan commented on this pull request. > @@ -52,7 +52,20 @@ } }; } + +static getHtmlResponseHandler(event) { + const response = event.detail.fetchResponse.response; + const contentType = response.headers.get("content-type"); + + if (!response.ok && content

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (PR #6284)

@hlfan commented on this pull request. > @@ -52,7 +52,20 @@ } }; } + +static getHtmlResponseHandler(event) { That function doesn't return a function, so I'd remove the "get" in the name. It's also turbo specific, so that should probably be in the name. -- Reply to thi

[openstreetmap/openstreetmap-website] Rework map element click handling (PR #6281)

Yet another PR for click handling. This fixes #6264 and probably solves #6276 too, but due to the nature of that issue, I haven't been able to test that. In contrast to #6267, this approach does not make assumptions about what modifiers do. It also doesn't make assumptions about the event type.

[openstreetmap/openstreetmap-website] Use more form helpers (PR #6280)

Somewhere (I didn't find it on the fly), that was said to be preferred. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6280 -- Commit Summary -- * Use more form helpers -- File Changes -- M app/views/notes/new

Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (PR #6111)

@hlfan commented on this pull request. > +> This step is entirely optional. You can start using the editors > immediately to create new data, or if you prefer to work with existing data, > you can import an extract with > [Osmosis](https://wiki.openstreetmap.org/wiki/Osmosis) and the > [`--w

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

hlfan left a comment (openstreetmap/openstreetmap-website#6265) Closing in favor of #6267 due to #6276. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6265#issuecomment-3143722400 You are receiving this because you are subscribed

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

Closed #6265. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6265#event-18934617636 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] Update community forum icon (PR #6278)

To make the effort spent on getting the vector source for #6072 not go to waste. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6278 -- Commit Summary -- * Update community forum icon -- File Changes -- M app/

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

@hlfan pushed 1 commit. 0e978f3eb964ee6ec39a3895fc30697f99c882d2 Remove link targets while dragging the map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6265/files/ffe98ed3768e9f5445f96e53761edc815fe4d55f..0e978f3eb964ee6ec39a3895fc30697f99c882d2 You are re

Re: [openstreetmap/openstreetmap-website] Restrict marker scaling to search results (PR #6270)

hlfan left a comment (openstreetmap/openstreetmap-website#6270) When a note is selected, another marker is drawn for the note. Then, hovering over the note marker can give you this result: https://github.com/user-attachments/assets/a53c5eb3-858e-48b5-abf3-41bcdebcc9c6"; /> To fix that, while k

[openstreetmap/openstreetmap-website] Move more styling from CSS to Bootstrap (PR #6271)

Continuing the effort to slim down common.scss You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6271 -- Commit Summary -- * Move more styling from CSS to Bootstrap -- File Changes -- M app/assets/stylesheets/co

[openstreetmap/openstreetmap-website] Restrict marker scaling to search results (PR #6270)

It doesn't really make sense to have every marker scale in response to being hovered over. This PR restricts this behaviour only to the search markers. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6270 -- Commit Sum

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

hlfan left a comment (openstreetmap/openstreetmap-website#6265) Have you looked at the types of events that end up there? The event type is _always_ `click`. That's the problem with that idea. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-w

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

hlfan left a comment (openstreetmap/openstreetmap-website#6265) Maybe put the re-enabling in a timeout? But then that also has to be fine-tuned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6265#issuecomment-3130991044 You are

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

hlfan left a comment (openstreetmap/openstreetmap-website#6265) We don't want to stop all clicks from happening, only the ones while dragging. The "drag" event that ends up there is indistinguishable from an intended click. If we want links to end up there without intervention (`a.click()` or simi

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

hlfan left a comment (openstreetmap/openstreetmap-website#6265) I'm afraid I'm out of ideas that don't include `a.click()` in some shape or another. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6265#issuecomment-3128597378 You

Re: [openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

@hlfan pushed 1 commit. ffe98ed3768e9f5445f96e53761edc815fe4d55f Remove link targets while dragging the map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6265/files/3d734befca51649f703f3bb4bf444a012de61205..ffe98ed3768e9f5445f96e53761edc815fe4d55f You are re

[openstreetmap/openstreetmap-website] Remove link targets while dragging the map (PR #6265)

Fixes #6264 by removing the link target when moving the map. Since the click event happens before moveend, and the click events aren't recognized as drag events, I don't think there's a less bodgy solution. You can view, comment on, or merge this pull request online at: https://github.com/opens

Re: [openstreetmap/openstreetmap-website] History: Dragging selects changeset (Issue #6264)

hlfan left a comment (openstreetmap/openstreetmap-website#6264) Well, this isn't canvas-related. Otherwise, there couldn't be anchors wrapped around the bboxes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6264#issuecomment-

Re: [openstreetmap/openstreetmap-website] History: Dragging selects changeset (Issue #6264)

hlfan left a comment (openstreetmap/openstreetmap-website#6264) These errors don't seem to have to do anything with the changeset bbox layer. Since the dragend events get registered as clicks, leaflet might be interfering with the drag recognition. -- Reply to this email directly or view it on

Re: [openstreetmap/openstreetmap-website] Bootstrap modal instead of alert() (PR #6263)

@hlfan commented on this pull request. > @@ -10,14 +10,21 @@ URL.revokeObjectURL(url); }; + OSM.showAlert = function (message) { +const modalBody = document.getElementById("osm_alert_message"); +modalBody.textContent = message; +const alertModal = new bootstrap.Modal(docu

[openstreetmap/openstreetmap-website] Remove hard-coded stuff in header (PR #6262)

Aligning the buttons with flexbox means they move up a pixel or two. The locale selector button adapts its height to the available space, now 35px high instead of 36.5px. Setting the menu item stroke and width with the Bootstrap colors (after inlining it) removes the need to invert it. Closes #60

[openstreetmap/openstreetmap-website] Always show marker shadows (PR #6261)

For the affected note makers, this makes them stand out more against the background and each other. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6261 -- Commit Summary -- * Always show marker shadows -- File Cha

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

@hlfan pushed 1 commit. e8acb3c8561348a964fb973265c54f453a3d4738 Make search show multiple markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6235/files/a076134f0012b532b3d133036dcc5e2f8cabbb18..e8acb3c8561348a964fb973265c54f453a3d4738 You are receiving th

[openstreetmap/openstreetmap-website] Make handler able to handle SVG links (PR #6260)

SVG anchors don't have the URL properties, which forces a page reload. This can be avoided by getting the properties from the href. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6260 -- Commit Summary -- * Make ha

[openstreetmap/openstreetmap-website] Lower max allowed blank line count (PR #6258)

Only very few affected gaps, none of which looked like it was needed for contextual separation. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6258 -- Commit Summary -- * Deduplicate multiple blank lines -- File C

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

@hlfan pushed 2 commits. 6062bb97bb1c0c78e9623d40c81dc5f13eaad59e Reuse search results fetcher a076134f0012b532b3d133036dcc5e2f8cabbb18 Make search show multiple markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6235/files/a165a6505de36839d5ba3ed3fa84c6c

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

@hlfan commented on this pull request. > - document.body.appendChild(a); - a.click(); - document.body.removeChild(a); - URL.revokeObjectURL(url); -} - -async function handleExportSuccess(fetchResponse) { - try { -const blob = await fetchResponse.response.

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

@hlfan commented on this pull request. >} function showSearchResult() { -let marker = $(this).data("marker"); - -if (!marker) { - const data = $(this).find("a.set_position").data(); - - marker = L.marker([data.lat, data.lon], { icon: OSM.getMarker({}) }); - - $(th

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

@hlfan commented on this pull request. > - document.body.appendChild(a); - a.click(); - document.body.removeChild(a); - URL.revokeObjectURL(url); -} - -async function handleExportSuccess(fetchResponse) { - try { -const blob = await fetchResponse.response.

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

hlfan left a comment (openstreetmap/openstreetmap-website#6255) I'd replace the `javascript_include_tag`s with `//= require download_util` to not bind it to the views. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6255#issuecom

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

hlfan left a comment (openstreetmap/openstreetmap-website#6255) I could see the whole thing, including handleExportSuccess and handleExportError, made into a higher-order function that's called like: ```js document.querySelector(".export_form").addEventListener("turbo:submit-end", getTurboDownlo

Re: [openstreetmap/openstreetmap-website] Add native links to HistoryChangesetsLayer (PR #6254)

@hlfan pushed 1 commit. fe604257b8831c0ada2f4e914558b841ee3ece32 Add native links to HistoryChangesetsLayer -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6254/files/794edd04b5228b40b824e96988c9eac24cebd7c8..fe604257b8831c0ada2f4e914558b841ee3ece32 You are re

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

@hlfan pushed 1 commit. a165a6505de36839d5ba3ed3fa84c6c56c2f84e7 Make search show multiple markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6235/files/b53dd21038458626b248aed4c0715af910d84be7..a165a6505de36839d5ba3ed3fa84c6c56c2f84e7 You are receiving th

[openstreetmap/openstreetmap-website] Add native links to HistoryChangesetsLayer (PR #6254)

Alternative to #6252 that closes #6252. UX difference is that this makes the URL show in the browser's status bar when hovering over a changeset bbox: You can view,

Re: [openstreetmap/openstreetmap-website] Retire jquery-simulate (PR #6252)

hlfan left a comment (openstreetmap/openstreetmap-website#6252) Ctrl and Shift click opened the changeset in a new tab resp. window for me. Where does it loose that functionality? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6

Re: [openstreetmap/openstreetmap-website] Retire jquery-simulate (PR #6252)

@hlfan approved this pull request. Works great! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6252#pullrequestreview-3056717832 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Overwrite marker shadow interactability (PR #6250)

@hlfan pushed 1 commit. 5fd60d29b5bf73525c4c6333ce338487123a8978 Overwrite marker shadow interactability -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6250/files/50f40c45af2231258971f9724ee8e23615739ba2..5fd60d29b5bf73525c4c6333ce338487123a8978 You are recei

[openstreetmap/openstreetmap-website] Use SVG marker in embed (PR #6251)

Since #6249 mentioned retina displays on the embed page, I changed my decision on whether to put the SVG marker there too. This also already overwrites the interactivity for the marker, which is tackled by #6250 for the main page. You can view, comment on, or merge this pull request online at:

[openstreetmap/openstreetmap-website] Overwrite marker shadow interactability (PR #6250)

Since Leaflet's divIcon doesn't support putting elements in the shadow pane, all `OSM.getMarker` shadows are currently interactive. This PR overwrites this behaviour. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6250

Re: [openstreetmap/openstreetmap-website] More precise marker position (PR #6249)

@hlfan approved this pull request. Ah, so on retina displays, the fractional margin _does_ show up and is not just rounded down to 12. And it also doesn't offset the marker to be rendered with pixels blended. -- Reply to this email directly or view it on GitHub: https://github.com/openstreet

Re: [openstreetmap/openstreetmap-website] Fix vector tile attribution issues (PR #6236)

@hlfan approved this pull request. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6236#pullrequestreview-3056205521 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] "HTML embedding is not available for this map layer" when selecting a vector layer (Issue #6247)

hlfan left a comment (openstreetmap/openstreetmap-website#6247) Given that the `canEmbed` configuration option is only necessary to fix #4273, that should probably be added to the [layers.yml](https://github.com/openstreetmap/openstreetmap-website/blob/master/config/layers.yml). -- Reply to th

Re: [openstreetmap/openstreetmap-website] retina compatible icons (#850)

hlfan left a comment (openstreetmap/openstreetmap-website#850) > Some markers (routing, user locations) are still pngs. They should be similar > to note markers from #4797. Is there anything left after #5854? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6192#pullrequestreview-3054471151 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@hlfan commented on this pull request. > +$("#export-image").on("turbo:submit-end", async function (event) { + if (event.detail.success) { +await handleExportSuccess(event.detail.fetchResponse); + } else { +await handleExportError(event); + } +}); jquery-s

Re: [openstreetmap/openstreetmap-website] Add multilingual language option (Issue #6244)

hlfan left a comment (openstreetmap/openstreetmap-website#6244) We have two sets of color scheme options, so why not separate localization controls? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6244#issuecomment-3114707581 Y

Re: [openstreetmap/openstreetmap-website] Fix vector tile attribution issues (PR #6236)

@hlfan requested changes on this pull request. With `L.OSM.MaplibreGL`, this should be only one commit. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6236#pullrequestreview-3052681496 You are receiving this because you are sub

Re: [openstreetmap/openstreetmap-website] Migrate new vector layers from maplibre-gl-leaflet to “unwrapped” maplibre-gl-js (Issue #6234)

hlfan left a comment (openstreetmap/openstreetmap-website#6234) > keep supporting non-WebGL-capable environments I think this argument fails at the layers pane, see #6240. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6234#is

Re: [openstreetmap/openstreetmap-website] Add XHR header to legale request (PR #6242)

@hlfan pushed 1 commit. d06d3a91bfd98455b37c3af53053860479ed788c Ensure correct checking of legale radio button -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6242/files/42fe40e1aeb5c6710567739f563614eb9b2fd121..d06d3a91bfd98455b37c3af53053860479ed788c You ar

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@hlfan commented on this pull request. > +$("#export-image").on("turbo:submit-end", async function (event) { + if (event.detail.success) { +await handleExportSuccess(event.detail.fetchResponse); + } else { +await handleExportError(event); + } +}); I don't

Re: [openstreetmap/openstreetmap-website] Contributor terms text area duplicates other website elements (Issue #6241)

hlfan left a comment (openstreetmap/openstreetmap-website#6241) > the “Rest of the world” radio button isn’t selected by default Somehow, I'm unable to reproduce this locally. There, the `@legale == legale` is doing its job. -- Reply to this email directly or view it on GitHub: https://github.

[openstreetmap/openstreetmap-website] Add XHR header to legale request (PR #6242)

Fixes #6241 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6242 -- Commit Summary -- * Add XHR header to legale request -- File Changes -- M app/assets/javascripts/user.js (2) -- Patch Links -- https://githu

[openstreetmap/openstreetmap-website] Clean up some svg-related markup (PR #6239)

Two things: - A thing I missed in #6200 that was made possible by not needing to sometimes render the definition. - A thing where the 13 minutes between the merges of #6215 and #5854 weren't enough to adapt the code to the test-drive. You can view, comment on, or merge this pull request online a

[openstreetmap/openstreetmap-website] Show marker for hidden notes (PR #6238)

Fixes #507 by adding a special marker for hidden notes. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstree

Re: [openstreetmap/openstreetmap-website] Construction sites on MapTiler OMT (Issue #6237)

hlfan left a comment (openstreetmap/openstreetmap-website#6237) Construction sites aren't in the [OpenMapTiles schema](https://openmaptiles.org/schema/#landuse). They are in [Shortbread](https://shortbread-tiles.org/schema/1.0/#features-10) and also displayed currently. -- Reply to this email

Re: [openstreetmap/openstreetmap-website] Zooming out all the way on vector layer causes glitches (Issue #6233)

hlfan left a comment (openstreetmap/openstreetmap-website#6233) See maplibre/maplibre-gl-leaflet#73 and maplibre/maplibre-gl-leaflet#82. It's probably quicker to switch back to MapLibre v<5. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-web

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

@hlfan pushed 2 commits. 885b93a53bcfb44b305fef501350697c12bb351a Reuse search results fetcher b53dd21038458626b248aed4c0715af910d84be7 Make search show multiple markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6235/files/178853d8e099c877ee7e7bd223342e5

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

@hlfan pushed 2 commits. d835840d1546700c039ffe99d7ecea3f810ffe14 Reuse search results fetcher 178853d8e099c877ee7e7bd223342e52ad8415ed Make search show multiple markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6235/files/f4bdb79b52f7bf6ea6df3e15592c93e

Re: [openstreetmap/openstreetmap-website] Fix vector tile attribution issues (PR #6236)

hlfan left a comment (openstreetmap/openstreetmap-website#6236) I think `L.OSM.MaplibreMap` would be a misnomer, since `L.OSM.Map` has the whole custom layer & object & integration logic. `L.OSM` defines itself a `L.OSM.TileLayer`, so `L.OSM.MaplibreGL` would follow that naming logic. -- Reply

Re: [openstreetmap/openstreetmap-website] Vector maps credit is not displayed in attribution (Issue #6229)

hlfan left a comment (openstreetmap/openstreetmap-website#6229) So if Leaflet doesn't care about customAttribution, could the L.OSM.Map initialize just set attribution and customAttribution? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-web

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

@hlfan commented on this pull request. > + transform: scale(1.5); + transform-origin: bottom; Yup, I forgot to re-enable my pre-commit hook that guards against tabs. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/623

Re: [openstreetmap/openstreetmap-website] Migrate new vector layers from maplibre-gl-leaflet to “unwrapped” maplibre-gl-js (Issue #6234)

hlfan left a comment (openstreetmap/openstreetmap-website#6234) > smooth zooming, a big user experience improvement that will help the map feel > more modern and responsive. Leaflet has a `zoomSnap` option, fractional zooms, and [Leaflet.SmoothWheelZoom](https://github.com/mutsuyuki/Leaflet.Smo

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

hlfan left a comment (openstreetmap/openstreetmap-website#6235) As long as the newly loaded results are after the previous list items, the index is correct. If, e.g., the internal search results load after nominatim-reverse, then these get the same color. Maybe incrementing an internal counter i

Re: [openstreetmap/openstreetmap-website] Vector layer attribution doesn't get removed when switching to another layer (Issue #6220)

hlfan left a comment (openstreetmap/openstreetmap-website#6220) Still occurs for me running af93c83f7ba717f3d7d42f8d8d8d9156d9665c7e, also locally using Docker. I've tweaked the reproduction steps to include vector layer to vector layer. -- Reply to this email directly or view it on GitHub: htt

Re: [openstreetmap/openstreetmap-website] Migrate new vector layers from maplibre-gl-leaflet to “unwrapped” maplibre-gl-js (Issue #6234)

hlfan left a comment (openstreetmap/openstreetmap-website#6234) The port to Leaflet in #121 had nearly 12k changed lines, and I think this port will be significantly bigger... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/623

Re: [openstreetmap/openstreetmap-website] Migrate new vector layers from maplibre-gl-leaflet to “unwrapped” maplibre-gl-js (Issue #6234)

hlfan left a comment (openstreetmap/openstreetmap-website#6234) How to use the just-introduced vector-based marker definitions with MapLibre is also a point I'm unsure about, considering the CSS- and DOM-driven coloring. -- Reply to this email directly or view it on GitHub: https://github.com/o

[openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

This PR improves the visualization and interactivity of search results in the sidebar and map. - Search result entries now have permanent map markers (instead of hover-only). - Each marker is assigned a unique color based on the golden angle[^1], improving distinction even with many results. - L

Re: [openstreetmap/openstreetmap-website] Add Shortbread dark mode style (PR #6213)

hlfan left a comment (openstreetmap/openstreetmap-website#6213) Anything else needed @tomhughes? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6213#issuecomment-3106911342 You are receiving this because you are subscribed to thi

Re: [openstreetmap/openstreetmap-website] Switching layers and panning can cause vector tiles to be misaligned (Issue #6226)

hlfan left a comment (openstreetmap/openstreetmap-website#6226) I've also managed to get the vector layers out of sync in a way where _neither_ panning nor zooming causes the layers to resync. Sadly, I was unable to reproduce it. -- Reply to this email directly or view it on GitHub: https://git

[openstreetmap/openstreetmap-website] Bundle vector layer maxZoom definitions in layers.yml (PR #6228)

In contrast to raster tile layers, the maxZoom for vector tile layers isn't determined by the served tiles (up to zoom level 14). Hence, the maxZoom for vector tile layers is more of an integration decision than an inherent property of the tile layer itself. Therefore, I argue, the maxZoom for ve

[openstreetmap/openstreetmap-website] Fix missing raster marker (PR #6227)

Fixes #6225 by passing the SVG marker for the `L.marker` that didn't have one already. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6227 -- Commit Summary -- * Fix missing raster marker -- File Changes -- M

Re: [openstreetmap/openstreetmap-website] Blue Marker Pin is broken (Issue #6225)

hlfan left a comment (openstreetmap/openstreetmap-website#6225) I missed explicitly setting `{ icon: OSM.getMarker({ color: "var(--marker-blue)" }) }` in `index.js` and `leaflet.share.js` in #5854. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreet

[openstreetmap/openstreetmap-website] Add play and stop markers for directions (PR #6221)

Closes #2787 by adding media control based marker variants for the directions. This is inspired by the markers from https://brouter.de/brouter-web/. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6221 -- Commit Summary

[openstreetmap/openstreetmap-website] Vector layer attribution doesn't get removed when switching to another layer (Issue #6220)

hlfan created an issue (openstreetmap/openstreetmap-website#6220) ### URL https://www.openstreetmap.org/ ### How to reproduce the issue? 1. Choose a vector layer 2. Choose a raster layer See that the old attribution remains. ### Screenshot(s) or anything else? https://github.com/user-attachm

Re: [openstreetmap/openstreetmap-website] Update "Latest diaries" icons (PR #6216)

@hlfan commented on this pull request. > @@ -0,0 +1,3 @@ +http://www.w3.org/2000/svg"; width="16" height="16" fill="currentColor" viewBox="0 0 16 16"> If I open the file in the browser standalone, I'd rather have it fill the viewport than be a speck of dust at the corner of my screen. Github'

Re: [openstreetmap/openstreetmap-website] Add static vector style dark mode switching (PR #6213)

hlfan left a comment (openstreetmap/openstreetmap-website#6213) So, now I'm happy. Gotta use the layers infrastructure that's already built. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6213#issuecomment-3104530732 You are rece

Re: [openstreetmap/openstreetmap-website] Add static vector style dark mode switching (PR #6213)

@hlfan pushed 1 commit. 5c3741fc56d78427148f3949c7b8b7fcc437cc86 Add dark Shortbread style -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6213/files/8e0016d6d71f157d44b6a95c47f0bd5ed1424ebd..5c3741fc56d78427148f3949c7b8b7fcc437cc86 You are receiving this becau

[openstreetmap/openstreetmap-website] OMT layer preview doesn't update (Issue #6219)

hlfan created an issue (openstreetmap/openstreetmap-website#6219) ### URL https://www.openstreetmap.org/ ### How to reproduce the issue? 1. Go to some place 2. Open the layers panel (all the layer previews show the same place) 3. Move the map (all but the OMT layer previews update their locatio

Re: [openstreetmap/openstreetmap-website] Add static vector style dark mode switching (PR #6213)

@hlfan pushed 1 commit. 8e0016d6d71f157d44b6a95c47f0bd5ed1424ebd Add static vector style dark mode switching -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6213/files/585b80e8678da43041d2f43288f52f90af0cac10..8e0016d6d71f157d44b6a95c47f0bd5ed1424ebd You are r

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

hlfan left a comment (openstreetmap/openstreetmap-website#5854) You bet I've looked into using `marker` elements to make (a) the result smaller and (b) remove the need for erb-ing the SVG file. And even then, it's all wrapped in a `defs` element, so you wouldn't really be able to see any preview

Re: [openstreetmap/openstreetmap-website] Add static vector style dark mode switching (PR #6213)

@hlfan pushed 1 commit. 585b80e8678da43041d2f43288f52f90af0cac10 Add static vector style dark mode switching -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6213/files/e0e718aa3b457138a33a727e5cf194b83f4b6806..585b80e8678da43041d2f43288f52f90af0cac10 You are r

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@hlfan commented on this pull request. > @@ -4,6 +4,7 @@ nameId: "standard" canEmbed: true canDownloadImage: true + formats: [png, jpeg, webp, svg, pdf] You add this for JS, but the select options are still hard-coded: ```erb <%= all_formats = @downloadable_layers.flat_map { |

[openstreetmap/openstreetmap-website] Use MediaWiki languagefallback (PR #6218)

Following the [suggestion](https://wikis.world/@LucasWerkmeister/114876146945706671) from @lucaswerkmeister to use the `languagefallback` parameter, requesting `OSM.preferred_languages` is still required to receive language variant-specific labels and descriptions. e.g., OSM has `pt-PT`, MediaW

Re: [openstreetmap/openstreetmap-website] Update "Latest diaries" icons (PR #6216)

@hlfan commented on this pull request. > @@ -0,0 +1,3 @@ +http://www.w3.org/2000/svg"; width="16" height="16" fill="currentColor" viewBox="0 0 16 16"> I see you also removed the "bi" classes that Bootstrap uses to set the icon size to the font size that would set the size for you. `xmlns` is

Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)

hlfan left a comment (openstreetmap/openstreetmap-website#6137) > You can get gigantic scale bars on any zoom level. So why limit it then? You can get gigantic scale bars on any current layer too. https://github.com/user-attachments/assets/20ace871-74b3-4b5a-93fe-b3a2a701f916"; /> -- Reply to

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

hlfan left a comment (openstreetmap/openstreetmap-website#6215) The `svg.role-icon.inactive` rule could be generalized into bootstrap-style `.fill-none`. Probably better than much custom stuff. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@hlfan commented on this pull request. > +async function handleExportSuccess(fetchResponse) { + try { +const blob = await fetchResponse.response.blob(); +const filename = OSM.i18n.t("javascripts.share.filename"); +downloadBlob(blob, filename); + } catch (err

Re: [openstreetmap/openstreetmap-website] Remove temporary debug code (PR #6217)

@hlfan pushed 1 commit. 6050ebdf427f94a3c0acad40c2e8f8c7e17fcb02 Remove temporary debug code -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6217/files/180f5c68a0d8517d96e65fbecfd6d21f1de4abad..6050ebdf427f94a3c0acad40c2e8f8c7e17fcb02 You are receiving this bec

Re: [openstreetmap/openstreetmap-website] Use Rails's logger for logging (PR #6217)

hlfan left a comment (openstreetmap/openstreetmap-website#6217) Not quite, f4e29905263efbb2eafdedad6a5c050ba559efd8 just moved it, it has been there since API 0.5 in commit 78b440ffc1e0448f8a6d73c8821dd58634ffb475. -- Reply to this email directly or view it on GitHub: https://github.com/openstr

  1   2   3   4   5   6   7   8   9   10   >