kcne left a comment (openstreetmap/openstreetmap-website#5853)
@tomhughes Just let me know if there are any policy updates to update the PR
and resolve conflicts. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5853#is
kcne left a comment (openstreetmap/openstreetmap-website#6048)
Is the heatmap not displaying on the profile, or does it appear to be a loading
issue?
I checked the code and confirmed that this section is properly localized:
```ruby
<%= t("users.show.contributions",
:count => @heatmap_data[:cou
kcne left a comment (openstreetmap/openstreetmap-website#6010)
> Thanks for the update, it's coming together! I still found a few nitpicks.
Resolved the issues. Thank you for review.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pul
@kcne commented on this pull request.
> +
+<% diary_entries.each do |entry| %>
+
+
+
+
+ http://www.w3.org/2000/svg"; width="24" height="24"
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stro
@kcne commented on this pull request.
> + <%= t(".latest_diaries") %>
+
+<% diary_entries.each do |entry| %>
+
+
+
+
+ http://www.w3.org/2000/svg"; width="24" height="24"
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="
@kcne commented on this pull request.
> @@ -0,0 +1,31 @@
+<% if diary_entries.present? %>
+ <%= t(".latest_diaries") %>
+
+<% diary_entries.each do |entry| %>
+
+
+
+
+ http://www.w3.org/2000/svg"; width="24" height="24"
viewBox="0 0 24 24
@kcne pushed 1 commit.
8f7deefadf16957cdf048711e4988a360894e6c2 Add profile diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/5132e7ffa718005a0b9f85a6ce063b5eb8f6c085..8f7deefadf16957cdf048711e4988a360894e6c2
You are receivin
kcne left a comment (openstreetmap/openstreetmap-website#6010)
> I wonder if this should go underneath the heatmap rather than above it? It
> pretty much pushes the heatmap below the fold on a laptop...
Repositioned as suggested and resolved conflicts. Let me know if some
additional changes are
@kcne pushed 1 commit.
5132e7ffa718005a0b9f85a6ce063b5eb8f6c085 Add profile diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/e00aecba8ffaaf1c596903ce8061cd04edb33202..5132e7ffa718005a0b9f85a6ce063b5eb8f6c085
You are receivin
kcne left a comment (openstreetmap/openstreetmap-website#5998)
I've noticed that the border radius of the day cells changes between desktop
and mobile — it looks slightly rounded on desktop but becomes almost
pill-shaped on mobile. If this isn’t intentional, we might want to set a fixed
border-
kcne left a comment (openstreetmap/openstreetmap-website#6010)
> If we're going to call it "Recent Diaries" should we apply some sort of date
> limit to the selection? Otherwise maybe "Latest Diaries" would be a better
> title?
Changed the naming here since latest diaries makes a bit more sense
@kcne pushed 1 commit.
e659e475229d96044e1584370427f2357f50b94f Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/efdfaedeab560e0f4189d073e253ebc653ebb899..e659e475229d96044e1584370427f2357f50b94f
You are receiving
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <%= t(".recent_diaries") %>
Certainly does. Applied. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r20904
@kcne pushed 1 commit.
270fd70b102a08f63f2d99def89c5de8226258fa Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/544532037f8a49096d7a00451cf7880cafe9d54f..270fd70b102a08f63f2d99def89c5de8226258fa
You are receiving
@kcne pushed 1 commit.
544532037f8a49096d7a00451cf7880cafe9d54f Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/e659e475229d96044e1584370427f2357f50b94f..544532037f8a49096d7a00451cf7880cafe9d54f
You are receiving
@kcne commented on this pull request.
On app/views/diary_entries/_profile_diaries.html.erb:
Refactored. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r2090489793
You are receiving this because you a
@kcne commented on this pull request.
> +<% diary_entries.each do |entry| %>
+
+
+
+
+ <%= image_tag "note.svg", :class => "card-icon", :alt => "Note"
%>
+ <%= link_to entry.title, diary_entry_path(@user, entry) %>
+
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <%= t(".recent_diaries") %>
+
+<% diary_entries.each do |entry| %>
+
+
+
+
+ <%= image_tag "note.svg", :class => "card-icon", :alt => "Note"
%>
+
@kcne pushed 1 commit.
efdfaedeab560e0f4189d073e253ebc653ebb899 Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/b863bccd180438277586edb87e82bc37b0810440..efdfaedeab560e0f4189d073e253ebc653ebb899
You are receiving
@kcne pushed 1 commit.
2e88bafaf438a85e1df7d77ff6b332ec871cf237 Add yearly template to localize start
of the week and end the heatmap on todays date.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5906/files/f3a27c1a01472faef9ab8c808c20c2f095dd033a..2e88bafaf
@kcne pushed 1 commit.
b863bccd180438277586edb87e82bc37b0810440 Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/1c98dfab8f6abb23b8014100d11704b74307251f..b863bccd180438277586edb87e82bc37b0810440
You are receiving