@tomhughes pushed 1 commit.
a4bd30b24219e13f487adcbb96ac086f0c6083dd Limit diary comments to 64Kb
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6047/files/f09cede3ba22a6b3260c69b184700c5cf89735c2..a4bd30b24219e13f487adcbb96ac086f0c6083dd
You are receiving thi
tomhughes left a comment (openstreetmap/openstreetmap-website#6048)
Well that wasn't the question asked... We don't actually know how he produced
that image so until he actually says that he's expecting the image and it's
missing I don't see that we have a proven bug.
--
Reply to this email di
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6048)
I think we should try to find why Maro does not see the map.
Do you have a special plugin in your browser?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6
tomhughes left a comment (openstreetmap/openstreetmap-website#6048)
You can't remove it because it's part of the page layout, not user content.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6048#issuecomment-2905843866
You are
hlfan left a comment (openstreetmap/openstreetmap-website#6046)
> if it would be possible to reserve a fixed space up front for the frame to
> fill
The old SVG version had a fixed height, but now with it being responsive it's
more complicated, but with min-height, max-height and an em-based hei
Closed #6048 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6048#event-17796516386
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
hlfan left a comment (openstreetmap/openstreetmap-website#6048)
The missing translation is a duplicate of #6036.
But if the heading is there, then the heatmap should also render, which is the
strange part of the screenshot.
--
Reply to this email directly or view it on GitHub:
https://github.co
kcne left a comment (openstreetmap/openstreetmap-website#6048)
Is the heatmap not displaying on the profile, or does it appear to be a loading
issue?
I checked the code and confirmed that this section is properly localized:
```ruby
<%= t("users.show.contributions",
:count => @heatmap_data[:cou
maro-21 created an issue (openstreetmap/openstreetmap-website#6048)
Since a month there is a text in English "xxx contributions in the last year"
in my profile and I don't know how to remove it. After clicking "Edit profile"
there is a blank text field.
Looks good to me, thanks.
Upside is that if there is any problem constructing the heat map, or it's slow,
then the rest of the page will still load.
Only downside is the stuff below the heat map loading when it finishes loadin
Merged #6046 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6046#event-17793328170
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#5956)
But you still want a tooltip?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956#issuecomment-2905016350
You are receiving this because you are subscribed to this
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5956)
Weren't we trying to remove unnecessary controls like the *Go* button?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956#issuecomment-2904947211
You are rece
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6046
-- Commit Summary --
* Test if max_id is present in heatmap data
* Split heatmap rendering test
* Move heatmap to Turbo frame
* Move heatmaps controller tes
@Firefishy pushed 1 commit.
71027c46a0598066b3cf6642d57eaeef37d8faf6 Add additional common SPAMMY_PHRASES
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6044/files/f3acc9d1cebb50182332a442b0eb0bfc09c5c1b1..71027c46a0598066b3cf6642d57eaeef37d8faf6
You are recei
wolfgang-8 created an issue (openstreetmap/openstreetmap-website#6045)
### URL
https://www.openstreetmap.org/note/4678312
### How to reproduce the issue?
For example, the shared osm link within this
[note](https://www.openstreetmap.org/note/4678312) doesn't show a blue marker
on the map. The
@hlfan commented on this pull request.
> @@ -216,6 +216,8 @@ OSM.Directions = function (map) {
endpoints[0].enableListeners();
endpoints[1].enableListeners();
+
+endpoints[0].focusInput();
Well then how about focusing only when reasonable?
```suggestion
if (!endpoints[0].val
tomhughes left a comment (openstreetmap/openstreetmap-website#6044)
I've no idea what I was thinking when I added that blacklist in 12d3f94e3c but
I really don't want to be going down the route of playing whackamole in this
repository.
--
Reply to this email directly or view it on GitHub:
http
### Description
Add additional spam phrases to catch additional spam profiles.
### How has this been tested?
TBC
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6044
-- Commit Summary --
* Add additional common SPAM
hlfan left a comment (openstreetmap/openstreetmap-website#5956)
@HolgerJeromin I put the info circle (this time really a bootstrap icon svg)
next to the select:
Is this better?
--
Reply to this email direc
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6042)
Autofocus attribute on page load doesn't cause the keyboard to pop up,
javascript focus does.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6042#issuecomment
@hlfan pushed 1 commit.
b5c180c4eb1f109c6b06ce7bdbbf90e1cd2d625b Add routing provider tips
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956/files/b2dd49d24809936246db195d8f26b15832dc6771..b5c180c4eb1f109c6b06ce7bdbbf90e1cd2d625b
You are receiving this becau
@hlfan pushed 1 commit.
b2dd49d24809936246db195d8f26b15832dc6771 Add routing provider tips
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956/files/5d3ecb172c7b44e7d89c442ad549534a3902e8fa..b2dd49d24809936246db195d8f26b15832dc6771
You are receiving this becau
@hlfan pushed 1 commit.
5d3ecb172c7b44e7d89c442ad549534a3902e8fa Add routing provider tips
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956/files/2b9f974c3a2df67a434c88ad584c8ffac136ed26..5d3ecb172c7b44e7d89c442ad549534a3902e8fa
You are receiving this becau
@hlfan pushed 1 commit.
2b9f974c3a2df67a434c88ad584c8ffac136ed26 Add routing provider tips
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956/files/9ec68c0528bf264d312d330444188ce0183352a9..2b9f974c3a2df67a434c88ad584c8ffac136ed26
You are receiving this becau
@hlfan pushed 5 commits.
775625c07fd1f2f918a9b4dca9bfc50d16ebdd81 Add InlineSvg module
1b2ee4bd1e589b34e0f9826fee213759a394db78 Inline search icons with helper
ea58b886ff07eaa76ee2bdc89d6284b2f6c82908 Inline about icons with helper
39370bdca2e4242f930df4e3fb2dbafa8a34b6f3 Inline welcome icons
@hlfan pushed 4 commits.
936ec9fc8ba0907a845773c9bbc02c4c5a897aa6 Use common note marker definitions
deb0bf5c1e3a979baa7d3b8d0ad88e8f6c414f11 Generalize leaflet-marker-icon
selector
239e496ade4d39f818b3e1ab8092d7b5d8f452e4 Update and inline markers
bd0668343c4faf48ff7b03948d32a0abd9501394 Cle
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5439)
This got too clever with *label of hidden checkbox styled as a button* with
consequences for keyboard navigation.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pu
@hlfan pushed 1 commit.
56d23ffaf1612bd6920ad61c57d7a6a3e761ea32 Convert leaflet markers to SVG
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/04029c8e3c8af9894011c08e2d1acc0990d01ec4..56d23ffaf1612bd6920ad61c57d7a6a3e761ea32
You are receiving this
tomhughes left a comment (openstreetmap/openstreetmap-website#6042)
Does the focusing of the search box on page load causes issues on phones then?
or do we only do that on desktop?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6040)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6040#issuecomment-2904160015
You are receiving this because you are subscribed to this thread.
Merged #6040 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6040#event-17788584726
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6042)
Do you want more virual keyboard issues on phones?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6042#issuecomment-2904051761
You are receiving this because y
@hlfan pushed 1 commit.
ccd0a5b80cec16411947becc39e0dd2c575d8382 Use same logic for feature names
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6037/files/327daa6fee641baf1347c74f0f7d464430027280..ccd0a5b80cec16411947becc39e0dd2c575d8382
You are receiving thi
@hlfan pushed 1 commit.
bfce1118549636e08d88d8a698c4d5885ea86916 Use same logic for feature names
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6037/files/ccd0a5b80cec16411947becc39e0dd2c575d8382..bfce1118549636e08d88d8a698c4d5885ea86916
You are receiving thi
@hlfan commented on this pull request.
> - return tags["addr:housenumber"] + " " + tags["addr:street"];
+ return OSM.i18n.t(
+"javascripts.query.address",
+{ housenumber: tags["addr:housenumber"], street: tags["addr:street"] }
+ );
Fair point. It has to be made pr
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6042#pullrequestreview-2863594609
You are receiving this because you are subscribed to this thread.
Message ID:
__
38 matches
Mail list logo
