mnalis left a comment (openstreetmap/openstreetmap-website#5904)
**TL;DR:** great for adding support for adding/changing (optional) tags on
notes, as well as (optional) extra API params / website changes to filter by
them; but please no mutable note texts/coordinates - it would be quite
problem
hlfan left a comment (openstreetmap/openstreetmap-website#5998)
For now, I've stopped just short of CLDR-dependent stuff using `Intl.locale`.
But the [TwitterCldr](https://github.com/twitter/twitter-cldr-rb) gem seems to
have the necessary information to move everything to Ruby.
--
Reply to th
karussell left a comment (openstreetmap/openstreetmap-website#6011)
Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6011#issuecomment-2877766376
You are receiving this because you are subscribed to this thread.
Message ID
@tomhughes commented on this pull request.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
The `shared.language_selector` part of the key is also unnecessary I th
tomhughes left a comment (openstreetmap/openstreetmap-website#5998)
With this approach is the javascript actually doing anything that couldn't be
done in the rails rendering on the server?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
Merged #6011 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6011#event-17639899950
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6010)
If we're going to call it "Recent Diaries" should we apply some sort of date
limit to the selection? Otherwise maybe "Latest Diaries" would be a better
title?
--
Reply to this email directly or view it on GitHub:
https://githu
tomhughes left a comment (openstreetmap/openstreetmap-website#6011)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6011#issuecomment-2877385146
You are receiving this because you are subscribed to this t
@1ec5 commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+ <% e
@1ec5 commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+ <% e
@AntonKhorev commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+
@hlfan commented on this pull request.
On app/views/diary_entries/_profile_diaries.html.erb:
If you inline the svg icons, you can use currentColor and don't need a filter
to invert the icons.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap
karussell left a comment (openstreetmap/openstreetmap-website#6011)
Have done so.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6011#issuecomment-2876046130
You are receiving this because you are subscribed to this thread.
Mess
@tomhughes requested changes on this pull request.
Please squash the second fixup commit into the first one.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6011#pullrequestreview-2835997818
You are receiving this because you ar
@karussell pushed 1 commit.
0c12b1158ad587a1ac74b22e4e30a8e6c3e2b040 Update graphhopper.js
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6011/files/d8eb6ad4366b50dd51958979b5cc06d99971d2ec..0c12b1158ad587a1ac74b22e4e30a8e6c3e2b040
You are receiving this becau
There are some minor updates to the latest GraphHopper API e.g. `vehicle` was
deprecated a few years ago.
Also there is no longer a need for the parameter `turn_costs` (related #2695).
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetma
@kcne pushed 1 commit.
efdfaedeab560e0f4189d073e253ebc653ebb899 Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/b863bccd180438277586edb87e82bc37b0810440..efdfaedeab560e0f4189d073e253ebc653ebb899
You are receiving
@1ec5 commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+ <% e
@AntonKhorev commented on this pull request.
> + gl: Galician
+ gsw: Alemannic (specifically Swiss German, Alsatian)
+ gu: Gujarati
+ he: Hebrew
+ hi: Hindi
+ hr: Croatian
+ hsb: Sorbian, Upper
+ hu: Hungarian
+ ia: Interlingua
+ id: Indonesian
+
@kcne pushed 1 commit.
2e88bafaf438a85e1df7d77ff6b332ec871cf237 Add yearly template to localize start
of the week and end the heatmap on todays date.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5906/files/f3a27c1a01472faef9ab8c808c20c2f095dd033a..2e88bafaf
@kcne pushed 1 commit.
b863bccd180438277586edb87e82bc37b0810440 Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/1c98dfab8f6abb23b8014100d11704b74307251f..b863bccd180438277586edb87e82bc37b0810440
You are receiving