Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)

HarelM left a comment (openstreetmap/openstreetmap-website#2799) That's partially true. Implementing this will reduce the friction, and allow a smoother review of my app, that uses OSM as the provider for user login. Since my app is basically a webview wrapped in native code, adding this feature

Re: [openstreetmap/openstreetmap-website] Add headline to heatmap (PR #5976)

@AntonKhorev commented on this pull request. > + + + <%= t(".contributions", :count => @changes_count) %> + + You don't need `row`/`col` here, you need ``. (heatmap probably also doesn't need `row`/`col`) -- Reply to this email directly or view it on GitHub: https://github.c

[openstreetmap/openstreetmap-website] Directions resource (PR #5978)

- changes the `/directions` route to a resource - renames the `directions#search` action to a standard `show` action - removes RuboCop's exception for action names of directions controller You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreet

Re: [openstreetmap/openstreetmap-website] API changeset upload resource (PR #5977)

github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5977) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

Closed #5590. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590#event-17509183710 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] API changeset upload resource (PR #5977)

Folows #5965. Finishes API changeset resources refactor. Converts [diff upload](https://wiki.openstreetmap.org/wiki/API_v0.6#Diff_upload:_POST_/api/0.6/changeset/#id/upload) action of api changeset controller into its own recource/controller. The PR consists mostly of moving and rewriting tests

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 1 commit. 6482d373bebab09547b5f0067688af576fbedef3 Move api changeset upload-download tests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/3f6aeb1918069bb1c8b6796f97632183c3a6049b..6482d373bebab09547b5f0067688af576fbedef3 You ar

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 12 commits. 54b5b80183c14c923891b5218f05bbcc4f9eef3a Split and move api changeset test_upload_simple_valid 40724cbf6a7dfe47f1120cd90f35c7a7cc90563f Test scopes for api changeset upload 3d240ef75fc8ea35355233c3d3f947edf30f6499 Move api changeset upload create tests 231f08373

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 1 commit. 831f5fb21d4c19e3d0eae0f07f18cf2aae174816 Move api changeset upload bbox tests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/aaafce80fca523cc14ffc896a37127d4fb134268..831f5fb21d4c19e3d0eae0f07f18cf2aae174816 You are rec

Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)

pnorman left a comment (openstreetmap/openstreetmap-website#2799) This issue is about adding a another login provider to osm.org and isn't for your app. Your app can't tell how someone logged in to osm.org as all it will know is oauth2 credentials -- Reply to this email directly or view it on

Re: [openstreetmap/openstreetmap-website] Add headline to heatmap (PR #5976)

@rkoeze pushed 1 commit. 6cb6c5f6bacc9f07480a9786f3dfc1007122f328 Add headline to heatmap -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5976/files/6afaafe38f66c17161bf0e57629c233c06eb48fb..6cb6c5f6bacc9f07480a9786f3dfc1007122f328 You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] Add headline to heatmap (PR #5976)

@rkoeze pushed 1 commit. 6afaafe38f66c17161bf0e57629c233c06eb48fb Add headline to heatmap -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5976/files/2f3ab13b7b395d50b2185ea6e1e5df82439412a1..6afaafe38f66c17161bf0e57629c233c06eb48fb You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 1 commit. aaafce80fca523cc14ffc896a37127d4fb134268 Move api changeset upload rate/size limit tests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/f81b7bd7e10313980ce451779849907427af38fa..aaafce80fca523cc14ffc896a37127d4fb134268

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 7 commits. 7eef8582fcc62bf5072037b9bbaf6da1b82fb690 Move api changeset upload delete tests 73a3ac3b5df048a2eea0ad141e8e55432df98b03 Move api changeset upload modify tests fe3898f0a618e317d7db5d262131be8a739deece Move api changeset upload unknown action test edd7b68c0c9016ba

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 8 commits. 078c892ddad6a5f419f2e8d719319aa25a5dbaf7 Move api changeset upload create tests 315ada88c25c286e10bd29866107a8d157d38537 Move api changeset upload delete tests 198e25be60821a0b218733368b6bfa21ded7454d Move api changeset upload modify tests 31726ae838e12737c9a9b508

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 1 commit. 4ea980c47fea94aa1856464bf21fb0e9b9ca4b9d Refactor api changeset test_upload_not_found -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/2fe3a6b62ebf83fc5674e1f41d205db2df7c737c..4ea980c47fea94aa1856464bf21fb0e9b9ca4b9d Yo

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 2 commits. fa1f16b8a3afff6d7e5f7fbbf75cd99bea2a406e Move api empty changeset upload test 2fe3a6b62ebf83fc5674e1f41d205db2df7c737c Move api changeset upload xml error test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/94aeb59e8

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 5 commits. 37ea90e2733ab4c47e2b0329c48f6aff99422c81 Move api changeset upload create tests 60870cb1b810eca67077bf5504975e15c9b6e8eb Move api changeset upload delete tests eb698402b5a08f5d55546c139cf0f8942d729683 Move api changeset upload modify tests 6ee8016a5fdd818b902e5291

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 5 commits. 306e8ad77e1c4aa6a1b5b53abcb2d60aaf316d04 Move api changeset upload create tests 767c7cf4005efb491bdf8949065a481371161b12 Move api changeset upload delete tests 3424c835dd99a6629e05ad236dbb63042a0274d6 Move api changeset upload modify tests 3a0872fc980a00d69f21295a

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 10 commits. bfef57f2ac82c9a59a372228f6b2c47545166384 Create api changeset upload resource a0c0ce1428cc03bb1f648e803895f4d7d0b72b09 Remove unnecessary RuboCop exclusions c0dde875d4949f9615ee34d19486fd481e9f0b33 Move api changeset upload route test d70b9dcc37c0c367a2e916fa05c4

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 9 commits. 5151769bfbadf9e295eb05f3a4fa2682a618f851 Create api changeset upload resource 8300adc4a1125f204eb23bfad2b1d10c87196680 Remove unnecessary RuboCop exclusions e31c72b00fe29c7978768d822864cd3b6987ff12 Move api changeset upload route test f3e53a50371fca8eef8cf9ba706ae

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@hlfan pushed 2 commits. cdc04909b7e5173c4496804efd2cca55425d532a Update and inline markers 0d339d407a37a5679f1a8aa89bc39b3d2a7b86f0 Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/4c5433fbddc82684db802aa7b936c7025111bbd4..0d339

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@hlfan pushed 2 commits. 7831a2fe729ce592119fc2c09d8909119806ed2e Update and inline markers 4c5433fbddc82684db802aa7b936c7025111bbd4 Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/2d75db92d74b5f5635883a171da64f66e6d7e585..4c543

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

hlfan left a comment (openstreetmap/openstreetmap-website#5854) Maybe a central dict in getMarker? That would also account for unifying the colors. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854#issuecomment-2848658728 You

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

tomhughes left a comment (openstreetmap/openstreetmap-website#5854) The only other thing that struck me was the various hex colour constants scattered around but I'm not sure there's any good way to centralise them. -- Reply to this email directly or view it on GitHub: https://github.com/openst

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

tomhughes left a comment (openstreetmap/openstreetmap-website#5854) I couldn't see that much of a difference to be honest - there was a bit of one with the routing markers but nothing terrible. I know this overlaps with work @AntonKhorev has been doing though which is why I've asked him to revi

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

hlfan left a comment (openstreetmap/openstreetmap-website#5854) @tomhughes do you think it's better to match the current marker colors more closely or to reduce variations in color (only have one green, one red...)? -- Reply to this email directly or view it on GitHub: https://github.com/openst

Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.25.1 to 9.26.0 (PR #5975)

Merged #5975 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5975#event-17507860484 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add headline to heatmap (PR #5976)

@tomhughes requested changes on this pull request. Please squash at least the first three commits together - the tests can be a separate commit if you prefer or you can just squash everything into one. > @@ -238,6 +238,11 @@ <%= @user.description.to_html %> <% if @heatmap_data.present? %> +

[openstreetmap/openstreetmap-website] Add headline to heatmap (PR #5976)

### Description Adds dynamic headline to heatmap. Addresses https://github.com/openstreetmap/openstreetmap-website/issues/5810. ### How has this