@HarelM commented on this pull request.
> +assert_equal trace1.id, js["traces"][0]["id"]
+assert_equal trace2.id, js["traces"][1]["id"]
Added checks.
Let me know if anything is missing.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
@HarelM pushed 1 commit.
2dfd922598c216aafbbed7257578a5b8704a6dca Add tags testing to json
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943/files/b5bcdba346fc5239acde1e4326db6f8683680c57..2dfd922598c216aafbbed7257578a5b8704a6dca
You are receiving this becau
@HarelM pushed 1 commit.
b5bcdba346fc5239acde1e4326db6f8683680c57 Update
app/controllers/api/traces_controller.rb
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943/files/1c7cad22805e5aa6806b69e17d12e19fe8dc365c..b5bcdba346fc5239acde1e4326db6f8683680c57
You
@HarelM pushed 1 commit.
f68891fc0b865c0feb4ec78d640528feb71ec25f Apply suggestions from code review
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943/files/bd886baa110042deef226f01ada411960a1a2d74..f68891fc0b865c0feb4ec78d640528feb71ec25f
You are receiving
@hlfan approved this pull request.
Looks good, only noted some minor ideas
> + if @trace.public? || @trace.user == current_user
+respond_to do |format|
+ format.xml
+ format.json
+end
+ else
+head :forbidden
+ end
```suggestion
retur
ppKrauss left a comment (openstreetmap/openstreetmap-website#1807)
**Solution** proposal: use another [domain
name](https://en.wikipedia.org/wiki/Domain_name), and redirect the *geocode
resolution* to OpenStreetMap (or others like [Wikipedia's
Geohack](https://geohack.toolforge.org/geohack.php?
HarelM left a comment (openstreetmap/openstreetmap-website#5943)
I kept the traces as and array of objects, each one of them a trace, but
without the `{ trace: { ... } }`, was your comment about including the `trace`
property for every trace in the array intentional?
Regardless, this is now rea
@HarelM pushed 1 commit.
10d9ede3b85b31f699826fcd7f8b7aa72ae28f26 Fix typo in show json.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943/files/3282a4cf3c0ba08b91930ecc26a84aa7a1632524..10d9ede3b85b31f699826fcd7f8b7aa72ae28f26
You are receiving this because
HarelM left a comment (openstreetmap/openstreetmap-website#5943)
I've changed the structure according to what suggested.
Sorry for being a noob :-/
Unfortunately, when running the docker CI code on my mac not all the tests
pass, so I'm having a hard time running the tests locally before I commit.
@HarelM pushed 1 commit.
3282a4cf3c0ba08b91930ecc26a84aa7a1632524 Change json structure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943/files/f68891fc0b865c0feb4ec78d640528feb71ec25f..3282a4cf3c0ba08b91930ecc26a84aa7a1632524
You are receiving this because
tomhughes left a comment (openstreetmap/openstreetmap-website#5943)
The top level boilerplate can be added with:
```ruby
json.partial! "api/root_attributes"
```
which you'll find in other json.builder views.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
HarelM left a comment (openstreetmap/openstreetmap-website#5943)
Thanks for the info! I'll look into aligning those so that it will return in a
similar way.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943#issuecomment-282511
@tomhughes requested changes on this pull request.
The changes I've suggested fix the failing tests, but they also reveal a
problem as they show that the structure of the JSON returned by the two methods
is not consistent - one has a top level hash with a `osm` member pointing at
the details an
HarelM left a comment (openstreetmap/openstreetmap-website#5943)
These cycles are too long, I'll work on trying to run this locally and make
sure the tests pass...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943#issuecomment
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#2882)
> And maybe a bit off topic, but it might be worth having different types of
> icons for different "types" of Notes.
ref for tags on notes #5294
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
The-Nickname left a comment (openstreetmap/openstreetmap-website#2882)
> I propose changing the note to a yellow exclamation mark, and keeping the
> resolved note as a green tick.
Or maybe a yellow question mark, since somebody did probably ask a question.
And maybe a bit off topic,
but it
16 matches
Mail list logo
