pwbriggs left a comment (openstreetmap/openstreetmap-website#2629)
> The issue with links is more that once you add one everybody will want links
> to their own favourite tools adding.
I know this is an old issue, but reading this gave me an idea: why *don't* we
make a way for there to be links
@rkoeze approved this pull request.
Perused the changelogs for
[omniauth](https://github.com/omniauth/omniauth/releases) and
[Puma](https://github.com/puma/puma/releases?page=1). Didn't see anything
worrisome in the former. The latter was pretty big given that we're bumping a
major version.
@AntonKhorev pushed 2 commits.
52a7624b8b98f36fa71965d4e2e9b824c1bd1d4b Take viewport intersection into
account when sorting changesets
5061c70b4007f1684ad38503f5b6eb940d04fb59 Add color hint bars around changesets
list
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-web
On history pages, if you load many changesets and look at the map, it's
difficult to find the corresponding changesets in the sidebar. The idea here is
to color changesets differently, depending on whether they are above/in/below
the sidebar viewport.
- The orange color that was previously used
@tomhughes pushed 4 commits.
045e305d8bc0967251bcb1d420e03674fed2b8ec Update to omniauth 2.1, puma 6 and
rack 3
3bd56383b893006916bf67d4399f15667299d74c Handle request objects with no body
86d5a5c50e17444adee4106966d51ab43eafc319 Pass correct headers to POST requests
9fbeb37689f1ae8955e00cad01
@tomhughes pushed 3 commits.
8fcdb3be60650ed89cd5b457e3df4de7ecf10d87 Update to omniauth 2.1, puma 6 and
rack 3
1418186493e27a2a02e55bdb22c1833b6433858e Handle request objects with no body
6a4806ee523f1e4b5c50c7963fae9a9e28b37b72 Pass correct headers to POST requests
--
View it on GitHub:
ht
This updates to rack 3 which was blocked by omniauth being locked to 2.0 so
this updates omniauth to 2.1 which unlocks the rack 3 update which in turn
requires a puma update.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/
@hlfan commented on this pull request.
> + let distanceUnits = "km";
let downloadURL = null;
- function formatTotalDistance(m) {
-if (m < 1000) {
- return OSM.i18n.t("javascripts.directions.distance_m", { distance:
Math.round(m) });
-} else if (m < 1) {
- return OSM
Closed #5919 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5919#event-17229352824
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
deevroman left a comment (openstreetmap/openstreetmap-website#5919)
Yes, it seems so. I can reliably reproduce this bug if I enable network
throttling. Surprisingly, it results in zoom reset, rather than zooming in to
some bbox at the same zoom.
--
Reply to this email directly or view it on Gi
Dimitar created an issue (openstreetmap/openstreetmap-website#5922)
### Problem
Currently when you upload a new profile picture, the old one is shown on the
left. When changing the selected option, nothing on the left side changes. Due
to the fact that the image is quite small, it's not alw
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
Changed to 0.25.
--
Reply to this email directl
@AntonKhorev pushed 2 commits.
39f67c5d00de95c02c193c0c7b677b258eb013ce Prepare distance formatting for unit
translations
932036f3467c30958738620e0857cc29acb52197 Enable km/mi switching in directions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915/files/
@1ec5 commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
That would seem more reasonable to me. 👍
--
Reply to t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5919)
Likely a duplicate of #2502. The loading is not aborted correctly yet.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5919#issuecomment-2797544527
You are re
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
> They tend to start seeing miles at either 0.1 m
@1ec5 commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
> You mean at 0.1 miles?
Yep, that was a typo, fixed. T
Test for #5917.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5921
-- Commit Summary --
* Test if history shows changesets at expected locations
-- File Changes --
M test/system/history_test.rb (10)
-- Patch
Test for #5916.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5920
-- Commit Summary --
* Test if 'Show address' includes zoom parameter
-- File Changes --
M test/system/search_test.rb (31)
-- Patch Links --
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
I'm not doing 0.1 miles because it's going to one
@AntonKhorev commented on this pull request.
> URL.revokeObjectURL(downloadURL);
downloadURL = URL.createObjectURL(blob);
+$("#directions_route_download").prop("href", downloadURL);
I'm saying that it's not a string variable that preserves the value you put in
it.
--
Reply to t
@AntonKhorev pushed 9 commits.
a81680355d96dee10a351e3fbb9b16cd97686409 Show/hide directions spinner instead
of copying
f2e8e7ac70ee4da25c606d8a3bebcdfef95bdca2 Use different divs for directions
error and route outputs
94cf122e93b2ce1079071a66e61849cb3490eec5 Write most of route html using er
@nertc commented on this pull request.
> @@ -2,7 +2,10 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html
%>
+<% if tru
@hlfan commented on this pull request.
> URL.revokeObjectURL(downloadURL);
downloadURL = URL.createObjectURL(blob);
+$("#directions_route_download").prop("href", downloadURL);
And it can do the job of `downloadURL` too since you preserve the DOM starting
with 9e908a00b0f7d7c4ffbb
@hlfan commented on this pull request.
> + const miSize = 1609.344;
+ const ftSize = 0.3048;
+
function formatTotalDistance(m) {
-if (m < 1000) {
- return OSM.i18n.t("javascripts.directions.distance_m", { distance:
Math.round(m) });
-} else if (m < 1) {
- return OSM.i
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
We have two different m-km boundaries:
1. The fi
deevroman created an issue (openstreetmap/openstreetmap-website#5919)
### URL
_No response_
### How to reproduce the issue?
1. Open openstreetmap.org/history
2. Change the zoom of the map by scrolling (it doesn't matter if you zoom in or
out)
3. Quickly close the sidebar by clicking on the cro
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
0.1 miles is where Google Maps are switching. The
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
> 528 feet = 1 mile
You mean at 0.1 miles? That'
@AntonKhorev commented on this pull request.
> URL.revokeObjectURL(downloadURL);
downloadURL = URL.createObjectURL(blob);
+$("#directions_route_download").prop("href", downloadURL);
The `href` property does more than just storing/returning a string.
--
Reply to this email direct
@hlfan commented on this pull request.
> URL.revokeObjectURL(downloadURL);
downloadURL = URL.createObjectURL(blob);
+$("#directions_route_download").prop("href", downloadURL);
If you have the DOM anyway you can drop `downloadURL`
```suggestion
URL.revokeObjectURL(downloadLink
31 matches
Mail list logo
