Re: [openstreetmap/openstreetmap-website] Add OSRM support for right u-turn (PR #5777)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5777) Making a wrong decision [_sometimes_](https://www.youtube.com/watch?v=GiYO1TObNz8) is still better than systematically ignoring a choice and being wrong in left-driving countries the whole time. -- Reply to this email directly or

[openstreetmap/openstreetmap-website] API changeset subscription resource (PR #5801)

2025-03-14 Thread Anton Khorev via rails-dev
Similar to web changeset subscriptions https://github.com/openstreetmap/openstreetmap-website/pull/5535, but for the api. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5801 -- Commit Summary -- * Create api chang

Re: [openstreetmap/openstreetmap-website] Add OSRM support for right u-turn (PR #5777)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5777) It still fails in places like [here](https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=53.411809%2C-2.965858%3B53.412402%2C-2.966225), where that step has: ```json { "maneuver": { "bearing_after": 261,

Re: [openstreetmap/openstreetmap-website] Add OSRM support for right u-turn (PR #5777)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5777) So should I replace the working bearing-based implementation with a non-working one based on `driving_side` just because it's the intended way? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/

Re: [openstreetmap/openstreetmap-website] Add OSRM support for right u-turn (PR #5777)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 2db8892dc5f1b3fd2248265c9a06e472b825db23 Make left u-turns the default for 180 degree bearing changes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5777/files/e7db3420dc6fa8a1d34e45a99c12c6f9255e6a89..2db8892dc5f1b3fd2248265c9a06e472b

Re: [openstreetmap/openstreetmap-website] Fix wget command for Windows installation guide (PR #5803)

2025-03-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5803) I'm not sure we can turn the documentation into a tutorial for the quirks of each individual operating system... If wget isn't downloading to the current directory by default then where is is downloading to? Maybe that's a bug t

[openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-14 Thread Minh Nguyễn via rails-dev
1ec5 created an issue (openstreetmap/openstreetmap-website#5802) The horizontal axis on the user contribution heatmap is off by a month. Each label across the top appears to be centered over the following month. For example, if you’ll excuse me showing off my own profile: https://github.com/use

Re: [openstreetmap/openstreetmap-website] Add OSRM support for right u-turn (PR #5777)

2025-03-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5777) > working bearing-based implementation ![image](https://github.com/user-attachments/assets/bf6dc53d-0813-4e38-b54c-ed90e63472d4) [[place]](https://www.openstreetmap.org/#map=19/51.195720/4.501449) It's not uncommon for the dif

Re: [openstreetmap/openstreetmap-website] Fix wget command for Windows installation guide (PR #5803)

2025-03-14 Thread Ngoc Linh Le via rails-dev
linhle15-ll left a comment (openstreetmap/openstreetmap-website#5803) Thank you for getting back to me! By the way, I am considering applying for Open Street Map in the Google Summer of Code. Do you have any suggestions on things I should do or write about in my proposal? I am very excited to mak

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757) > For what reason? GDPR, for example, if implemented in stages with the first stage removing the comments. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5

Re: [openstreetmap/openstreetmap-website] Feature request: Current search result as value for "Find directions between two points" option? (Issue #3651)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#3651) Resolved by https://github.com/openstreetmap/openstreetmap-website/pull/5710 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3651#issuecomment-2725820487 You are re

Re: [openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-14 Thread Emin Kocan via rails-dev
kcne left a comment (openstreetmap/openstreetmap-website#5802) The rendering of month labels and popup is handled by the js library in 'heatmap.js'. Can you provide the exact link to the profile so I can look into it and try to resolve the issue? Thank you. -- Reply to this email directly or v

Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

2025-03-14 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. >mapParams = {}; +[geoURI.coordstring, ...geoURI.params] = geoURI.pathname.split(";"); +geoURI.params = Object.fromEntries([...geoURI.searchParams, ...geoURI.params.flatMap(l => [...new URLSearchParams(l)])]); If you're going t

Re: [openstreetmap/openstreetmap-website] Fix wget command for Windows installation guide (PR #5803)

2025-03-14 Thread Ngoc Linh Le via rails-dev
linhle15-ll left a comment (openstreetmap/openstreetmap-website#5803) Hope this help Window users (I use Window 11). -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5803#issuecomment-2725646951 You are receiving this because you a

[openstreetmap/openstreetmap-website] Fix wget command for Windows installation guide (PR #5803)

2025-03-14 Thread Ngoc Linh Le via rails-dev
### Description In Window Shell, I directed to `cd openstreetmap-website` > `ls` but cannot see data file for District of Columbia although the download StatusCode : 200 and StatusDescription : OK. Added a note in DOCKER.md for Windows users regarding potential issues when downloading OSM extra

Re: [openstreetmap/openstreetmap-website] Search forms redesign (#3123)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#3123) So what is still left of the issues? IMO the current state is this: >- [ ] selecting a search result clears the search field >- [x] pressing the "directions" icon also clears the search field >- [x] button to reverse directions is vis

Re: [openstreetmap/openstreetmap-website] opening https://www.openstreetmap.org/way/12432594/ link does not center map where way is (Issue #5798)

2025-03-14 Thread DaveF63 via rails-dev
DaveF63 left a comment (openstreetmap/openstreetmap-website#5798) Quality control on this website is, once again, lacking. Beta testing appears non existent. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5798#issuecomment-272

Re: [openstreetmap/openstreetmap-website] Overhaul markers (PR #5764)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 2 commits. c1f337a895ea475be23b9ddf3f1d64983f885eca Name markers uniformly 9197668276d899726ead8b00802f06fd50e2488e Overhaul markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/de43fe58a2f19da24f83a8f400267a21e899a9d3..9197668276d8

Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

2025-03-14 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 7fb4fb7663524893340b30710283d605915b508a Add PWA geo protocol handler -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/cb64248095588834fdf419f7ebe7ee3dc8be0ba6..7fb4fb7663524893340b30710283d605915b508a You are receiving this be

Re: [openstreetmap/openstreetmap-website] API changeset subscription resource (PR #5801)

2025-03-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5801) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5801#issuecomment-2725348044 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] API changeset subscription resource (PR #5801)

2025-03-14 Thread Tom Hughes via rails-dev
Merged #5801 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5801#event-16778327177 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

2025-03-14 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 5 commits. 1ffc19192e089c4e75d9db7889d08cd67c1322db Create api changeset subscription resource e763c82456f76170b0b743d39d3da3d910d38352 Split api changeset subscription tests d09757edaf6093e413e66bcce2b5989924372b84 Test legacy api changeset subscribe/unsubscribe paths 485

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-03-14 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > + +class SocialLink < ApplicationRecord + belongs_to :user + + validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message => :http_parse_error } + + URL_PATTERNS = { +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\.

Re: [openstreetmap/openstreetmap-website] Revise search forms (PR #5765)

2025-03-14 Thread Tom Hughes via rails-dev
Merged #5765 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5765#event-16777875466 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Align bottoms of date-username-changeset_id and counters in history (PR #5800)

2025-03-14 Thread Tom Hughes via rails-dev
Merged #5800 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5800#event-16777680245 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Disable asynchronous object layer loading (PR #5799)

2025-03-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5799) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5799#issuecomment-2725223986 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] opening https://www.openstreetmap.org/way/12432594/ link does not center map where way is (Issue #5798)

2025-03-14 Thread Roland Hieber via rails-dev
rohieb left a comment (openstreetmap/openstreetmap-website#5798) Can reproduce this, on mobile as well as on desktop view. I noticed that the map no longer jumps around when the side/top pane is opened on mobile, so maybe it is related to that. -- Reply to this email directly or view it on Git

Re: [openstreetmap/openstreetmap-website] Align bottoms of date-username-changeset_id and counters in history (PR #5800)

2025-03-14 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 2b8986f04c4bc6315562ae3aca26f1ed053d54ab Align bottoms of date-username-changeset_id and counters in history -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5800/files/4438bb56a09bcf93bf71398b78769784fb6ee901..2b8986f04c4bc6315562

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757) @deevroman btw if you use italics in your list, see #2869. That was one of the things I got rid of. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5757#iss

[openstreetmap/openstreetmap-website] Align bottoms of date-username-changeset_id and counters in history (PR #5800)

2025-03-14 Thread Anton Khorev via rails-dev
Moves "Closed (date) by (user)" lines down slightly if necessary to align with edit counters. Before / after for different users: ![image](https://github.com/user-attachments/assets/5785f5e8-8b4d-4b05-b9c3-4f56a471a5ae) ![image](https://github.com/user-attachments/assets/7c4c2e50-dcd5-4821-bb13

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-14 Thread Mateusz Konieczny via rails-dev
matkoniecz left a comment (openstreetmap/openstreetmap-website#5757) > It has been this way for years and nobody (as far as I know) complained. well, I have weird hobbies but I am not going to spend several days on making 500+ issues about every single part of interface on osm.org that makes me

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757) @matkoniecz We have arguments about things I didn't change, including zero comments icon. What do you think is going to happen if I change them? -- Reply to this email directly or view it on GitHub: https://github.com/openstr

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757) > Well, if someone is utterly unfamiliar with interface then showing message > icons does not tell you that there are no messages either. That's why there's "0" next to the icon. > It rather tells them that there ARE messages

[openstreetmap/openstreetmap-website] Disable asynchronous object layer loading (PR #5799)

2025-03-14 Thread Anton Khorev via rails-dev
Fixes #5798. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5799 -- Commit Summary -- * Disable asynchronous object layer loading -- File Changes -- M app/assets/javascripts/leaflet.map.js (3) -- Patch Links

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-14 Thread Mateusz Konieczny via rails-dev
matkoniecz left a comment (openstreetmap/openstreetmap-website#5757) > Removing the icon when there are no messages doesn't tell you that there are > no messages. It tells you that there are maybe no messages, or that maybe > we're not showing the number of messages, just to you for some reason,

Re: [openstreetmap/openstreetmap-website] Wrong details after selecting version (Issue #5618)

2025-03-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5618) > why not have it say "Current version" or "Last version" ? "Details" is a leftover from the times when there was a "details" page, a "history" page and that was it. I'm not sure if calling the main element page "version" is

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757) Removing the icon when there are no messages doesn't tell you that there are no messages. It tells you that there are maybe no messages, or that maybe we're not showing the number of messages, just to you for some reason, or a

Re: [openstreetmap/openstreetmap-website] Installation on Ubuntu 24.04 Failure with Mini Racer (Issue #5733)

2025-03-14 Thread Mateusz Konieczny via rails-dev
matkoniecz left a comment (openstreetmap/openstreetmap-website#5733) but still, it is not something that would be fixed or fixable by osm.org development? and in this case > Re-opening, since we try to support developers with fresh installs, up to the > point that they can get the tests runnin

Re: [openstreetmap/openstreetmap-website] Installation on Ubuntu 24.04 Failure with Mini Racer (Issue #5733)

2025-03-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5733) It's not really fixed - they closed the mini_racer bug because they determined the real problem was in libv8 and the PR to fix that is still open (https://github.com/rubyjs/libv8-node/pull/36). -- Reply to this email directly