[openstreetmap/openstreetmap-website] Remove jquery-simulate (PR #5567)
It [isn't under active development](/jquery/jquery-simulate) anymore. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5567 -- Commit Summary -- * Remove jquery-simulate -- File Changes -- M app/assets/javascrip
Re: [openstreetmap/openstreetmap-website] Use dark mode map tiles in embed (PR #5522)
Closed #5522. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5522#event-16088603746 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Use dark map tiles in embed (PR #5519)
Closed #5519. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5519#event-16088595579 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of .js.erb files (PR #5559)
@hlfan pushed 1 commit. 87530daa135e258662dbbeea21d3bdb9e380cc75 Move eslint-plugin-erb to devDependencies -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/78549a11181da90cbbdff86f448ea690d8fdb163..87530daa135e258662dbbeea21d3bdb9e380cc75 You are rec
Re: [openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)
Merged #5556 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5556#event-16087773842 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)
Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5556#issuecomment-2617949161 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev
[openstreetmap/openstreetmap-website] Remove unused max_features parameter from feature warning (PR #5566)
The message doesn't have max number of features in it, only the current number is present:  The max number use was added in https://github.com/openstreetmap/openstreetmap-website/commit/8027dc85b13af383ce030
[openstreetmap/openstreetmap-website] Remove IE conditional compilation that limited max features (PR #5565)
This targets Internet Explorer 8, a browser that wouldn't work for many other reasons. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5565 -- Commit Summary -- * Remove IE conditional compilation that limited max f
Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)
I guess @hlfan deleted the posts about "bricking" which were offtopic. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2617824960 You are receiving this because you are subscribed to this thread. Message ID: _
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of .js.erb files (PR #5559)
@AntonKhorev commented on this pull request. On package.json: > and jquery-simulate too no https://github.com/openstreetmap/openstreetmap-website/blob/8cab3c468507657cf4013aabd59d3310d7b9eea6/app/assets/javascripts/index/history.js#L43 -- Reply to this email directly or view it on GitHub: h
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of .js.erb files (PR #5559)
@hlfan commented on this pull request. On package.json: Probably, and jquery-simulate too, which has been sitting here for over four years. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5559#discussion_r1931356140 You are re
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of .js.erb files (PR #5559)
@HolgerJeromin commented on this pull request. On package.json: The eslint plugin should be added to devDependency? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5559#pullrequestreview-2576756889 You are receiving this becaus
[openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.5 to 2.3.6 (PR #5564)
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.5 to 2.3.6.Release notes
Sourced from coverallsapp/github-action's releases.
[openstreetmap/openstreetmap-website] DataLayer to consume JSON format responses (PR #5563)
https://github.com/openstreetmap/leaflet-osm/pull/44 introduced OSM JSON support in the underlying leaflet osm package. This PR enables the new feature by requesting application/json format (via Accept header). You can view, comment on, or merge this pull request online at: https://github.com/
Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)
@nenad-vujicic pushed 9 commits. 26b3a557d0e1ebe4e58db6613a29e4607953eaad Adds optional using of notes records c0371ab00eba60ccac109a65145695cd259db1ca Added helper routine note_description a1747d6d306c8a28151c24654349b3140101232c Replaced using description with note_description 2e5288961234ce
Re: [openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)
Merged #5561 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5561#event-1608300 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)
Merged #5562 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5562#event-1608301 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5562#issuecomment-2616706362 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5561#issuecomment-2616704016 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Moves the note's description, author ID, and author IP from the first comment to the note itself (PR #5485)
> Hi @grekko, thanks for asking this! We hope we'll merge transition from using > first comment to using notes records, adding notes versions, adding editable > note tags and removing of special first comment in next few months. There are > a lot of stuffs [in reworking > proposal](https://gith
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
Closed #4481. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481#event-16082761472 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
I will close this PR since @nenad-vujicic is making progress with their Notes refactoring efforts which cover and surpass the scope of this PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-2616643773 You are r
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)
I will create the PR to switch to JSON format shortly: https://github.com/mmd-osm/openstreetmap-website/tree/patch/datalayerjson -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-2616458723 You are receiving this b
[openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)
After #5474, data rendering is no longer a bottle of performance. Modern browsers do a great job with moving the map, which displays many objects (moreover, it can also be accelerated) The only exception is mobile browsers. Therefore, I stopped at 4000 objects. You can view, comment on, or merge
Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)
@AntonKhorev @tomhughes do you have any further comment / request on this PR? Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5511#issuecomment-2616343008 You are receiving this because you are subscribed to this thread.
[openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)
#5551 added a window with an error if the user is trying to download too much data. But this window cannot be closed, only turn off the Map Data layer. But what if you have already turned it off? https://github.com/user-attachments/assets/0b40a9ed-c3b7-47ee-90fb-67b264880ff9 Now it looks like t
[openstreetmap/openstreetmap-website] Remove layersAdded variable from map.updateLayers() (PR #5560)
`layersAdded` is a leftover from `updateLayers` logic before #5474, when there was a single loop that both added and removed layers. Now there are two loops, the first one is removing layers, while the second one is adding, but it can only add one layer. Before this PR: - the second loop checks
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)
Merged #5474 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474#event-16079344538 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of our .js.erb files (PR #5549)
Closed #5549. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5549#event-16079473799 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of our .js.erb files (PR #5549)
Superseded by #5559 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5549#issuecomment-2616020065 You are receiving this because you are subscribed to this thread. Message ID: ___ rails
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of .js.erb files (PR #5559)
@gravitystorm approved this pull request. This looks good to me - this is what I was looking for, i.e. the nontrivial things fixed and the plugin enabled. I would like one of the other maintainers to double-check this too. -- Reply to this email directly or view it on GitHub: https://github.
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)
Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-2616013192 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev
Re: [openstreetmap/openstreetmap-website] "layeradd layerremove" event handlers dramatically slow down Map data layer rendering (Issue #5466)
Closed #5466 as completed via #5474. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5466#event-16079344969 You are receiving this because you are subscribed to this thread. Message ID: _
Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)
Up until now, whenever I was writing JavaScript, I struggled to get ESLint to work as seamlessly as Prettier—for example, automatically linting files and displaying errors in real-time while writing code. I noticed you added a VS Code workspace in this PR, and I’m hopeful this will help improve
Re: [openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)
@kcne approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5556#pullrequestreview-2575621097 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)
@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5556#pullrequestreview-2575527413 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)
I remade PR. I abandoned `overlaylayerchange` because this event is not in Leaflet and it is not suitable in our situation. In the case of `baselyerchange`, we can expect that our last base layer is always removed and a new base layer is added. Therefore, the removal event is not necessary to t
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)
@deevroman pushed 1 commit. dae7a003fee3c9a413c959381a558e4d5636f3bd Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/9a43e994a2402156641da95fa
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlayadd/overlayremove instead of layeradd/layerremove (PR #5474)
@deevroman pushed 1 commit. 9a43e994a2402156641da95fafe63a0c975c059b Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/e3b440dc1059b9ba330335f64
Re: [openstreetmap/openstreetmap-website] Add date and url settings for offline message (PR #5403)
@nenad-vujicic approved this pull request. This works great on my side, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5403#pullrequestreview-2575266765 You are receiving this because you are subscribed to this thread.
Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)
@AntonKhorev commented on this pull request. > @@ -44,6 +44,15 @@ def index end @issues, @newer_issues_id, @older_issues_id = get_page_items(@issues, :limit => @params[:limit]) + +@unique_reporters = @issues.each_with_object({}) do |issue, reporters| + user_ids = issue.repo
Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)
@AntonKhorev commented on this pull request. > +1.upto(5).each do |n| + issue.reports << create(:report, :user => create(:user, :display_name => "Test Name #{n}")) +end ```suggestion create_list(:report, 5, :issue => issue) ``` because you're not checking if usernames match `"Test
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@deevroman pushed 1 commit. e3b440dc1059b9ba330335f6491d0ec95713b494 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/0707400118d51cf3a4160a401
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@deevroman pushed 1 commit. 0707400118d51cf3a4160a4010eec7a89c90db79 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/57bff79cd6ac07a1cff816841
Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)
Can we keep this on topic please... I have no idea what holes you are referring to in any case - we made the decision to allow newer JS features and knew full well that might affect a very small number of people using old browsers but in any case this is not the place to discuss it. Until @maro
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@mmd-osm > Besides, there may be some timing issue in the current code, as the behavior > is not 100% reproducible for me, even today. Sometimes the map layer changes > along with the share link, in other cases, the old layer is still shown. I think I found a way to reproduce this (If you meant
Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)
Merge conflict was fixed and `master` was rebased. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2615382657 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb (PR #5550)
@hlfan commented on this pull request. > + var baseLayers = { +cyclosm: ["CyclOSM"], +cyclemap: ["CycleMap", thunderforestOptions], +transportmap: ["TransportMap", thunderforestOptions], +hot: ["HOT"], +mapnik: ["Mapnik", mapnikOptions] + }; + baseLayers["cycle map"] = bas
Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)
@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2575002097 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)
@nertc pushed 1 commit. ea0667a47a41ed957f10dcf10b5aa8d9f46e15fd Add profile location -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/777eb643422fcd5267c647b388e14144e8f5fe09..ea0667a47a41ed957f10dcf10b5aa8d9f46e15fd You are receiving this because yo
Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb (PR #5550)
@HolgerJeromin commented on this pull request. > -new L.OSM.CycleMap(thunderforestOptions).addTo(map); - } else if (args.layer === "transportmap") { -new L.OSM.TransportMap(thunderforestOptions).addTo(map); - } else if (args.layer === "hot") { -new L.OSM.HOT().addTo(map); - } else
Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb (PR #5550)
@AntonKhorev commented on this pull request. > + var baseLayers = { +cyclosm: ["CyclOSM"], +cyclemap: ["CycleMap", thunderforestOptions], +transportmap: ["TransportMap", thunderforestOptions], +hot: ["HOT"], +mapnik: ["Mapnik", mapnikOptions] + }; + baseLayers["cycle map"]
Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)
No, it's fine, but IMO it shows the holes in the https://github.com/openstreetmap/openstreetmap-website/labels/dx that something like this could've raised an error and, on the other side, so many linting errors didn't get caught. -- Reply to this email directly or view it on GitHub: https://gi
Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)
> and then fixes all uses of var to respect that Not in unmerged pull requests. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5558#issuecomment-2615295202 You are receiving this because you are subscribed to this thread. Messag
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
Merge conflict was fixed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2615292764 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc pushed 1 commit. 8263827fa86f1b6a3b21919ee8e016ac5d64b6f2 Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/dc9d0cb25294d9b69c78e5cade34a9ca4e38ac3e..8263827fa86f1b6a3b21919ee8e016ac5d64b6f2 You are receiving this becaus
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
Thank you @gravitystorm. I asked Aleksandar, and it seems, you are right. He has `en-GB` as `preferred language`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2615264654 You are receiving this because you are
Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)
Well, what about the other issue in turbo.js (:5:154-178)? That's an external dependency we have no control over, and it causes the exact same issue on the (assumed to be) old browser. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/i
Re: [openstreetmap/openstreetmap-website] Embedded map - missing cs-CZ translation (Issue #5526)
Hi, I've re-checked it today and it's working now, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5526#issuecomment-2615200143 You are receiving this because you are subscribed to this thread. Message ID: _
Re: [openstreetmap/openstreetmap-website] Embedded map - missing cs-CZ translation (Issue #5526)
It was deployed a while ago and should work with `Accept-Language: cs-CZ` and `navigator.language == "cs-CZ"`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5526#issuecomment-2615192936 You are receiving this because you are s
Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)
And ESLint would have been very unhappy [if it knew to check .js.erb files](//github.com/openstreetmap/openstreetmap-website/issues/5523) and if you wrote that earlier. Because [the lint config was updated](//github.com/openstreetmap/openstreetmap-website/issues/5421) was only changed less than
