[openstreetmap/openstreetmap-website] Include message_read attribute in api output of messages to self (PR #5520)

2025-01-18 Thread Anton Khorev via rails-dev
Fixes #5489 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5520 -- Commit Summary -- * Include message_read attribute in api output of messages to self -- File Changes -- M app/views/api/messages/_message.json

[openstreetmap/openstreetmap-website] Use dark map tiles in embed (PR #5519)

2025-01-18 Thread Marwin Hochfelsner via rails-dev
This PR - Adds layer type switching based on a **new theme parameter** and prefers-color-scheme - Rewrites argument extraction and application of layer and bbox - Lints this file apparently for the first time Doesn't touch the CSS though. You can view, comment on, or merge this pull request onlin

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-18 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. 43d60108daf5f097b81afd2200273713e244b9b7 Add tabbed navigation to user's diary comments page 9fbe52dd219c5f11ebee0243da4d08574cc761c5 Create user comments controller base class 420d9da1f98ee167a351828b2f20d3f1f0e164e7 Create changeset_comments resources for use

[openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-18 Thread Anton Khorev via rails-dev
A new version of #4248. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5518 -- Commit Summary -- * Simplify diary_comments_path calls in tests * Rename diary_comments_path to user_diary_comments_path * Change us

[openstreetmap/openstreetmap-website] Use resourceful routes for traces feeds (PR #5517)

2025-01-18 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5517 -- Commit Summary -- * Add regexp constraints to trace ids * Create traces feed resource -- File Changes -- M app/abilities/ability.rb (2) A app/contr

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread Marwin Hochfelsner via rails-dev
> Thanks for all your work on the different versions. Thank _you_ for being the necessary devil's advocate and pushing me to ditch the futureproofing attempts. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5507#issuecomment-259

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode (PR #5340)

2025-01-18 Thread Tom Hughes via rails-dev
I believe so, yes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5340#issuecomment-2599792845 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-d

Re: [openstreetmap/openstreetmap-website] Friend cleanups (PR #5512)

2025-01-18 Thread Anton Khorev via rails-dev
Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5512#issuecomment-2599773377 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev

Re: [openstreetmap/openstreetmap-website] Friend cleanups (PR #5512)

2025-01-18 Thread Anton Khorev via rails-dev
Merged #5512 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5512#event-15986107070 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use transport-dark tiles for Transport map in dark mode (Issue #5395)

2025-01-18 Thread Marwin Hochfelsner via rails-dev
Is this fixed with #5507? Or would you like to have the lack of a filter for the OpenCycleMap layer documented anywhere in the code? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5395#issuecomment-2599781102 You are receiving

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode (PR #5340)

2025-01-18 Thread Tom Hughes via rails-dev
Closed #5340. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5340#event-15986254965 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode (PR #5340)

2025-01-18 Thread Marwin Hochfelsner via rails-dev
Isn't this also superseded by #5507? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5340#issuecomment-2599784165 You are receiving this because you are subscribed to this thread. Message ID: _

[openstreetmap/openstreetmap-website] Use resourceful routes for api tracepoints (PR #5516)

2025-01-18 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5516 -- Commit Summary -- * Use resourceful routes for api tracepoints -- File Changes -- M config/routes.rb (4) M test/controllers/api/tracepoints_controlle

Re: [openstreetmap/openstreetmap-website] Remove public domain checkbox from signup and terms pages (PR #5514)

2025-01-18 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 10 commits. 62b70f45bc2566d3ca3c0d79c72da7d46d5f49a4 Add empty pd declaration page 4469c9f5e599ab4dc2e92c9240d261c0ab25fbb7 Show checkbox on pd declaration page f5f7985fdbef5c07e2833a834c774b209cebbc9e Add explanation link to pd declaration page 0f51052e86db1e2d219633dd2c72

[openstreetmap/openstreetmap-website] Replace lookup_friend with lookup_user in FollowsController (PR #5515)

2025-01-18 Thread Anton Khorev via rails-dev
More *friend* cleanups. Removes `lookup_friend` method that sets `@friend` variable, replacing it with `lookup_user` that sets `@user`. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5515 -- Commit Summary -- * Rep

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)

2025-01-18 Thread Marwin Hochfelsner via rails-dev
Isn't this superseded by #5507? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5327#issuecomment-2599783817 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Use class based map tiles dark mode (PR #5505)

2025-01-18 Thread Tom Hughes via rails-dev
Superseded by #5507. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5505#issuecomment-2599692179 You are receiving this because you are subscribed to this thread. Message ID: ___ rails

Re: [openstreetmap/openstreetmap-website] Use class based map tiles dark mode (PR #5505)

2025-01-18 Thread Tom Hughes via rails-dev
Closed #5505. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5505#event-15985711952 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread Tom Hughes via rails-dev
Merged #5507 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5507#event-15985707383 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread Tom Hughes via rails-dev
I've tweaked this a bit to remove the unused code for adding a class and reworded the commit messages but other than that I think this looks good now. Thanks for all your work on the different versions. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/opens

Re: [openstreetmap/openstreetmap-website] Adds validating of notes foreign key (PR #5510)

2025-01-18 Thread Tom Hughes via rails-dev
Merged #5510 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5510#event-15985685184 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove "Public editing" line from settings page (PR #5513)

2025-01-18 Thread Tom Hughes via rails-dev
Merged #5513 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5513#event-15985685179 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread github-actions[bot] via rails-dev
1 Warning :warning: Merge commits are found in PR. Please rebase to get rid of the merge commits in this PR, see CONTRIBUTING.md. Generated by :no_entry_sign: https://danger.systems/";>Danger -- Reply to this em

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread Tom Hughes via rails-dev
@tomhughes pushed 7 commits. 297e8374f495d2487d42a4ad96a0f0d981ffd697 Adds validating of notes foreign key 9c744ab65da1a5ae8a94c8738878d23ed278684b Remove "Public editing" line from settings page 8809e1fd08377ebb010db09a5fd7de7e759d2583 Merge remote-tracking branch 'upstream/pull/5510' 8312dd

Re: [openstreetmap/openstreetmap-website] Remove "Public editing" line from settings page (PR #5513)

2025-01-18 Thread Tom Hughes via rails-dev
Seems reasonable to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5513#issuecomment-2599683565 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)

2025-01-18 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. Why does this need to use `[:user_id]` etc rather than the more typical `.user_id` form? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5511#pullrequestreview-2560409294 You are recei

Re: [openstreetmap/openstreetmap-website] Adds validating of notes foreign key (PR #5510)

2025-01-18 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5510#issuecomment-2599682550 You are receiving this because you are subscribed to this thread. Message ID: ___