@HolgerJeromin commented on this pull request.
> @@ -9,7 +9,7 @@
body {
font-size: $typeheight;
- --dark-mode-map-filter: brightness(.8);
+ --dark-mode-map-filter: none;
Is this needed?
```suggestion
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
Before:
After:
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/op
Non-friend nearby users section wasn't covered by tests.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5508
-- Commit Summary --
* Fix missing translation of Follow links on dashboard
-- File Changes --
M app
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2597226477
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5261 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#event-15969915553
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I'll close this since browse paths are still in use.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5463#issuecomment-2597139579
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #5463.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5463#event-15969233614
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Barebones classless filterless version of #5505.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5507
-- Commit Summary --
* Add classless dark map mode logic
* Update --dark-mode-map-filter
* Add TransportMap le
@hlfan commented on this pull request.
> @@ -516,13 +515,13 @@ body.small-nav {
}
@mixin dark-map-color-scheme {
- .leaflet-tile-container,
+ .leaflet-layer,
Removing the need to stop `.leaflet-tile` from inheriting the filter from
`.leaflet-tile-container` since `.leaflet-tile-container
@hlfan commented on this pull request.
> @@ -52,10 +57,12 @@ L.OSM.Map = L.Map.extend({
code: "G"
});
-this.on("layeradd", function (event) {
- if (this.baseLayers.indexOf(event.layer) >= 0) {
-this.setMaxZoom(event.layer.options.maxZoom);
- }
+this.on("la
@hlfan commented on this pull request.
> @@ -31,6 +31,7 @@
apiKeyId: "THUNDERFOREST_KEY"
canEmbed: true
canDownloadImage: true
+ filterClass: "no-filter"
I appeal that as long as there isn't documentation on which layers should get
which treatment in dark mode, explicitly specifying
@tomhughes pushed 1 commit.
70afbd09d615b4d726a5a58c6f0910126bd8480a Bump allowed ECMAScript version to
2021 (ES12)
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5421/files/7345c5ed0b8a6b63a2e4c79be8e4802e9c4348fc..70afbd09d615b4d726a5a58c6f0910126bd8480a
Yo
I've rebased this and modified it to target ES2021 instead.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5421#issuecomment-2596574488
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5500 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5500#event-15966323821
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5500#issuecomment-2596550502
You are receiving this because you are subscribed to this thread.
Message ID:
___
@hlfan commented on this pull request.
> @@ -52,10 +57,12 @@ L.OSM.Map = L.Map.extend({
code: "G"
});
-this.on("layeradd", function (event) {
- if (this.baseLayers.indexOf(event.layer) >= 0) {
-this.setMaxZoom(event.layer.options.maxZoom);
- }
+this.on("la
@hlfan commented on this pull request.
> @@ -52,10 +57,12 @@ L.OSM.Map = L.Map.extend({
code: "G"
});
-this.on("layeradd", function (event) {
- if (this.baseLayers.indexOf(event.layer) >= 0) {
-this.setMaxZoom(event.layer.options.maxZoom);
- }
+this.on("la
Merged #5494 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5494#event-15965997215
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5499 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5499#event-15965997275
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5499#issuecomment-2596451967
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes approved this pull request.
This looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5494#pullrequestreview-2556937510
You are receiving this because you are subscribed to this thread.
Messa
Merged #5502 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5502#event-15965889398
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5506 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5506#event-15965889357
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
> @@ -32,6 +32,11 @@ L.OSM.Map = L.Map.extend({
layerOptions.apikey = OSM[value];
} else if (property === "leafletOsmId") {
layerConstructor = L.OSM[value];
+} else if (property === "leafletOsmDarkId" && OS
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5506#issuecomment-2596402564
You are receiving this because you are subscribed to this thread.
Message ID:
___
@deevroman commented on this pull request.
> this.addLayer(this.baseLayers[i]);
} else {
+baselayerChanged = this.hasLayer(this.baseLayers[i]);
It seems that `"baselayerchange overlaylayerchange"` will work in this place
--
Reply to this email directly or view it on Gi
@AntonKhorev commented on this pull request.
> this.addLayer(this.baseLayers[i]);
} else {
+baselayerChanged = this.hasLayer(this.baseLayers[i]);
The answer to the above question was *yes* but it probably didn't affect
anything. However if we start using `baselayerchang
@AntonKhorev pushed 1 commit.
87e7f887f5da0c38b110425c9bf97b03ce728724 Remove account terms code unreachable
for unregistered users
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5506/files/e35760e3e5e72c41d7860af3495e2ef493677544..87e7f887f5da0c38b110425c9bf
Closed #5504.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5504#event-15964033363
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed in favor of #5506
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5504#issuecomment-2596108752
You are receiving this because you are subscribed to this thread.
Message ID:
___
@AntonKhorev pushed 1 commit.
e35760e3e5e72c41d7860af3495e2ef493677544 Remove account terms code unreachable
for unregistered users
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5506/files/2e92eba531c314b46c28db8fe0346177ab60474d..e35760e3e5e72c41d7860af3495
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5506
-- Commit Summary --
* Remove account terms code unreachable for unregistered users
-- File Changes --
M app/abilities/ability.rb (4)
M app/controllers/
@deevroman commented on this pull request.
> this.addLayer(this.baseLayers[i]);
} else {
+baselayerChanged = this.hasLayer(this.baseLayers[i]);
So the next handler also violates this expectation?
https://github.com/openstreetmap/openstreetmap-website/blob/b45eb03a6c026e
@AntonKhorev commented on this pull request.
> @@ -116,6 +116,7 @@ L.OSM.Map = L.Map.extend({
} else {
this.removeLayer(this.baseLayers[i]);
}
+ this.fire("baselayerchange", { layer: this.baseLayers[i] });
Yes, looks like our layers menu is wrong. Leaflet's layer sel
Do we fix `baselayerchange` everywhere before doing this PR that changes
listeners for this event?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-2595886376
You are receiving this because you are subscribed to t
@AntonKhorev commented on this pull request.
> @@ -116,6 +116,7 @@ L.OSM.Map = L.Map.extend({
} else {
this.removeLayer(this.baseLayers[i]);
}
+ this.fire("baselayerchange", { layer: this.baseLayers[i] });
You could put `this.fire ...` next to `this.addLayer ...`, th
@AntonKhorev requested changes on this pull request.
> this.addLayer(this.baseLayers[i]);
} else {
+baselayerChanged = this.hasLayer(this.baseLayers[i]);
`baselayerchange` is supposed to be fired *once* for the layer that became
visible. It's not supposed to be fired fo
> Is this branch reachable now? We don't show the terms page to unregistered
> users after the signup redesign, therefore `current_user` should be set.
Well, I was wondering about this too, but left untouched because didn't fully
understand it. Do we need to simply remove this branch (and transl
38 matches
Mail list logo
