Re: [openstreetmap/openstreetmap-website] Deprecated include of L.Mixin.Events: this property will be removed in future releases (#1598)

2024-12-25 Thread Anton Khorev via rails-dev
Closed #1598 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1598#event-15762469870 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Deprecated include of L.Mixin.Events: this property will be removed in future releases (#1598)

2024-12-25 Thread Anton Khorev via rails-dev
`L.Mixin.Events` was removed in https://github.com/openstreetmap/openstreetmap-website/commit/fb53e2af4c2cb07176c54723affbf541dbac8bac. This of course doesn't change the unmaintained plugin use. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap

Re: [openstreetmap/openstreetmap-website] When a user posts a story in their diary, give them the option to share with social media (#1391)

2024-12-25 Thread Anton Khorev via rails-dev
Mostly done in #4985. It's not exactly "When a user posts a story in their diary" because posting redirects you to a list of diary entries that doesn't have share buttons. You have to open the posted entry again to see the buttons. Maybe the redirect should be altered. If you think so, open anot

Re: [openstreetmap/openstreetmap-website] When a user posts a story in their diary, give them the option to share with social media (#1391)

2024-12-25 Thread Anton Khorev via rails-dev
Closed #1391 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1391#event-15762392949 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

[openstreetmap/openstreetmap-website] New note marker variable (PR #5443)

2024-12-25 Thread Anton Khorev via rails-dev
If - you open `/note/new` while your zoom is too low as described in #1291 - you zoom out far enough while on `/note/new`, show a warning message and disable the submit button. ![image](https://github.com/user-attachments/assets/abb8e7d1-316b-411c-94fb-614b87355330) Fixes #1291 and another bug:

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-12-25 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > + +<%= t ".location_name_warning" %> + + Yes, either on page load, or if we want to avoid an additional call on the page load, we can call Nominatim twice on the first change of the pin (one for the previous value and one fo

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-12-25 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > + +<%= t ".location_name_warning" %> + + > If `Location Name` field value exactly matches with the country name of the > pin That requires fetching the country from Nominatim before the location changes, possibly on p

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-12-25 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > + +<%= t ".location_name_warning" %> + + Thanks for suggestions. I agree with you, it seems current solution has some UI problems, but adding additional disabled input doesn't align with the UI practices we are currently usi