1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5433
-- Commit Summary --
* Move users index route to api namespace
* Move user show route to api namespace
* Move user details check methods to helper module
*
@AntonKhorev pushed 3 commits.
cf365e499e260b35e96301ad1c9c19dc790e014b Move write_api scope check to
decrease number of ifs
04d74759e8d350bbd18f417e3edd1110dafe6eed Test more block attributes in show
call
d4c88a381efd33af32157071bf1dd78f018bdc56 Add user block api call
--
View it on GitHub
@AntonKhorev pushed 2 commits.
ae9dfa7762b12ae6b2cb4266613fffe1796ff633 Test more block attributes in show
call
8cfb274510f22ec9b2e91cb1866fc3bf873fa3df Add user block api call
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4301/files/da15d996b4a7a3542a4f2eb
@AntonKhorev pushed 6 commits.
37c0c850dcf368211a195648d609a185948da4a9 Move common query limit method of
changesets and notes to mixin
b286ea666726c5cf9148971d184e7088bfad3e85 Add changeset comment query limit
settings; use common query limit in changeset comment feeds
343d5350c4321868d5f1d28
Any progress on removing the dead link?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3998#issuecomment-2557623101
You are receiving this because you are subscribed to this thread.
Message ID:
There are issues with this sentence:
`What it %{doesnt} include is opinionated data like ratings, historical or
hypothetical features, and data from copyrighted sources. Unless you have
special
permission, don't copy from online or paper maps.`
which is used on https://www.openstreetmap.org/welcom
Copy from
[Translatewiki](https://translatewiki.net/w/i.php?title=Translating_talk:OpenStreetMap&oldid=12791558#Accessibility_issue:_Osm:Confirmations.confirm.click_here/en,_Osm:Confirmations.confirm.resend_html/en):
The current message text is:
* **Confirmations.confirm.resend html**: If you ne
@tomhughes pushed 5 commits.
c61cc73923a3ae68e53b2d88a60a18ceb352a223 Drop support for ruby 3.1
5e6edf83ee28a98d004672b55d5ad483fe9ec233 Update to rails 8.0.1
5bc7d041b6d5802c719bce658ebf6c3d32a2230a Avoid parsing of XML requests with ;
in the body
3e7921f9ebb87233aad8e6ff22abff15a2641cec Use
So this also requires ruby 3.2 which is going to be painful for us in
production, so I've had to drop 3.1 support.
It also needs a git version of `annotate` though
https://github.com/ctran/annotate_models/issues/1032 suggests that it may be
dead and `annotaterb` may be taking over.
--
Reply t
@tomhughes pushed 4 commits.
3ae458b40ad5914578d52515a51b0aa8b791ae20 Drop support for ruby 3.1
a44c1897d005cbc8159cdcc283edab4820faa317 Update to rails 8.0.1
015a06cbd71b7c78d3b282fb19db5a99afdd66fb Avoid parsing of XML requests with ;
in the body
4c37c65917155953803eac02aabaf3050596d7c4 Use
@tomhughes pushed 1 commit.
a3e83301f4597dba4962465d646ef1544c5c3dbb Use rails 8 compatible annotate gem
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5430/files/4c37c65917155953803eac02aabaf3050596d7c4..a3e83301f4597dba4962465d646ef1544c5c3dbb
You are receiv
@tomhughes pushed 4 commits.
207303a6592b6f81e4e38f8045115dcd872476e9 Drop support for ruby 3.1
4f685c09dd43ce8de3bfde1cb4847bc4f0842914 Update to rails 8.0.1
f91306a932354062fcc5ea23b969710b7095a0b9 Avoid parsing of XML requests with ;
in the body
bb6551471a00fe1c3a444ff161c9f2642bcf6df9 Use
@tomhughes pushed 3 commits.
c381e9a0f60056cee69b0c9019883ae4fda14bcc Update to rails 8.0.1
df87fb9d19aeb866f419494e24b5141a1eb2907b Avoid parsing of XML requests with ;
in the body
df55d76a7c96a779ead3bcf3d46fe1ae2b41185a Use rails 8 compatible
active_record_union
--
View it on GitHub:
htt
First draft of updating to rails 8 which currently needs to pull a couple of
dependent gems from git as they are awaiting new releases for rails 8
compatibility.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5430
--
@AntonKhorev commented on this pull request.
> can :read, [:version, :capability, :permission, :map]
if Settings.status != "database_offline"
+ user = (User.find(token.resource_owner_id) if token)
removed parentheses
--
Reply to this email directly or view it on GitHub:
https
@AntonKhorev pushed 1 commit.
cdce867183b71a2fe13686d2cc7fd826f5b23043 Merge ApiCapability class into
ApiAbility
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5429/files/30ce8c6598311633f97c4e5648374c8ddee7d730..cdce867183b71a2fe13686d2cc7fd826f5b23043
You a
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5428#issuecomment-2557292512
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5428 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5428#event-15734336627
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
This looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5429#pullrequestreview-2517841441
You are receiving this because you are subscribed to this thread.
Message ID:
@AntonKhorev commented on this pull request.
> @@ -64,11 +64,7 @@ def authorize(errormessage = "Couldn't authenticate you")
def current_ability
# Use capabilities from the oauth token if it exists and is a valid access
token
-if doorkeeper_token&.accessible?
- ApiAbility.new(
Merged #5429 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5429#event-15734219570
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> @@ -64,11 +64,7 @@ def authorize(errormessage = "Couldn't authenticate you")
def current_ability
# Use capabilities from the oauth token if it exists and is a valid access
token
-if doorkeeper_token&.accessible?
- ApiAbility.new(
@tomhughes commented on this pull request.
> @@ -64,11 +64,7 @@ def authorize(errormessage = "Couldn't authenticate you")
def current_ability
# Use capabilities from the oauth token if it exists and is a valid access
token
-if doorkeeper_token&.accessible?
- ApiAbility.new(ni
@AntonKhorev pushed 1 commit.
30ce8c6598311633f97c4e5648374c8ddee7d730 Merge ApiCapability class into
ApiAbility
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5429/files/05604ee2ddf73cf2b274569ece0afb816f48d332..30ce8c6598311633f97c4e5648374c8ddee7d730
You a
Closed #5323.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5323#event-15733602965
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed in favor of #5344
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5323#issuecomment-2557165165
You are receiving this because you are subscribed to this thread.
Message ID:
___
There was an attempt to separate *abilities* and *capabilities* in
https://github.com/openstreetmap/openstreetmap-website/commit/91fc65a2e3ad47414344a6d5dc03cb5fb2a08ce1
that didn't quite work out and is no longer necessary.
You can view, comment on, or merge this pull request online at:
https
This is deprecated in rails 8.0 and 8.1 will remove it.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5428
-- Commit Summary --
* Don't map multiple paths in a single route
-- File Changes --
M config/routes.
Merged #5427 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5427#event-15732933603
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5427#issuecomment-2557047984
You are receiving this because you are subscribed to this thread.
Message ID:
___
This `.field_with_errors` writer was added in
https://github.com/openstreetmap/openstreetmap-website/commit/933b0913304fdd581c7cb3f1ec30450d6e04c63a,
but the class was not used since
https://github.com/openstreetmap/openstreetmap-website/commit/df1ec6b6809b533829fc2c171699540bbb92a85b.
You can v
Huh, no linting support for the [optional chaining
operator](https://caniuse.com/mdn-javascript_operators_optional_chaining)?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5426#issuecomment-2556962831
You are receiving this beca
A version between #5396 and #5397 using the updated version of leaflet-osm
without requiring it.
Also removing some ifs that always evaluate true and removed the dependency on
the `.key-ui`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openst
@AntonKhorev pushed 2 commits.
f9558686c45ba6ee8d5f27ef9707bbe35e62630e Don't display error messages when
second scheduled rc command fails
26e55086ab2a9f6782a0c1cd9e08d5c3d069f6f6 Return promise from
sendRemoteEditCommand()
--
View it on GitHub:
https://github.com/openstreetmap/openstreetma
@AntonKhorev pushed 3 commits.
584dc92171806446e8e8fd56f2e1f874d3fa4db7 Add blank 'comments for map edits'
page
1603cefb735388340f56074f74f09724f68e65f9 Show changeset comments table
cd0d0d086f74de58a59df8087d0050d909315ba0 Add changeset comments controller
index test
--
View it on GitHub:
@AntonKhorev pushed 6 commits.
3aa9be1db7458a7e8a9c35d970c28751601594cf Move common query limit method of
changesets and notes to mixin
71024198144923d749c385cc43a668b312b3d384 Add changeset comment query limit
settings; use common query limit in changeset comment feeds
3f2e29f20a77a563379d147
@AntonKhorev pushed 6 commits.
e2ba8ba11f87e2dbbdee653cd3ad802ba05aec69 Introduce pagination item helper
27543d8db73bdef9ca7a2ca76f129d150490d534 Replace previous/next page selectors
with helper methods in tests
cd441f7e37ada49dae902e104a0d6bb2bd232831 Add oldest/newest links to shared
pagina
@AntonKhorev pushed 7 commits.
8b6678500714c8926abf1abc5c2ea7127ea7064b Relax min id value for paging to
include 0
2038ad6102ef1173c14f84d1eccaf82fe42b92e1 Introduce pagination item helper
4e4f3c4c2940ed86e45d161c158c9a06615eae00 Replace previous/next page selectors
with helper methods in tes
Merged #5422 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5422#event-15729818497
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5425#issuecomment-2556529543
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5423 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5423#event-15729818482
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5423#issuecomment-2556527196
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5425 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5425#event-15729818494
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5424#issuecomment-2556528286
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5424 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5424#event-15729818472
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5422#issuecomment-2556524449
You are receiving this because you are subscribed to this thread.
Message ID:
___
47 matches
Mail list logo
