UX thoughts:
- Do we want users to be able to disable this feature in their profile? – I am
not a fan of this kind of configurations, but we do give a lot more visibility
to once activity with this that we had before and the page is public (AKA no
login required).
- How do we want to handle the
> > Ping https://github.com/openstreetmap/openstreetmap-website/issues/5356
> > which looks like the ambrella issue for this.
> Thanks for suggestion but in the end i ended up just mocking data in the
> database locally. Since the table is indexed it should not present issues
> performance wise.
@kcne commented on this pull request.
> @@ -1,3 +1,5 @@
+ <%= javascript_include_tag "social_share_button" %>
Updated now, forgot to push, sorry.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#discussion_r1889332637
You a
@kcne pushed 1 commit.
95e1aff23493b3725d5259bcca7bcc79d7d3bc26 Add social sharing functionality
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985/files/b02d6257b6554906ca658cc6ef887ec1d2158e9f..95e1aff23493b3725d5259bcca7bcc79d7d3bc26
You are receiving this
> What's the source(s) of all the javascript in `vendor/`?
OK, I found the answer for the cal-heatmap part of the code, which is available
as an npm module. In which case, using package.json will allow us to upgrade to
new versions automatically, and would be the preferred option.
--
Reply to
What's the source(s) of all the javascript in `vendor/`? I would expect to see
`Vendorfile` updated, or preferably if these are sourced from e.g. node
modules, then they should be included in package.json and added using the
assets pipeline. If any of these are source files, i.e. written just fo
It is a very minor nitpick, but is it possible to dynamically determine what's
the first weekday based on the user's locale and adjust the heatmap
accordingly?
[Intl.Locale.prototype.getWeekInfo()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getWe
Merged #5408 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5408#event-15691647776
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5398 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5398#event-15691647836
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5404 as completed via #5408.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5404#event-15691648044
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5405 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5405#event-15691647832
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5401 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5401#event-15691647799
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
I had been thinking we should make the message configurable because in this
case it wasn't really database maintenance but that is problematic from a
translation point of view.
Maybe we should just remove the references to database maintenance in favou
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5408#issuecomment-2549394060
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5401#issuecomment-2549386126
You are receiving this because you are subscribed to this thread.
Message ID:
___
Oh, I forgot about this.
But the user can now set his "Preferred Website Color Scheme" which should be
the basis of the theme not the browser setting.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2548889858
Y
What does it have to do with OAuth?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5407#issuecomment-2548797112
You are receiving this because you are subscribed to this thread.
Message ID:
@AntonKhorev commented on this pull request.
> @@ -1,3 +1,5 @@
+ <%= javascript_include_tag "social_share_button" %>
But it's not updated.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#discussion_r1888713943
You are rece
A standard HTTP verb for update action in Rails is PATCH/PUT, but for messages
API [it was made POST for some
reason](https://wiki.openstreetmap.org/wiki/Messaging_API_proposal#Update_read_status_of_a_message).
Here I'm adding PATCH/PUT. I'm keeping POST outside of the resources,
but we should
@kcne commented on this pull request.
> @@ -44,4 +44,5 @@
<% end %>
+
You're right. I don't know how I missed this. I've restored the changes to this
file and updated the commit. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
@kcne pushed 1 commit.
b02d6257b6554906ca658cc6ef887ec1d2158e9f Add social sharing functionality
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985/files/8ba2316df11bc0de908f589c4ff78a0337726531..b02d6257b6554906ca658cc6ef887ec1d2158e9f
You are receiving this
@kcne commented on this pull request.
> @@ -1,3 +1,5 @@
+ <%= javascript_include_tag "social_share_button" %>
Thanks for the tip. Updated now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#discussion_r1888599802
You are
@kcne pushed 1 commit.
874f59ed547e26948734e0fe0c7967a2a74c93c1 Move continue auth/start mapping
button to appear fixed in footer
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4947/files/de2723b79650a8f112fca3dbe5dc8f63e12df3f4..874f59ed547e26948734e0fe0c796
@kcne commented on this pull request.
>
<%= t ".add_a_note.title" %>
<%= t ".add_a_note.para_1" %>
<%= t ".add_a_note.para_2_html", :map_link =>
link_to(t(".add_a_note.the_map"), root_path),
:note_icon => tag.span(:class => "icon
note bg-dark r
@kcne commented on this pull request.
>
<%= t ".add_a_note.title" %>
<%= t ".add_a_note.para_1" %>
<%= t ".add_a_note.para_2_html", :map_link =>
link_to(t(".add_a_note.the_map"), root_path),
:note_icon => tag.span(:class => "icon
note bg-dark r
@kcne commented on this pull request.
> + [CalendarLabel, {
+position: "left",
+key: "left",
+text: () => weekdays,
+textAlign: "end",
+width: 30,
+padding: [23, 10, 0, 0]
+ }],
+ [Tooltip, {
+text: (date, value) => getToolti
@kcne pushed 2 commits.
a0abf9eb5c20f4166499147b4b0d37410aef2fc1 Add heatmap javascript logic, styles
and localization
b134a0ad97ecf208f7772de29efec73907b7a1ea Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402
> [cal-heatmap-rails](https://rubygems.org/gems/cal-heatmap-rails/versions/3.6.2?locale=en)
>
> > Version Released:
> > on Oct 2, 2018
>
> Are you sure about this gem? Looks like all it does is repackaging of
> (outdated version of) https://github.com/wa0x6e/cal-heatmap.
You were right. In the
@kcne commented on this pull request.
> + const heatmapElement = document.querySelector("#cal-heatmap");
+
+ if (!heatmapElement) {
+console.warn("Heatmap element not found in the DOM.");
+return;
+ }
+
+
+ const heatmapData = heatmapElement.dataset.heatmap ?
JSON.parse(heatmapEleme
@kcne pushed 4 commits.
f46796fc44038239b80418710e08f95ac4c2201a Add heatmap data caching and query
for user contributions
9d871157ea165fd139cd7b8dbfb9d1e8787a841e Add heatmap container to user profile
view
d54d35b98cbd36076a563b778d19774efa63d363 Add heatmap javascript logic, styles
and loc
Closed #5400 as completed via #5406.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5400#event-15683867907
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5406#issuecomment-2548108284
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5406 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5406#event-15683867603
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I should clarify here that this issue is "fixed" in that #5406 means the site
now won't return a 500 error for the OAuth login flow.
The read-only status on www.osm.org is still ongoing, and is a matter for the
OSMF OWG.
--
Reply to this email directly or view it on GitHub:
https://github.com/
Closed #5409 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5409#event-15683850135
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
35 matches
Mail list logo
