Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-11 Thread Nekzuris via rails-dev
No because non-logged in users can't set light map. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2537382117 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-11 Thread Nekzuris via rails-dev
Call it what you want, but I think we've collected enough feedback to conclude that dark maps aren't ready to be the default. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2537238479 You are receiving this be

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-11 Thread Anton Khorev via rails-dev
@gravitystorm > Remove the site-wide filter that's currently applied to all map layers So we're moving from *let's have the map dark in some unspecified manner* to *let's have the map not dark but still call it dark* (by default when the browser reports dark color scheme preference). That's pr

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-11 Thread Marwin Hochfelsner via rails-dev
Given the merge of #5362, should this issue be closed? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2536887818 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Use transport-dark tiles for Transport map in dark mode (Issue #5395)

2024-12-11 Thread Marwin Hochfelsner via rails-dev
Should the OpenCycleMap layer stay dimmed with reduced contrast as it currently is or should another filter (if any) be chosen to optimize the map for dark mode? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5395#issuecomment

Re: [openstreetmap/openstreetmap-website] Color mode preference (PR #5337)

2024-12-11 Thread Andy Allan via rails-dev
Closing this, since it was an alternative to #5339 / #5362 which is now merged. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2536634839 You are receiving this because you are subscribed to this thread. Message

Re: [openstreetmap/openstreetmap-website] Color mode preference (PR #5337)

2024-12-11 Thread Andy Allan via rails-dev
Closed #5337. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5337#event-15622212025 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] Use transport-dark tiles for Transport map in dark mode (Issue #5395)

2024-12-11 Thread Andy Allan via rails-dev
See #5328 for background. As the cartographer for the `transport` featured layer, I would like this project to use the `transport-dark` variant when our maps are shown in dark mode. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/iss

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-11 Thread Andy Allan via rails-dev
Some people are asking why this is taking a long time to fix, but from my own side unfortunately personal circumstances have had a large part to play. Thank you to everyone for you patience. I haven't seen any substantial counter-proposal to my "option 4c" suggestion ("Cartographers choose") ea

Re: [openstreetmap/openstreetmap-website] Disable filter inheritance on tiles, apply filter to tile container (PR #5387)

2024-12-11 Thread Tom Hughes via rails-dev
Merged #5387 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5387#event-15622001773 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Disable filter inheritance on tiles, apply filter to tile container (PR #5387)

2024-12-11 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5387#issuecomment-2536584636 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Map color mode preference (PR #5362)

2024-12-11 Thread Andy Allan via rails-dev
Thanks @AntonKhorev , I think this works well. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5362#issuecomment-2536543710 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Color mode preference stored in db (PR #5339)

2024-12-11 Thread Andy Allan via rails-dev
Merged #5339 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5339#event-15621756654 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Map color mode preference (PR #5362)

2024-12-11 Thread Andy Allan via rails-dev
Merged #5362 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5362#event-15621756178 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

[openstreetmap/openstreetmap-website] iD: listen to URL hash changes (PR #5394)

2024-12-11 Thread Martin Raifer via rails-dev
When the `map` hash parameter is changed (and was not not triggered by map interaction from inside iD itself): pan to the new location. This mirrors the behaviour when manually editing the `map` hash parameter on osm.org outside of iD. This also fixes https://github.com/openstreetmap/iD/issues/

Re: [openstreetmap/openstreetmap-website] Resourceful routes for traces API (PR #5390)

2024-12-11 Thread Andy Allan via rails-dev
Merged #5390 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5390#event-15619240864 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Resourceful routes for traces API (PR #5390)

2024-12-11 Thread Andy Allan via rails-dev
Looks good to me, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5390#issuecomment-2536078545 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Hover effect is different in buttons (Issue #5367)

2024-12-11 Thread Andy Allan via rails-dev
@JoeCelaster Please see [our Contributing Guide](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#assigning-issues) section "Assigning Issues". -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-12-11 Thread Anton Khorev via rails-dev
> Here you can see that the post box symbol is barely visible The way icons are displayed was changed recently, try refreshing the page. This is how the post box icon should look like: ![image](https://github.com/user-attachments/assets/137d4ec3-91dc-4993-974f-480a8eeb7c48) -- Reply to this e

[openstreetmap/openstreetmap-website] Group untagged way nodes with same related ways (PR #5393)

2024-12-11 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5393 -- Commit Summary -- * Group untagged way nodes with same related ways -- File Changes -- M app/helpers/browse_helper.rb (22) M app/views/browse/_way.ht

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-12-11 Thread mp747474 via rails-dev
Changesets look really funny in dark mode. Here you can see that the post box symbol is barely visible against the dark background due to the low contrast, while the generic node symbol is almost flashy due to how bright it is: ![grafik](https://github.com/user-attachments/assets/505918a3-74d7-4

Re: [openstreetmap/openstreetmap-website] Disable filter inheritance on tiles, apply filter to tile container (PR #5387)

2024-12-11 Thread Anton Khorev via rails-dev
Looks like the amount of this grid lines effect depends on the filter used. With invert+rotate filters it almost disappears on desktop, but is still significantly noticeable on mobile. But that could be just because the overall brightness of tiles. -- Reply to this email directly or view it on

Re: [openstreetmap/openstreetmap-website] Custom layer filters (PR #5347)

2024-12-11 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 5 commits. 73170726e2e1c6f5dcbb649f82c4a845b9d6e980 Add map filter css property 2e024ba28996442a38df9076bc63ff808b15e197 Manage base layer switching in L.OSM.Map 24184cebae53a0facfcecca5a9377f6ab4a633de Define custom dark filters for map layers 55f7e23630673ebf31d32075af5c

Re: [openstreetmap/openstreetmap-website] Disable filter inheritance on tiles, apply filter to tile container (PR #5387)

2024-12-11 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. 73170726e2e1c6f5dcbb649f82c4a845b9d6e980 Add map filter css property b87983c2baf55d437c09e668188454d01b5f20b0 Disable filter inheritance on tiles, apply filter to tile container -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/53