Re: [openstreetmap/openstreetmap-website] Show "node also part of ways" as nested lists on way pages (PR #5317)

2024-12-06 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. 6aab00415f58e02abd73407f96e01e7a4206170e Show "node also part of ways" as nested lists on way pages f5819344caf0a31edcfe9315d0732eea0589bc2d Put nested "also..." lists into collapsible details -- View it on GitHub: https://github.com/openstreetmap/openstreetmap

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-12-06 Thread Anton Khorev via rails-dev
> Ok, I think you would need to further elaborate on your proposal #5385 as a first step in replacing css backgrounds with images. See how I only use one pixel value of 20px / 1.25rem. > The old rendering looked a bit off, in particular for the (part of ways...) > section. *Part of ways* I'd d

Re: [openstreetmap/openstreetmap-website] Write browse element icons as (PR #5385)

2024-12-06 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. f2edeace8d56549a13cb867460dfd91393a74454 Write browse element icons as df6dd0a6fb7fe54bf2d0804bb25cac7976835037 Adjust browse line/icon height/alignment for text-only zooming -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5385

Re: [openstreetmap/openstreetmap-website] Write browse element icons as (PR #5385)

2024-12-06 Thread github-actions[bot] via rails-dev
1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Generated by :no_entry_sign: https://danger.systems/";>Danger -- Reply to this e

[openstreetmap/openstreetmap-website] Write browse element icons as (PR #5385)

2024-12-06 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5385 -- Commit Summary -- * Write browse element icons as * Adjust browse line/icon height/alignment for text-only zooming -- File Changes -- D app/asset

[openstreetmap/openstreetmap-website] Remove logger.debug from relation update action (PR #5384)

2024-12-06 Thread Anton Khorev via rails-dev
Was added in https://github.com/openstreetmap/openstreetmap-website/commit/2b7a40069f7af2e72c81f9488411135f286515f9. A similar debug statement also existed for nodes, added in https://github.com/openstreetmap/openstreetmap-website/commit/328d47e506972fededfa1080967224928c36a4cf, later removed.

Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)

2024-12-06 Thread Anton Khorev via rails-dev
Removed `controller_name`, using `type_plural = current_model.model_name.plural` instead. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-2522920946 You are receiving this because you are subscribed to this threa

Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)

2024-12-06 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 5 commits. b734a6f76c2a168fd9238a0b31fbf53fcc767f58 Test required parameter message in element multi fetch b9863dcbd45782a0151564413c34256b14b1fa75 Add generic api elements controller for multi fetches a6abd0157d5ea6d2f97c351aaf0c0e9eac39bd4b Add basic version support to e

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-06 Thread Manuel Reimer via rails-dev
@mkyral Thanks 😉 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2522850417 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-d

[openstreetmap/openstreetmap-website] Let header username expand to screen width in small nav mode (PR #5383)

2024-12-06 Thread Anton Khorev via rails-dev
Before: ![image](https://github.com/user-attachments/assets/515569f3-57d4-4d8d-bea7-312e1c818f0e) After: ![image](https://github.com/user-attachments/assets/a0aab805-aebc-4322-9859-daea6a484775) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/op

Re: [openstreetmap/openstreetmap-website] Display changeset element pagination vertically (PR #4567)

2024-12-06 Thread Anton Khorev via rails-dev
Probably looks too weird and may not work well with something like #5355 where I don't want to spend extra horizontal space. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4567#issuecomment-2522635517 You are receiving this becau

Re: [openstreetmap/openstreetmap-website] Display changeset element pagination vertically (PR #4567)

2024-12-06 Thread Anton Khorev via rails-dev
Closed #4567. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4567#event-15557241085 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] Don't interpolate type in issue title (PR #5382)

2024-12-06 Thread Anton Khorev via rails-dev
The title of `/issues/:id` pages is constructed by substituting the status into the locale string, making it difficult to translate. ![image](https://github.com/user-attachments/assets/6bd5764d-4e05-405a-8990-054dd101b341) This PR makes it closer to what we have for note titles: https://github.c