Re: [openstreetmap/openstreetmap-website] broken order on note creation dates with some RTL usernames (Issue #3964)

2024-12-05 Thread Anton Khorev via rails-dev
Seems fixed now: ![image](https://github.com/user-attachments/assets/3a9b9ecf-070b-4c9a-a191-b885904c0a10) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3964#issuecomment-2522293392 You are receiving this because you are subsc

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Marián Kyral via rails-dev
I think, options to switch on/off dark style and on/off tiles dim should be implemented. Until it's done, everyone can use Stylush addon with Un-Darken Map Tiles style from M-Reimer. Works for me ;-) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstr

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Enno Hermann via rails-dev
> unanimous criticism This is debatable because people who didn't notice the change or are fine with it are unlikely to come and post here. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2522217516 You are re

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread mxdanger via rails-dev
This whole dimmed tiles situation really goes to show how much of a mess this project management is at the moment. How can something as important as the MAP ITSELF be treated as an afterthought? It is quite literally the most important part of the website yet no community discussion took place

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Oscar McNoe via rails-dev
@hlfan adding an option only for logged in users still doesn't fix the dimmed tiles issue for anyone who's not logged into an account, which I'd guess is a majority of users? The dimmed tiles will still be the **default** option for all visitors to the site. The dimmed tiles are just really ba

Re: [openstreetmap/openstreetmap-website] Map color mode preference (PR #5362)

2024-12-05 Thread Oscar McNoe via rails-dev
This will only be configurable for logged in users, meaning that non-logged in will still be stuck on the dark UI + dimmed tiles. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5362#issuecomment-2522096154 You are receiving this

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Nekzuris via rails-dev
@tomFlowee Only maintainers can merge this, there are three: one is in favor, another is the one who added the filter, and the last one doesn't want to do anything related to dark mode. It's ridiculous. You can install the Stylus extension ([Firefox](https://addons.mozilla.org/en-US/firefox/add

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread tomFlowee via rails-dev
@hlfan > but to have no change at all would be counterproductive To remove the filter and get the tiles to show exactly like the png's are, that would indeed be ideal at this time. This is not counter productive, this is SOLVING A BUG that was introduced a month ago. I have not used OSM for a

Re: [openstreetmap/openstreetmap-website] Truncate if necessary and set dir=auto for note usernames (PR #5377)

2024-12-05 Thread Tom Hughes via rails-dev
Merged #5377 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5377#event-15548710492 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] broken order on note creation dates with some RTL usernames (Issue #3964)

2024-12-05 Thread Tom Hughes via rails-dev
Closed #3964 as completed via #5377. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3964#event-15548710764 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Use translated model names in issue type select (PR #5380)

2024-12-05 Thread Tom Hughes via rails-dev
Merged #5380 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5380#event-15548619185 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Truncate if necessary and set dir=auto for note usernames (PR #5377)

2024-12-05 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5377#issuecomment-2521149634 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Don't show types twice in issue type select (PR #5381)

2024-12-05 Thread Tom Hughes via rails-dev
Merged #5381 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5381#event-15548619153 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Don't show types twice in issue type select (PR #5381)

2024-12-05 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5381#issuecomment-2521135890 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Use translated model names in issue type select (PR #5380)

2024-12-05 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5380#issuecomment-2521133413 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Marwin Hochfelsner via rails-dev
> it's ridiculous that the filter still hasn't been rolled back in spite of > overwhelming opposition from community members. Well, the current proposal by the maintainers includes an impossible requirement of "make it dark but don't pick any filter", as stated in https://github.com/openstreetm

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-05 Thread gmar5 via rails-dev
Personally, I find the discussion of "colour-modes" for maps misleading. Maps have colours, selected by the developers of a map style based on their own criteria and preferences. If you change those colours (you want them darker? a different background? inverted? etc.) then you are creating a ne

Re: [openstreetmap/openstreetmap-website] Hover effect is different in buttons (Issue #5367)

2024-12-05 Thread Joe Celaster via rails-dev
Can i work on this issue -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5367#issuecomment-2520672363 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Oscar McNoe via rails-dev
There isn't any need to get into the blame game of who did what, but it's ridiculous that the filter still hasn't been rolled back in spite of overwhelming opposition from community members. If @AntonKhorev is committed to solving dark map tiles with filters that's fine, but the filters need to

Re: [openstreetmap/openstreetmap-website] Adds note tags support (PR #5344)

2024-12-05 Thread Nenad Vujicic via rails-dev
Here is the latest update with removed validation (which allows k and v to be empty strings, like they can be in e.g. [this node](https://www.openstreetmap.org/node/9842077514) (@kcne thanks for helping in catching this). I haven't added other stuffs (composite index - this will be part of sepa

Re: [openstreetmap/openstreetmap-website] Adds note tags support (PR #5344)

2024-12-05 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 8 commits. c213dc73ef45a368c950278aec84f0eaa985410c Added NoteTag model and note_tags table fe9843964667255bc6a4e02ac21a828dd7a4374d Added displaying tags on Notes sidebar 0120c6e6827985aaab80aa7e8fcb541dae49844b Updated (j)builder files with note tags 29aa9c6e4558ca3423

Re: [openstreetmap/openstreetmap-website] Browse element folding nested lists and icons (PR #5355)

2024-12-05 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 6 commits. af0dbc93a011e9b112188f82e45927cfceec2412 Show "node also part of ways" as nested lists on way pages 7b79abea1ee44e4aa75382f7e2d9a189a830bace Put nested "also..." lists into collapsible details e2899d798921940add8e358adb21cc72ca7dc7ea Group tagless way nodes with

[openstreetmap/openstreetmap-website] Don't show types twice in issue type select (PR #5381)

2024-12-05 Thread Anton Khorev via rails-dev
If you have both moderator and admin flags, the issue search form is going to have "User" twice. Before: ![image](https://github.com/user-attachments/assets/57bc307a-57c9-427b-8c7b-21531ffebec3) After: ![image](https://github.com/user-attachments/assets/f0dd0428-5dce-41cc-861f-c26cf1039697) You

[openstreetmap/openstreetmap-website] Use translated model names in issue type select (PR #5380)

2024-12-05 Thread Anton Khorev via rails-dev
Before: ![image](https://github.com/user-attachments/assets/49013f8b-b7f3-4937-8e87-721cefbe0b49) After: ![image](https://github.com/user-attachments/assets/cb9b0386-54cf-42c2-a61b-6703f0f6f9bd) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/op