[openstreetmap/openstreetmap-website] Truncate if necessary and set dir=auto for message usernames (PR #5372)

2024-12-02 Thread Anton Khorev via rails-dev
Before: ![image](https://github.com/user-attachments/assets/152b3b71-d23d-427f-8718-3e7050b35fe4) After: ![image](https://github.com/user-attachments/assets/15eb04cf-8a61-4a99-bfae-c5bc62158f68) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/o

Re: [openstreetmap/openstreetmap-website] Dynamic "more" dropdown with small Bootstrap breakpoint (PR #5370)

2024-12-02 Thread Holger Jeromin via rails-dev
This would result in having the projects name "never" visible for small screens... not sure this is good -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5370#issuecomment-2513791593 You are receiving this because you are subscribe

Re: [openstreetmap/openstreetmap-website] Truncate if necessary and set dir=auto for changeset usernames (PR #5371)

2024-12-02 Thread Holger Jeromin via rails-dev
@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5371#pullrequestreview-2474831612 You are receiving this because you are subscribed to this thread. Message ID: __

[openstreetmap/openstreetmap-website] Truncate if necessary and set dir=auto for changeset usernames (PR #5371)

2024-12-02 Thread Anton Khorev via rails-dev
Before: ![image](https://github.com/user-attachments/assets/7aab4e90-b7d6-43b2-8dd2-83e4297d960c) After: ![image](https://github.com/user-attachments/assets/71f86563-d69f-4331-9ce6-94dc4e117915) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/op

[openstreetmap/openstreetmap-website] No compact nav 2 hide logo (PR #5370)

2024-12-02 Thread Anton Khorev via rails-dev
A version of #5363 that uses a smaller breakpoint by hiding "OpenStreetMap" as described in https://github.com/openstreetmap/openstreetmap-website/pull/5363#issuecomment-2513598424. ![image](https://github.com/user-attachments/assets/964c184d-0a2e-4a3c-9e8d-b14af693be42) ![image](https://github.

Re: [openstreetmap/openstreetmap-website] Dynamic "more" dropdown (PR #5363)

2024-12-02 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 5 commits. 73500b039b663af0bce0f8290688fb01b2498232 Switch to/from compact nav by moving nav items ca4f16e9ec540f9a20ca6b69450d82528ea41b99 Use fixed small/compact nav breakpoint width 3439d3116de4200884d0d6751d17dbe5df956a51 Move secondary menu items to "more" dropdown d

Re: [openstreetmap/openstreetmap-website] Dynamic "more" dropdown (PR #5363)

2024-12-02 Thread Anton Khorev via rails-dev
> it moves all remaining buttons too early Do you mean the width breakpoint for "small mode" with burger menu is too high? It has to be one of [the Bootstrap breakpoints](https://getbootstrap.com/docs/5.3/layout/breakpoints/) if I'm to use their navbar later. The only smaller breakpoint is 576p

[openstreetmap/openstreetmap-website] Bump rails-html-sanitizer from 1.6.0 to 1.6.1 (PR #5369)

2024-12-02 Thread dependabot[bot] via rails-dev
Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer) from 1.6.0 to 1.6.1.
Release notes

Sourced from rails-html-sanitizer's releases.

1.6.1 /


[openstreetmap/openstreetmap-website] Replace the text with the icon in the parent relation list (Issue #5368)

### Problem After #5353 this already works for the ways: https://github.com/user-attachments/assets/6f4548f9-92e3-496e-8179-97e1988258e8";> https://www.openstreetmap.org/node/7925741250 But not for relations: https://github.com/user-attachments/assets/5ee293cd-0eaf-456e-a44a-c67d01a52851";> h

Re: [openstreetmap/openstreetmap-website] Dynamic "more" dropdown (PR #5363)

Somehow it moves all remaining buttons too early on my side. Here is a video: https://github.com/user-attachments/assets/88d8c735-84e2-4d3b-bbc8-bca56b052df8 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5363#issuecomment-2511

Re: [openstreetmap/openstreetmap-website] Set dir=auto on usernames in block lists (PR #5365)

Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5365#issuecomment-2511756827 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Set dir=auto on username in header (PR #5364)

Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5364#issuecomment-2511746694 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Set dir=auto on usernames in block lists (PR #5365)

Merged #5365 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5365#event-15494465113 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Set dir=auto on username in header (PR #5364)

Merged #5364 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5364#event-15494465095 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Truncate usernames in block navigation tabs (PR #5366)

Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5366#issuecomment-2511766481 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Better database discovery (PR #5308)

@nenad-vujicic thanks, will look into that. To all: regarding this PR, what are your thoughts? Do you feel this can bring value to contributors? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5308#issuecomment-2511656346 You are

Re: [openstreetmap/openstreetmap-website] Truncate usernames in block navigation tabs (PR #5366)

Merged #5366 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5366#event-15494465064 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Hover effect is different in buttons (Issue #5367)

Well that is your subjective opinion certainly - mine is different. Let's see what other people think. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5367#issuecomment-2511541296 You are receiving this because you are subscribe

Re: [openstreetmap/openstreetmap-website] Hover effect is different in buttons (Issue #5367)

> This is a deliberate design decision - the left hand side is a primary > navigation element and the right hand side is a secondary navigation element > and what you are seeing is how bootstrap styles those. > > In addition the hover colour matches the outline colour which seems > reasonable t

Re: [openstreetmap/openstreetmap-website] add "edit" button to mobile version (#2233)

@AntonKhorev just a quick reminder that we will have to re think the dropdown as well as the settings once https://github.com/openstreetmap/operations/issues/877 is resolved and we can finally talk about adding more mobile editors to the UI. The discussion on this [seems to be ongoing](https:/

Re: [openstreetmap/openstreetmap-website] Hover effect is different in buttons (Issue #5367)

This is a deliberate design decision - the left hand side is a primary navigation element and the right hand side is a secondary navigation element and what you are seeing is how bootstrap styles those. In addition the hover colour matches the outline colour which seems reasonable to me - it wo

[openstreetmap/openstreetmap-website] Hover effect is different in buttons (Issue #5367)

### Problem log in and sign up buttons hover effect is differ then edit button hover effect. user experience is not so good ### Screenshots login and sign up button have grey background color ![Screenshot 2024-12-02 164636](https://github.com/user-attachments/assets/27173e88-1659-44df-997e-2c

Re: [openstreetmap/openstreetmap-website] Truncate usernames in block navigation tabs (PR #5366)

@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5366#pullrequestreview-2472240325 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Set dir=auto on usernames in block lists (PR #5365)

@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5365#pullrequestreview-2472234124 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Set dir=auto on username in header (PR #5364)

@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5364#pullrequestreview-2472233213 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] add "edit" button to mobile version (#2233)

What I want to try: - add `josm:` scheme to the dropdown #5351 - if it work, make it selectable in preferences - that's still a problem for those who have *remote control* as a preference; to fix that add another option: *remote control or josm scheme depending on the platform* -- Reply to this

[openstreetmap/openstreetmap-website] Truncate usernames in block navigation tabs (PR #5366)

Draft, need to check if it's possible to do without wrapping usernames in spans first. Before: ![image](https://github.com/user-attachments/assets/9c7d4782-8031-4114-adc3-2ab38fc59b7f) After: ![image](https://github.com/user-attachments/assets/be8ed423-c1c2-4ffc-bcef-bc12500517d7) You can view,

Re: [openstreetmap/openstreetmap-website] Show edit and export on small screens (PR #4839)

Closed #4839. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4839#event-15489846328 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] Set dir=auto on usernames in block lists (PR #5365)

Same as #5364 but for block lists. Before: ![image](https://github.com/user-attachments/assets/2b7451eb-6420-4088-bb29-b3ce00bd6487) ![image](https://github.com/user-attachments/assets/d1eb9e57-0351-4df3-becc-6318db1a2693) After: ![image](https://github.com/user-attachments/assets/6eb3ec75-193d-4

[openstreetmap/openstreetmap-website] Set dir=auto on username in header (PR #5364)

There's a problem with truncated usernames if their directionality doesn't match the ui. This PR fixes the current username in the header. Before: ![image](https://github.com/user-attachments/assets/e19aa034-b6b1-48a2-8086-20b61a05b181) After: ![image](https://github.com/user-attachments/assets/

Re: [openstreetmap/openstreetmap-website] add "edit" button to mobile version (#2233)

Why the dropdown would be a problem? Surely you're not going to select "remote control" from it if you don't have anything that supports remote control running on the device. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2233