Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-19 Thread Marwin Hochfelsner via rails-dev
Well, if we're going to think long term then the shortbread eclipse style comes to my mind. But I don't think anyone here wants to have that stop gap "solution" in there for _that_ long. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-19 Thread Marwin Hochfelsner via rails-dev
> And I don't think the lighter background behind the 𝐢 looks good. How would you like to have the button indicate that it's disabled then? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2487685324 You are rec

Re: [openstreetmap/openstreetmap-website] Offer links to competing mapping services' websites (Issue #5343)

2024-11-19 Thread Oscar McNoe via rails-dev
I think this could raise concerns regarding copyright. Looking at Google maps data and then contributing improvements to OSM data based on that is a copyright violation. It's probably best for OSM not to directly link to external services where integrating those services data into OSM is not leg

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-19 Thread mxdanger via rails-dev
Dimming the map was probably the worst possible thing contributors (cough cough @AntonKhorev) could have done. It's a terrible stop gap solution and it really did fumble the launch of dark mode. What could have been a nice update that just made the UI dark, they _really_ just had to mess with th

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-19 Thread Wilhem275 via rails-dev
> I get that people are scared that we will mess up the map. It's normal for > users to be afraid of UI changes even when they are good for them long term. > But just saying that it isn't gonna work isn't productive. It's also not helpful to dismiss other opinions with "people don't know how th

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-19 Thread Nekzuris via rails-dev
The control buttons don't change in dark mode, I think that's good, but the tooltip shouldn't change then. current dark mode vs light mode ![dark](https://github.com/user-attachments/assets/4832f8ea-1b79-41d0-8aa2-12f6ae175db5) ![light](https://github.com/user-attachments/assets/0da60b4b-b797-44

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-11-19 Thread Marwin Hochfelsner via rails-dev
However, for OSM's most prominent raster map, Carto, this isn't planned, as it's considered out of scope. https://github.com/gravitystorm/openstreetmap-carto/issues/5044#issue-2660981521 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website

Re: [openstreetmap/openstreetmap-website] Bump qs from 6.13.0 to 6.13.1 (PR #5341)

2024-11-19 Thread Tom Hughes via rails-dev
Merged #5341 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5341#event-15353934205 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-19 Thread pkrasicki via rails-dev
>Until vector maps are implemented, any tampering with the map via CSS filters >should be avoided. @mxdanger But why? @hlfan has shown us a few solutions that might work. If you see a specific problem with any of them, point it out and we will see if it can be fixed. I get that people are scare

Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)

2024-11-19 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. I wonder about the overall approach of doing this in a concern - would it be better to do it in `RichText::Base` perhaps? What I envisage is a new method there to do truncation and then altering the `to_html` methods in the derived classes to take an o

Re: [openstreetmap/openstreetmap-website] Better database discovery (PR #5308)

2024-11-19 Thread Nenad Vujicic via rails-dev
> 1. I'm using [Cytoscape.js](https://js.cytoscape.org) for the > [auto-layouts](https://github.com/azimuttapp/azimutt/blob/main/frontend/ts-src/index.ts#L500), > I don't know why some nodes still overlap sometimes, still investigating. > But I'm not sure I can do much better and used algorithm

[openstreetmap/openstreetmap-website] Offer links to competing mapping services' websites (Issue #5343)

2024-11-19 Thread 積丹尼 Dan Jacobson via rails-dev
### Problem With the decline of https://wiki.openstreetmap.org/wiki/OSM_Smart_Menu https://wiki.openstreetmap.org/wiki/OpenSwitchMaps etc. I hereby officially propose such functionality be incorporated into the openstreetmap.org itself! Yes, offering links to "competitors' websites" is one sure w

Re: [openstreetmap/openstreetmap-website] Offer links to competing mapping services' websites (Issue #5343)

2024-11-19 Thread Holger Jeromin via rails-dev
How does this help mappers? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5343#issuecomment-2485696176 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-19 Thread Marwin Hochfelsner via rails-dev
> @hlfan Just out of curiosity, can we apply a CSS filter on top to fix that? 😆 > The filter for the gamma dimming in `url(#gamma)contrast(95%)` is written > like this: > Another I built on blending modes does this too, but with way more saturation > (I already turned it down to 50% with `satur