Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)
The solution to dark mode for the tiles isn't to dim the light mode tiles. It's to design and develop a dark version of the standard tile theme. This is approach taken by Google Maps and Apple Maps. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstree
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
I think it's worth taking a lesson from other web mapping providers. All of them have taken the 4th approach, of developing complete dark mode tiles for the map. It's the most costly/labour intensive to develop, but it's also likely to have the best overall outcome in the long term. -- Reply t
Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)
@AntonKhorev It will make `Reporter Users` cells too high which will cause additional whitespaces in other cells. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2484796738 You are receiving this because you are
[openstreetmap/openstreetmap-website] Slow objects fetching on backend (Ruby on Rails) (Issue #5342)
### URL https://map.petabyte.pro ### How to reproduce the issue? Are there any settings/features that I need to configure/enable to make it load fast? Because in production I see it loads immediately. Thank you! Just open the iD editor and all the objects in Addis Ababa are going to load slow
Re: [openstreetmap/openstreetmap-website] Enable dark mode attribution font color (PR #5338)
Merged #5338 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5338#event-15325496937 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
[openstreetmap/openstreetmap-website] Bump qs from 6.13.0 to 6.13.1 (PR #5341)
Bumps [qs](https://github.com/ljharb/qs) from 6.13.0 to 6.13.1.
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc pushed 1 commit. e13e04e4bcaa5749f543b5e5d15bc96b8d69f808 Provide a truncated view of recent diaries -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/2f6e72a8c8f2215847fc23e6afd70fe1e7ce0d0c..e13e04e4bcaa5749f543b5e5d15bc96b8d69f808 You are re
Re: [openstreetmap/openstreetmap-website] Better database discovery (PR #5308)
> I believe this utility (and similar ones) can be very useful when starting > out. Hi @nenad-vujicic thanks for your feedback :+1: Glad you found Azimutt very useful. About your two issues: 1. I'm using [Cytoscape.js](https://js.cytoscape.org) for the [auto-layouts](https://github.com/azimut
Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)
Can someone please rebase and merge this? Its monday, plenty of office-going people will see the darkened map for the first time and it would help immensely to avoid the influx of bugreports and complaints on support channels. We know from the large amount of upheaval that this css rule brought
Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.14.0 to 9.15.0 (PR #5335)
Merged #5335 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5335#event-15325716221 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
> > Because the main purpouse of dark modes is not to alter colours altogether, > > it's to avoid large fields of pure bright white. As you'll find in > > Wikipedia or default Gmail's backgrounds (or Github, now that I see it). > > And in order to do that, you have to alter colors. You change th
Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)
For the future, can we get a map dark mode similar to how the Dark Reader extension does it? Image  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-w
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
Yay and then the discussion was locked. Great move 🎉 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2484032800 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
The logical decision would be unaltered map as the default. Until vector maps are implemented, any tampering with the map via CSS filters should be avoided. It’s still ridiculous to me that the dimmed map was implemented in the first place with no discussion in #4712 aside from @tomhughes who do
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc commented on this pull request. > + def truncate_html(html, max_length, empty_tag_length = 500) +doc = Nokogiri::HTML::DocumentFragment.parse(html) +accumulated_length = 0 +truncated_node = nil + +doc.traverse do |node| + if accumulated_length >= max_length +
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc pushed 1 commit. f5a5cfc94be4aa89137401a308a7716effa640f5 Provide a truncated view of recent diaries -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/e13e04e4bcaa5749f543b5e5d15bc96b8d69f808..f5a5cfc94be4aa89137401a308a7716effa640f5 You are re
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
PR was updated. Paragraph truncation was removed. Max length of the diary entry in the list was changed to 2000. Images now take size of 1000 character. Additional parsing to the RichText was removed and now HTML is directly sanitized and marked as safe. -- Reply to this email directly or vi
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc commented on this pull request. > @@ -280,8 +280,10 @@ resource :profile, :only => [:edit, :update] # friendships - match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend" - match "/user/:display_name/remove_friend" => "
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc commented on this pull request. > @@ -2,7 +2,7 @@ <%= render :partial => "diary_entry_heading", :object => diary_entry, :as => "diary_entry" %> -<%= diary_entry.body.to_html %> +<%= truncated ? diary_entry.truncated_body(1000).to_html : diary_entry.body.to_html %> Addi
Re: [openstreetmap/openstreetmap-website] Better database discovery (PR #5308)
> So my request here is to other contributors, particularly new contributors - > can you try it out please? Have you found this useful, and if so, what did > you learn? Do you need a whole-database overview when you start working on > the project? I started learning the OSM source code about si
Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)
Merged #5297 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5297#event-15336203775 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)
Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5297#issuecomment-2483399111 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev
Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)
@kcne commented on this pull request. > @@ -6,6 +6,20 @@ :commented => tag.span(t(".subheading_commented"), :class => "px-2 py-1 bg-body") %> <% end %> +<%= form_with :url => url_for(:controller => "notes", :action => "index"), :method => :get, :data => { :turbo => true } do %>
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
>from what I've been able to discern by fiddling around, fine-tuning away the >old-photo-like yellowish look would take more effort than it's worth. @hlfan Just out of curiosity, can we apply a CSS filter on top to fix that? :laughing: >Yes, kind of kidding, but depending on where the preferenc
Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)
@kcne pushed 1 commit. 738e66afa6231390f52679fe8b343478643f5684 Add status filter to user's note page -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5297/files/b56dc10cec6239c067cca43f38176627f51887a5..738e66afa6231390f52679fe8b343478643f5684 You are receiving
Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)
@kcne commented on this pull request. > @@ -6,6 +6,20 @@ :commented => tag.span(t(".subheading_commented"), :class => "px-2 py-1 bg-body") %> <% end %> +<%= form_with :url => url_for(:controller => "notes", :action => "index"), :method => :get, :data => { :turbo => true } do %>
[openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode (PR #5340)
Closes #5327 See #5328 and https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2482070226 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5340 -- Commit Summary -- * Remove brightness fi
Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)
@ChrisJoubert2501 I managed to fix my performance issue by disabling and re-enabling style customization with userChrome.css in `about:config` `toolkit.legacyUserProfileCustomizations.stylesheets`, restarting Firefox after each setting change. However, other users with less powerful machines an
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc commented on this pull request. > + def truncate_html(html, max_length, empty_tag_length = 500) +doc = Nokogiri::HTML::DocumentFragment.parse(html) +accumulated_length = 0 +truncated_node = nil + +doc.traverse do |node| + if accumulated_length >= max_length +
Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)
The [osm element highlight color](https://www.openstreetmap.org/way/24240315#map=18/52.516070/13.379459) is quite saturated. This depends on the monitor setting and for sure the color of the rendered map.  I
