### URL
_No response_
### How to reproduce the issue?
when I use M1 Mac to build this project. it can not run this command 'bundle
exec rails db:create'
bundle exec rails db:create
bin/rails aborted!ls db:create
Closed #5280 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5280#event-14801809934
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
We're just relaying the instructions from the routing engines - if you have a
problem with the instructions then you need to address it with those engines as
we have no control over them.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-websit
### Problem
At an intersection, even if no left or right turn is involved,
directions should still say "go straight onto road B",
when departing road A.
To get from green marker to red marker, one takes these roads,
1. 仁愛路四段48巷
2. 四維路52巷19弄
3. 信義路四段99巷
Alas, due to no turns being involved,
ht
> I believe similar changes to remaining OSM.OldBrowse() occurrences will
> enable displaying old ways / relations versions? :-)
As soon as
https://github.com/openstreetmap/openstreetmap-website/pull/4930#issuecomment-2198793487
is done.
> Q: I found one strange behavior with nodes / ways / re
Fails
:no_entry_sign:
`bla.sh` failed.
### Log
```
```
Generated by :no_entry_sign: https://danger.systems/js";>dangerJS
against 7aeafbd890108734b866df1eaac8ef9b595d5cab
--
Reply to this email directly or view it on
Fails
:no_entry_sign:
bla
Generated by :no_entry_sign: https://danger.systems/js";>dangerJS
against 7aeafbd890108734b866df1eaac8ef9b595d5cab
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/op
Fails
:no_entry_sign:
`bla.rb` failed.
### Log
```
Hello from ruby!
{
"fails": [
{
"message": "Gem/Bundle changes were not documented in the Description. If
this is a major update, add #gemlock_major_upgrade to the
> I'm explicitly passing it's hash as the head. [...] PR branch should still be
> present and accessible.
I suspect that there must be more to pull_request_target to prevent untrusted
code from accidentally being executed with elevated privileges...
--
Reply to this email directly or view it
I've taken my question over to
https://github.com/danger/danger/issues/1103#issuecomment-2430080724
Maybe you can keep an eye the discussion over there a bit. We probably need to
move to danger-js.
https://danger.systems/js/usage/danger-process as proposed in one answer seems
to fit nicely to
That's not in any way relevant - it's running in the context of the base branch
(master) in my repo as well but the target is still there and I'm explicitly
passing it's hash as the head.
All pull_request_target means is that it doesn't merge the PR branch into
master before running, so that th
Yes, it's a security feature:
https://github.blog/news-insights/product-news/github-actions-improvements-for-fork-and-pull-request-workflows/
_-> new pull_request_target event [...] runs against the workflow and code
from the base of the pull request. This means the workflow is running from a
It worked for
https://github.com/tomhughes/openstreetmap-website/actions/runs/11465903348 so
it must be something specific to cross-repo PRs :-(
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2429953036
You a
It seems it's still failing:
https://github.com/openstreetmap/openstreetmap-website/actions/runs/11466048440/job/31905883310?pr=5270
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2429943268
You are receiving
@mmd-osm pushed 1 commit.
429cb593fccb03360b4c140be0782621708a14bf Unauthenticated session expiry
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..429cb593fccb03360b4c140be0782621708a14bf
You are receiving thi
I did some testing in my fork and I'm hopeful that
8e54d0f2aeaad8648a60e4685fa64380c45c5631 will actually fix it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2429930890
You are receiving this because you ar
@nenad-vujicic approved this pull request.
This works great on my side, thanks!
I believe similar changes to remaining OSM.OldBrowse() occurrences will enable
displaying old ways / relations versions? :-)
Q: I found one strange behavior with nodes / ways / relations pagination
controls. They i
Speaking as one of the people who tends to get involved when people try and
upload "wrong edits", it's quite useful to have some sort of canary around
(such as a large bounding box that shouldn't cover 0,0 but does) when they
occur. We'd typically want to look at what _else_ they have done wron
Closed #5279 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5279#event-14786343336
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
Unless it isn't like when there was a buoy moored there.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5279#issuecomment-2429403859
You are receiving this because you are subscribed to this thread.
Message ID:
___
### Problem
What about rejecting edits where a node, or a way's node, has coordinates 0, 0
([null island](https://en.wikipedia.org/wiki/Null_Island))? It must always be a
bug in the editor.
### Description
_No response_
### Screenshots
_No response_
--
Reply to this email directly or view
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line
https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
might be interesting. It describes a set up, where untrusted code is processed
by an `on: pull_request` step (which has access to the pull request). In this
step we could run danger, similar to what chef/chef is doi
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line
The token is not the problem - the problem is getting it to find the commits.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2428964609
You are receiving this because you are subscribed to this thread.
Message
It seems GitHub also supports [tokens with fine-grained set
permissions](https://docs.github.com/en/rest/authentication/permissions-required-for-fine-grained-personal-access-tokens?apiVersion=2022-11-28),
although they are still in Beta. Using these we can set write permissions for
labels only.
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line if con
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line if con
Thank you for the review. This PR was updated according to recommendations.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2428445343
You are receiving this because you are subscribed to this thread.
Message ID:
@nertc commented on this pull request.
> @@ -280,8 +280,8 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend" => "f
@nertc pushed 1 commit.
8393857518195d145a5f1e8252b939f731cff25c Modify the way Friends are added
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/e1a1b87211fde02664d5a16a970a98c6df5d061a..8393857518195d145a5f1e8252b939f731cff25c
You are receiving thi
31 matches
Mail list logo
