[openstreetmap/openstreetmap-website] Bump eslint from 9.12.0 to 9.13.0 (PR #5271)
Bumps [eslint](https://github.com/eslint/eslint) from 9.12.0 to 9.13.0.Closed #4361. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4361#event-14727982128 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Timestamps across the web site / make format user selectable (#631)
Been meaning to find the right file to commit this into and propose it as pull request but I keep not getting around to it... Simple CSS-only solution that doesn't change anything else except lets you see the title text for `abbr` elements on mobile and desktop consistently: ![screenshot of a w
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID:
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929 Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/77dabb6abfd1eef8241d79fe648a01ad16e13fda..9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929 You are receiving this because you are s
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
Closed #5252 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5252#event-14723546783 You are receiving this because you are subscribed to this thread. Message ID: ___ rai
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 77dabb6abfd1eef8241d79fe648a01ad16e13fda Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..77dabb6abfd1eef8241d79fe648a01ad16e13fda You are receiving this because you are s
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
https://github.com/openstreetmap/openstreetmap-website/actions/runs/11407724340/job/31744367292 seems to be doing a bit better. I have replaced `pull_request_target: types: [opened, synchronize]` by `on: [pull_request]`. The token doesn't have access to remove or add labels: ``` Error me
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID:
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff You are receiving this because you are s
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
Closed #5252 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5252#event-14723554282 You are receiving this because you are subscribed to this thread. Message ID: ___ r
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/915cb20421c0304804efe0c7ed6eb17e397ed79d..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID:
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 915cb20421c0304804efe0c7ed6eb17e397ed79d Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..915cb20421c0304804efe0c7ed6eb17e397ed79d You are receiving this because you are s
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
I don't think share links with node/way/relations are a good fit for sharing and publishing elsewhere. Remember, element ids are not stable and could change at any time, even by your "criminals". I vote for closing this issue, since it's fairly off topic for the site. -- Reply to this email di
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
Why check every comment though when the initial open will always be the first one? There's still a question about resolution I think? Should we be looking at every one or just the last one? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-web
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
Oh sorry I looked at the source last night and was quite sure they were all marked as opened. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5269#issuecomment-2422681177 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
Another option is to ignore all close events other than the last one, that's symmetrical to ignoring reopen events. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5269#issuecomment-2422639257 You are receiving this because you ar
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
This is a test only for original open events: > comment.event == "opened" Reopen events are stored as `"reopened"`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5269#issuecomment-2422613954 You are receiving this because you a
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
After your change the test is: ```ruby opened_by_user = note.comments.any? { |comment| comment.author == @user && comment.event == "opened" } ``` which will be true if the user has ever opened it, either the original open or a reopen? -- Reply to this email directly or view it on GitHub: http
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
> You say you ignore reopen events but in fact this seems to extend the concept > of submitted/created from who initially opened it to include anybody that > reopens it as well? Are you proposing to treat reopen events exactly like initial open events? That's not what we're currently doing with
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
What about RUNNING_IN_ACTIONS=true ? This seems to be still missing. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2421500814 You are receiving this because you are subscribed to this thread. Message ID: ___
