Re: [openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-13 Thread Tom Hughes via rails-dev
Did you close this because you realised the problem with it? That pagination needs any ordering to be on a unique index so that the cursor positioning can work... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5259#issuecommen

Re: [openstreetmap/openstreetmap-website] split Javascripts.share.image_dimensions to allow translations (Issue #5195)

2024-10-13 Thread maro-21 via rails-dev
Yes, it sounds like a good solution. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5195#issuecomment-2409018170 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-13 Thread Emin Kocan via rails-dev
Closed #5259 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5259#event-14619886643 You are receiving this because you are subscribed to this thread. Message ID: ___ r

[openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-13 Thread Emin Kocan via rails-dev
### Problem Currently, we use a custom `PaginationMethods` module, which sorts and filters data using IDs. Sorting by other attributes (e.g., created_at or updated_at) does not work correctly, and implementing sorting with these attributes would require changes to `PaginationMethods`. Additiona

Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)

2024-10-13 Thread mmd via rails-dev
According to https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#nominatim-prefixes, "I18n keys under the geocoder.search_osm_nominatim" are managed by Nominatim maintainers. I'm not exactly clear how this was done in the past. Maybe @lonvia can help here. -- R

Re: [openstreetmap/openstreetmap-website] split Javascripts.share.image_dimensions to allow translations (Issue #5195)

2024-10-13 Thread mmd via rails-dev
Looking through existing translations, it might be even better to have three separate strings for each of the three relevant layers. Instead of "Image will show the %{layer} layer at %{width} x %{height} ", that would be: * Image will show the Standard layer at %{width} x %{height} * Image will

Re: [openstreetmap/openstreetmap-website] Add optional two-factor authentication for user accounts (Issue #3476)

2024-10-13 Thread mmd via rails-dev
By the way, most third party login providers should support 2FA. This might be a good alternative for the time being. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3476#issuecomment-2408929916 You are receiving this because yo

Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)

2024-10-13 Thread mmd via rails-dev
New entry for highway=busway to be added here: https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L920 ![image](https://github.com/user-attachments/assets/a1663f9d-1739-42e8-a839-480e8fb56ddf) -- Reply to this email directly or view it on GitHub: https://g

Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)

2024-10-13 Thread mmd via rails-dev
New entry for highway=busway to be added here: https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L920 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2408916808 You are